Re: [dm-devel] [PATCH AUTOSEL 5.4 03/26] dm integrity: select CRYPTO_SKCIPHER

2021-02-04 Thread Sasha Levin
On Tue, Jan 19, 2021 at 09:47:31PM -0800, Eric Biggers wrote: On Tue, Jan 19, 2021 at 08:26:40PM -0500, Sasha Levin wrote: From: Anthony Iliopoulos [ Upstream commit f7b347acb5f6c29d9229bb64893d8b6a2c7949fb ] The integrity target relies on skcipher for encryption/decryption, but certain

Re: [dm-devel] [PATCH] multipathd: avoid crash in uevent_cleanup()

2021-02-04 Thread Martin Wilck
On Thu, 2021-02-04 at 09:40 +0800, lixiaokeng wrote: > > > On 2021/2/3 21:57, Martin Wilck wrote: > > > If exit() before all pthread_cancel in child of 0.7.7, there is > > > no > > > any crash. > > What do you mean with "exit() before all pthread_cancel"? If this > > happens on pthread_cancel(),

Re: [dm-devel] [QUESTION]: multipath device with wrong path lead to metadata err

2021-02-04 Thread Martin Wilck
On Thu, 2021-02-04 at 19:25 +0800, lixiaokeng wrote: > > Hi Martin, > > On 2021/1/27 7:11, Martin Wilck wrote: > > So we can only conclude that (if there's no kernel refcounting bug, > > which I doubt) either orphan_path()->uninitialize_path() had been > > called (closing the fd),  or that

Re: [dm-devel] [PATCH] libmultipath: check if adopt_path() really added current path

2021-02-04 Thread Martin Wilck
On Thu, 2021-02-04 at 15:41 +0800, lixiaokeng wrote: > > > On 2021/2/3 21:14, Martin Wilck wrote: > > On Wed, 2021-02-03 at 17:42 +0800, lixiaokeng wrote: > > > > > > > > > On 2021/2/3 16:14, Martin Wilck wrote: > > > > Is this also a Tested-by:? > > > > IOW, did it fix your issue? > > > > >

Re: [dm-devel] [PATCH v4 2/6] block: add blk_interposer

2021-02-04 Thread Sergei Shtepa
The 02/03/2021 11:18, Mike Snitzer wrote: > On Wed, Feb 03 2021 at 10:53am -0500, > Sergei Shtepa wrote: > > > blk_interposer allows to intercept bio requests, remap bio to another > > devices or add new bios. > > > > Signed-off-by: Sergei Shtepa > > --- > > block/bio.c | 2 +

Re: [dm-devel] [PATCH v4 1/6] docs: device-mapper: add remap_and_filter

2021-02-04 Thread Sergei Shtepa
Thank you, I'll fix it all. -- Sergei Shtepa Veeam Software developer. -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] BUG: KASAN: stack-out-of-bounds in unwind_next_frame+0x1df5/0x2650

2021-02-04 Thread Ivan Babrou
> Can you pretty please not line-wrap console output? It's unreadable. GMail doesn't make it easy, I'll send a link to a pastebin next time. Let me know if you'd like me to regenerate the decoded stack. > > edfd9b7838ba5e47f19ad8466d0565aba5c59bf0 is the first bad commit > > commit

Re: [dm-devel] BUG: KASAN: stack-out-of-bounds in unwind_next_frame+0x1df5/0x2650

2021-02-04 Thread Ivan Babrou
On Wed, Feb 3, 2021 at 4:17 PM Josh Poimboeuf wrote: > > On Wed, Feb 03, 2021 at 03:30:35PM -0800, Ivan Babrou wrote: > > > > > Can you recreate with this patch, and add "unwind_debug" to the > > > > > cmdline? > > > > > It will spit out a bunch of stack data. > > > > > > > > Here's the three

Re: [dm-devel] BUG: KASAN: stack-out-of-bounds in unwind_next_frame+0x1df5/0x2650

2021-02-04 Thread Ivan Babrou
On Wed, Feb 3, 2021 at 11:05 AM Josh Poimboeuf wrote: > > On Wed, Feb 03, 2021 at 09:46:55AM -0800, Ivan Babrou wrote: > > > Can you pretty please not line-wrap console output? It's unreadable. > > > > GMail doesn't make it easy, I'll send a link to a pastebin next time. > > Let me know if you'd

Re: [dm-devel] BUG: KASAN: stack-out-of-bounds in unwind_next_frame+0x1df5/0x2650

2021-02-04 Thread Ivan Babrou
On Wed, Feb 3, 2021 at 3:28 PM Josh Poimboeuf wrote: > > On Wed, Feb 03, 2021 at 02:41:53PM -0800, Ivan Babrou wrote: > > On Wed, Feb 3, 2021 at 11:05 AM Josh Poimboeuf wrote: > > > > > > On Wed, Feb 03, 2021 at 09:46:55AM -0800, Ivan Babrou wrote: > > > > > Can you pretty please not line-wrap

Re: [dm-devel] [QUESTION]: multipath device with wrong path lead to metadata err

2021-02-04 Thread lixiaokeng
Hi Martin, On 2021/1/27 7:11, Martin Wilck wrote: > So we can only conclude that (if there's no kernel refcounting bug, > which I doubt) either orphan_path()->uninitialize_path() had been > called (closing the fd), or that opening the sd device had failed in > the first place (in which case the

Re: [dm-devel] BUG: KASAN: stack-out-of-bounds in unwind_next_frame+0x1df5/0x2650

2021-02-04 Thread Peter Zijlstra
On Wed, Feb 03, 2021 at 09:46:55AM -0800, Ivan Babrou wrote: > > Can you pretty please not line-wrap console output? It's unreadable. > > GMail doesn't make it easy, I'll send a link to a pastebin next time. > Let me know if you'd like me to regenerate the decoded stack. Not my problem that you

[dm-devel] [PATCH] dm writecache: return the exact values that were set

2021-02-04 Thread Mikulas Patocka
LVM doesn't like it when the target returns different values from what was set in the constructor. This patch fixes dm-writecache, so that the returned values are exactly the same as requested values. Signed-off-by: Mikulas Patocka Cc: sta...@vger.kernel.org # v4.18+ Index:

Re: [dm-devel] BUG: KASAN: stack-out-of-bounds in unwind_next_frame+0x1df5/0x2650

2021-02-04 Thread Josh Poimboeuf
On Wed, Feb 03, 2021 at 04:52:42PM -0800, Ivan Babrou wrote: > We also have the following stack that doesn't touch any crypto: > > * https://gist.github.com/bobrik/40e2559add2f0b26ae39da30dc451f1e Can you also run this through decode_stacktrace.sh? Both are useful (until I submit a fix for

Re: [dm-devel] BUG: KASAN: stack-out-of-bounds in unwind_next_frame+0x1df5/0x2650

2021-02-04 Thread Josh Poimboeuf
On Wed, Feb 03, 2021 at 02:41:53PM -0800, Ivan Babrou wrote: > On Wed, Feb 3, 2021 at 11:05 AM Josh Poimboeuf wrote: > > > > On Wed, Feb 03, 2021 at 09:46:55AM -0800, Ivan Babrou wrote: > > > > Can you pretty please not line-wrap console output? It's unreadable. > > > > > > GMail doesn't make it

Re: [dm-devel] BUG: KASAN: stack-out-of-bounds in unwind_next_frame+0x1df5/0x2650

2021-02-04 Thread Josh Poimboeuf
On Wed, Feb 03, 2021 at 09:44:48PM -0500, Steven Rostedt wrote: > > > [ 128.441287][C0] RIP: 0010:skcipher_walk_next > > > (crypto/skcipher.c:322 crypto/skcipher.c:384) > > Why do we have an RIP in skcipher_walk_next, if its the unwinder that > had a bug? Or are they related? > > Or did

Re: [dm-devel] [PATCH] dm: fix iterate_device sanity check

2021-02-04 Thread JeffleXu
Any comment? Thanks, Jeffle On 2/2/21 11:35 AM, Jeffle Xu wrote: > According to the definition of dm_iterate_devices_fn: > * This function must iterate through each section of device used by the > * target until it encounters a non-zero return code, which it then returns. > * Returns zero if

Re: [dm-devel] BUG: KASAN: stack-out-of-bounds in unwind_next_frame+0x1df5/0x2650

2021-02-04 Thread Josh Poimboeuf
On Wed, Feb 03, 2021 at 03:30:35PM -0800, Ivan Babrou wrote: > > > > Can you recreate with this patch, and add "unwind_debug" to the cmdline? > > > > It will spit out a bunch of stack data. > > > > > > Here's the three I'm building: > > > > > > *

Re: [dm-devel] BUG: KASAN: stack-out-of-bounds in unwind_next_frame+0x1df5/0x2650

2021-02-04 Thread Josh Poimboeuf
On Wed, Feb 03, 2021 at 09:46:55AM -0800, Ivan Babrou wrote: > > Can you pretty please not line-wrap console output? It's unreadable. > > GMail doesn't make it easy, I'll send a link to a pastebin next time. > Let me know if you'd like me to regenerate the decoded stack. > > > >