Re: [dm-devel] [RFC PATCH 08/11] block: use per-task poll context to implement bio based io poll

2021-03-16 Thread Ming Lei
On Tue, Mar 16, 2021 at 02:46:08PM +0800, JeffleXu wrote: > It is a giant progress to gather all split bios that need to be polled > in a per-task queue. Still some comments below. > > > On 3/16/21 11:15 AM, Ming Lei wrote: > > Currently bio based IO poll needs to poll all hw queue blindly, this

Re: [dm-devel] [PATCH v7 2/3] block: add bdev_interposer

2021-03-16 Thread Ming Lei
On Fri, Mar 12, 2021 at 06:44:54PM +0300, Sergei Shtepa wrote: > bdev_interposer allows to redirect bio requests to another devices. > > Signed-off-by: Sergei Shtepa > --- > block/bio.c | 2 ++ > block/blk-core.c | 57 +++ > block/genhd

Re: [dm-devel] [PATCH] multipathd: avoid crash in uevent_cleanup()

2021-03-16 Thread lixiaokeng
>> >> Can you confirm that that commit fixes your issue? > > Any updates on this? > Hi Martin I'm sorry for missing this. 38ffd89 ("libmultipath: prevent DSO unloading with astray checker threads") fixes my issue. Regards Lixiaokeng -- dm-devel mailing list dm-devel@redhat.com https://li

Re: [dm-devel] [PATCH v2] dm table: Fix zoned model check and zone sectors check

2021-03-16 Thread Mike Snitzer
On Tue, Mar 16 2021 at 2:14am -0400, Damien Le Moal wrote: > On 2021/03/16 13:36, Shin'ichiro Kawasaki wrote: > > Commit 24f6b6036c9e ("dm table: fix zoned iterate_devices based device > > capability checks") triggered dm table load failure when dm-zoned device > > is set up for zoned block devi

Re: [dm-devel] [PATCH v7 3/3] dm: add DM_INTERPOSED_FLAG

2021-03-16 Thread Christoph Hellwig
On Tue, Mar 16, 2021 at 03:23:14PM +, Christoph Hellwig wrote: > On Mon, Mar 15, 2021 at 04:25:09PM +0300, Sergei Shtepa wrote: > > The 03/14/2021 12:30, Christoph Hellwig wrote: > > > On Fri, Mar 12, 2021 at 06:44:55PM +0300, Sergei Shtepa wrote: > > > > DM_INTERPOSED_FLAG allow to create DM t

Re: [dm-devel] [PATCH v7 3/3] dm: add DM_INTERPOSED_FLAG

2021-03-16 Thread Christoph Hellwig
On Mon, Mar 15, 2021 at 04:25:09PM +0300, Sergei Shtepa wrote: > The 03/14/2021 12:30, Christoph Hellwig wrote: > > On Fri, Mar 12, 2021 at 06:44:55PM +0300, Sergei Shtepa wrote: > > > DM_INTERPOSED_FLAG allow to create DM targets on "the fly". > > > Underlying block device opens without a flag FMO

Re: [dm-devel] [RFC PATCH 08/11] block: use per-task poll context to implement bio based io poll

2021-03-16 Thread JeffleXu
On 3/16/21 3:17 PM, Ming Lei wrote: > On Tue, Mar 16, 2021 at 02:46:08PM +0800, JeffleXu wrote: >> It is a giant progress to gather all split bios that need to be polled >> in a per-task queue. Still some comments below. >> >> >> On 3/16/21 11:15 AM, Ming Lei wrote: >>> Currently bio based IO po

Re: [dm-devel] [RFC PATCH 08/11] block: use per-task poll context to implement bio based io poll

2021-03-16 Thread JeffleXu
On 3/16/21 3:17 PM, Ming Lei wrote: > On Tue, Mar 16, 2021 at 02:46:08PM +0800, JeffleXu wrote: >> It is a giant progress to gather all split bios that need to be polled >> in a per-task queue. Still some comments below. >> >> >> On 3/16/21 11:15 AM, Ming Lei wrote: >>> Currently bio based IO po

Re: [dm-devel] [PATCH v7 3/3] dm: add DM_INTERPOSED_FLAG

2021-03-16 Thread Sergei Shtepa
Thanks! I've already started doing something like that. I'm glad we're thinking in the same direction. -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH v7 2/3] block: add bdev_interposer

2021-03-16 Thread Sergei Shtepa
The 03/16/2021 11:09, Ming Lei wrote: > On Fri, Mar 12, 2021 at 06:44:54PM +0300, Sergei Shtepa wrote: > > bdev_interposer allows to redirect bio requests to another devices. > > > > Signed-off-by: Sergei Shtepa > > --- > > block/bio.c | 2 ++ > > block/blk-core.c | 57 ++

Re: [dm-devel] [PATCH v2] dm table: Fix zoned model check and zone sectors check

2021-03-16 Thread Damien Le Moal
On 2021/03/16 22:47, Mike Snitzer wrote: > On Tue, Mar 16 2021 at 2:14am -0400, > Damien Le Moal wrote: > >> On 2021/03/16 13:36, Shin'ichiro Kawasaki wrote: >>> Commit 24f6b6036c9e ("dm table: fix zoned iterate_devices based device >>> capability checks") triggered dm table load failure when dm

Re: [dm-devel] [RFC PATCH 08/11] block: use per-task poll context to implement bio based io poll

2021-03-16 Thread Ming Lei
On Tue, Mar 16, 2021 at 04:52:36PM +0800, JeffleXu wrote: > > > On 3/16/21 3:17 PM, Ming Lei wrote: > > On Tue, Mar 16, 2021 at 02:46:08PM +0800, JeffleXu wrote: > >> It is a giant progress to gather all split bios that need to be polled > >> in a per-task queue. Still some comments below. > >> >

Re: [dm-devel] [PATCH v7 2/3] block: add bdev_interposer

2021-03-16 Thread Ming Lei
On Tue, Mar 16, 2021 at 07:35:44PM +0300, Sergei Shtepa wrote: > The 03/16/2021 11:09, Ming Lei wrote: > > On Fri, Mar 12, 2021 at 06:44:54PM +0300, Sergei Shtepa wrote: > > > bdev_interposer allows to redirect bio requests to another devices. > > > > > > Signed-off-by: Sergei Shtepa > > > --- >

Re: [dm-devel] [RFC PATCH 08/11] block: use per-task poll context to implement bio based io poll

2021-03-16 Thread Ming Lei
On Tue, Mar 16, 2021 at 07:00:49PM +0800, JeffleXu wrote: > > > On 3/16/21 3:17 PM, Ming Lei wrote: > > On Tue, Mar 16, 2021 at 02:46:08PM +0800, JeffleXu wrote: > >> It is a giant progress to gather all split bios that need to be polled > >> in a per-task queue. Still some comments below. > >> >

Re: [dm-devel] [RFC PATCH 08/11] block: use per-task poll context to implement bio based io poll

2021-03-16 Thread Ming Lei
On Wed, Mar 17, 2021 at 11:53:12AM +0800, JeffleXu wrote: > > > On 3/17/21 10:54 AM, Ming Lei wrote: > > On Tue, Mar 16, 2021 at 04:52:36PM +0800, JeffleXu wrote: > >> > >> > >> On 3/16/21 3:17 PM, Ming Lei wrote: > >>> On Tue, Mar 16, 2021 at 02:46:08PM +0800, JeffleXu wrote: > It is a gian