[dm-devel] [PATCH] dm: unexport dm_{get,put}_table_device

2021-03-17 Thread Christoph Hellwig
These are only used inside the main dm module. Signed-off-by: Christoph Hellwig --- drivers/md/dm.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/md/dm.c b/drivers/md/dm.c index 50b693d776d603..f81bfacfd80de3 100644 --- a/drivers/md/dm.c +++ b/drivers/md/dm.c @@ -840,7 +840,6 @@ i

Re: [dm-devel] [PATCH 2/2] 11-dm-mpath.rules: run "multipath -U" with -v1

2021-03-17 Thread Benjamin Marzinski
On Wed, Mar 17, 2021 at 06:27:27PM +0100, mwi...@suse.com wrote: > From: Martin Wilck > > In cases where some path devices are temporarily unavailable (e.g. failover), > high amounts of error messages such as these are seen: > > Feb 27 08:02:03 ictm1608s02h1 multipath[1420]: get_udev_device: fai

Re: [dm-devel] [PATCH 1/2] libmultipath: merge update_multipath_table() and update_multipath_status()

2021-03-17 Thread Benjamin Marzinski
On Wed, Mar 17, 2021 at 06:27:26PM +0100, mwi...@suse.com wrote: > From: Martin Wilck > > Since 378cb66 ("multipath: use update_pathvec_from_dm()"), > we remove paths and even pathgroups from multipathd's data structures > in update_multipath_table() if these paths are found to be non-existent. >

[dm-devel] ALUA state unavailable and device discovery

2021-03-17 Thread Brian Bunker
Hello All, There seems to be an incompatibility in the Linux SCSI code between SCSI disk discovery and the ALUA state unavailable. From the SPC specification if you use ALUA state unavailable you also set the peripheral qualifier for that path. While in the unavailable primary target port asymmet

Re: [dm-devel] [PATCH v7 2/3] block: add bdev_interposer

2021-03-17 Thread Sergei Shtepa
The 03/17/2021 18:04, Mike Snitzer wrote: > On Wed, Mar 17 2021 at 8:22am -0400, > Sergei Shtepa wrote: > > > The 03/17/2021 06:03, Ming Lei wrote: > > > On Tue, Mar 16, 2021 at 07:35:44PM +0300, Sergei Shtepa wrote: > > > > The 03/16/2021 11:09, Ming Lei wrote: > > > > > On Fri, Mar 12, 2021 at

[dm-devel] [PATCH 1/2] libmultipath: merge update_multipath_table() and update_multipath_status()

2021-03-17 Thread mwilck
From: Martin Wilck Since 378cb66 ("multipath: use update_pathvec_from_dm()"), we remove paths and even pathgroups from multipathd's data structures in update_multipath_table() if these paths are found to be non-existent. But update_multipath_status() is called afterwards, and it uses the kernel's

[dm-devel] [PATCH 2/2] 11-dm-mpath.rules: run "multipath -U" with -v1

2021-03-17 Thread mwilck
From: Martin Wilck In cases where some path devices are temporarily unavailable (e.g. failover), high amounts of error messages such as these are seen: Feb 27 08:02:03 ictm1608s02h1 multipath[1420]: get_udev_device: failed to look up 65:224 with type 1 Feb 27 08:02:03 ictm1608s02h1 multipath[14

Re: [dm-devel] [PATCH] multipathd: avoid crash in uevent_cleanup()

2021-03-17 Thread Martin Wilck
Hello Lixiaokeng, > Hi Martin > >   I'm sorry for missing this. 38ffd89 ("libmultipath: prevent > DSO unloading with astray checker threads") fixes my issue. Thanks! Am I right assuming that you did _not_ use my prior patch "multipathd: avoid crash in uevent_cleanup()" (which would mean that we

Re: [dm-devel] [PATCH v7 2/3] block: add bdev_interposer

2021-03-17 Thread Mike Snitzer
On Wed, Mar 17 2021 at 2:14pm -0400, Sergei Shtepa wrote: > The 03/17/2021 18:04, Mike Snitzer wrote: > > On Wed, Mar 17 2021 at 8:22am -0400, > > Sergei Shtepa wrote: > > > > > The 03/17/2021 06:03, Ming Lei wrote: > > > > On Tue, Mar 16, 2021 at 07:35:44PM +0300, Sergei Shtepa wrote: > > >

Re: [dm-devel] [PATCH v7 2/3] block: add bdev_interposer

2021-03-17 Thread Sergei Shtepa
The 03/17/2021 06:03, Ming Lei wrote: > On Tue, Mar 16, 2021 at 07:35:44PM +0300, Sergei Shtepa wrote: > > The 03/16/2021 11:09, Ming Lei wrote: > > > On Fri, Mar 12, 2021 at 06:44:54PM +0300, Sergei Shtepa wrote: > > > > bdev_interposer allows to redirect bio requests to another devices. > > > >

Re: [dm-devel] [PATCH] block: remove the "detected capacity change" message

2021-03-17 Thread Mikulas Patocka
On Wed, 17 Mar 2021, Christoph Hellwig wrote: > No, it is everything but useless. It is not needed during device > creation, but that is something that the GENHD_FL_UP check should catch. > > You should probably audit the device mapper code why it sets the initial > capacity when the gendisk

Re: [dm-devel] [PATCH v7 2/3] block: add bdev_interposer

2021-03-17 Thread Mike Snitzer
On Wed, Mar 17 2021 at 8:22am -0400, Sergei Shtepa wrote: > The 03/17/2021 06:03, Ming Lei wrote: > > On Tue, Mar 16, 2021 at 07:35:44PM +0300, Sergei Shtepa wrote: > > > The 03/16/2021 11:09, Ming Lei wrote: > > > > On Fri, Mar 12, 2021 at 06:44:54PM +0300, Sergei Shtepa wrote: > > > > > bdev_i

Re: [dm-devel] [PATCH v7 2/3] block: add bdev_interposer

2021-03-17 Thread Mike Snitzer
On Tue, Mar 16 2021 at 11:03pm -0400, Ming Lei wrote: > On Tue, Mar 16, 2021 at 07:35:44PM +0300, Sergei Shtepa wrote: > > The 03/16/2021 11:09, Ming Lei wrote: > > > On Fri, Mar 12, 2021 at 06:44:54PM +0300, Sergei Shtepa wrote: > > > > bdev_interposer allows to redirect bio requests to another

Re: [dm-devel] [PATCH] block: remove the "detected capacity change" message

2021-03-17 Thread Christoph Hellwig
No, it is everything but useless. It is not needed during device creation, but that is something that the GENHD_FL_UP check should catch. You should probably audit the device mapper code why it sets the initial capacity when the gendisk is up already, as that can cause all kinds of problems. If

[dm-devel] [PATCH] block: remove the "detected capacity change" message

2021-03-17 Thread Mikulas Patocka
Every time a new device mapper device is created, a message "detected capacity change from 0 to 2097152" is reported. This message is useless, so this patch removes it. Signed-off-by: Mikulas Patocka --- block/genhd.c |3 --- 1 file changed, 3 deletions(-) Index: linux-2.6/block/genhd.c ==

Re: [dm-devel] [RFC PATCH 08/11] block: use per-task poll context to implement bio based io poll

2021-03-17 Thread Ming Lei
On Wed, Mar 17, 2021 at 11:49:00AM +0800, JeffleXu wrote: > > > On 3/16/21 7:00 PM, JeffleXu wrote: > > > > > > On 3/16/21 3:17 PM, Ming Lei wrote: > >> On Tue, Mar 16, 2021 at 02:46:08PM +0800, JeffleXu wrote: > >>> It is a giant progress to gather all split bios that need to be polled > >>> i