[dm-devel] [PATCH] multipath-tools: use same format for default values in multipath.conf.5

2021-03-19 Thread Xose Vazquez Perez
For max_sectors_kb, replace "device dependent" with its sysfs path. And use as wildcard for device in paths. Cc: Martin Wilck Cc: Benjamin Marzinski Cc: Christophe Varoqui Cc: DM-DEVEL ML --- multipath/multipath.conf.5 | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[dm-devel] [PATCH] Revert "multipath -U: reduce log level of "adding new path" message"

2021-03-19 Thread mwilck
From: Martin Wilck After "11-dm-mpath.rules: run "multipath -U" with -v1", this patch isn't necessary any more. It's desirable to see these messages from multipathd, as they mean that a valid path had been found in a map that wasn't present in the udev db. Signed-off-by: Martin Wilck --- If

Re: [dm-devel] [PATCH] multipath-tools: fix format in multipath.conf.5 to be consistent

2021-03-19 Thread Martin Wilck
On Fri, 2021-03-19 at 17:18 +0100, Xose Vazquez Perez wrote: > Cc: Martin Wilck > Cc: Benjamin Marzinski > Cc: Christophe Varoqui > Cc: DM-DEVEL ML > Signed-off-by: Xose Vazquez Perez Reviewed-by: Martin Wilck -- dm-devel mailing list dm-devel@redhat.com

Re: [dm-devel] [RFC PATCH V2 00/13] block: support bio based io polling

2021-03-19 Thread Mike Snitzer
On Thu, Mar 18 2021 at 12:48pm -0400, Ming Lei wrote: > Hi, > > Add per-task io poll context for holding HIPRI blk-mq/underlying bios > queued from bio based driver's io submission context, and reuse one bio > padding field for storing 'cookie' returned from submit_bio() for these > bios. Also

Re: [dm-devel] [RFC PATCH V2 09/13] block: use per-task poll context to implement bio based io poll

2021-03-19 Thread Mike Snitzer
On Thu, Mar 18 2021 at 12:48pm -0400, Ming Lei wrote: > Currently bio based IO poll needs to poll all hw queue blindly, this way > is very inefficient, and the big reason is that we can't pass bio > submission result to io poll task. This is awkward because bio-based IO polling doesn't exist

Re: [dm-devel] [RFC PATCH V2 06/13] block: add new field into 'struct bvec_iter'

2021-03-19 Thread Mike Snitzer
On Thu, Mar 18 2021 at 12:48pm -0400, Ming Lei wrote: > There is a hole at the end of 'struct bvec_iter', so put a new field > here and we can save cookie returned from submit_bio() here for > supporting bio based polling. > > This way can avoid to extend bio unnecessarily. > > Signed-off-by:

Re: [dm-devel] [RFC PATCH V2 05/13] block: add req flag of REQ_TAG

2021-03-19 Thread Mike Snitzer
On Thu, Mar 18 2021 at 12:48pm -0400, Ming Lei wrote: > Add one req flag REQ_TAG which will be used in the following patch for > supporting bio based IO polling. "REQ_TAG" is so generic yet is used in such a specific way (to mark an FS bio as having polling context) I don't have a great

Re: [dm-devel] [RFC PATCH V2 04/13] block: create io poll context for submission and poll task

2021-03-19 Thread Mike Snitzer
On Thu, Mar 18 2021 at 12:48pm -0400, Ming Lei wrote: > Create per-task io poll context for both IO submission and poll task > if the queue is bio based and supports polling. > > This io polling context includes two queues: 1) submission queue(sq) for storing HIPRI bio submission result(cookie)

Re: [dm-devel] [RFC PATCH V2 01/13] block: add helper of blk_queue_poll

2021-03-19 Thread Mike Snitzer
On Thu, Mar 18 2021 at 12:48pm -0400, Ming Lei wrote: > There has been 3 users, and will be more, so add one such helper. > > Signed-off-by: Ming Lei Not sure if you're collecting Reviewed-by or Acked-by at this point? Seems you dropped Chaitanya's Reviewed-by to v1:

[dm-devel] [PATCH] multipath-tools: fix format in multipath.conf.5 to be consistent

2021-03-19 Thread Xose Vazquez Perez
Cc: Martin Wilck Cc: Benjamin Marzinski Cc: Christophe Varoqui Cc: DM-DEVEL ML Signed-off-by: Xose Vazquez Perez --- multipath/multipath.conf.5 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/multipath/multipath.conf.5 b/multipath/multipath.conf.5 index 73977b97..2aa0f526

Re: [dm-devel] [RFC PATCH V2 09/13] block: use per-task poll context to implement bio based io poll

2021-03-19 Thread Ming Lei
On Fri, Mar 19, 2021 at 05:38:38PM +0800, JeffleXu wrote: > I'm thinking how this mechanism could work with *original* bio-based > devices that don't ne built upon mq devices, such as nvdimm. This non-mq device needs driver to implement io polling by itself, block layer can't help it, and that

[dm-devel] [PATCH] dm thin: remove needless request_queue NULL pointer check

2021-03-19 Thread Xu Wang
Since commit ff9ea323816d ("block, bdi: an active gendisk always has a request_queue associated with it") the request_queue pointer returned from bdev_get_queue() shall never be NULL. Signed-off-by: Xu Wang --- drivers/md/dm-thin.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[dm-devel] [PATCH] dm cache: remove needless request_queue NULL pointer checks

2021-03-19 Thread Xu Wang
Since commit ff9ea323816d ("block, bdi: an active gendisk always has a request_queue associated with it") the request_queue pointer returned from bdev_get_queue() shall never be NULL. Signed-off-by: Xu Wang --- drivers/md/dm-cache-target.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[dm-devel] [PATCH] dm persistent data: Remove unused variable ret

2021-03-19 Thread Jiapeng Chong
Fix the following coccicheck warnings: ./drivers/md/persistent-data/dm-btree-spine.c:188:5-6: Unneeded variable: "r". Return "0" on line 194. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- drivers/md/persistent-data/dm-btree-internal.h | 2 +-

Re: [dm-devel] [RFC PATCH V2 00/13] block: support bio based io polling

2021-03-19 Thread JeffleXu
On 3/19/21 12:48 AM, Ming Lei wrote: > Hi, > > Add per-task io poll context for holding HIPRI blk-mq/underlying bios > queued from bio based driver's io submission context, and reuse one bio > padding field for storing 'cookie' returned from submit_bio() for these > bios. Also explicitly end

Re: [dm-devel] [RFC PATCH V2 05/13] block: add req flag of REQ_TAG

2021-03-19 Thread JeffleXu
On 3/19/21 12:48 AM, Ming Lei wrote: > Add one req flag REQ_TAG which will be used in the following patch for > supporting bio based IO polling. > > Exactly this flag can help us to do: > > 1) request flag is cloned in bio_fast_clone(), so if we mark one FS bio > as REQ_TAG, all bios cloned

Re: [dm-devel] [PATCH v3 01/11] pagemap: Introduce ->memory_failure()

2021-03-19 Thread ruansy.f...@fujitsu.com
> -Original Message- > From: ruansy.f...@fujitsu.com > Subject: RE: [PATCH v3 01/11] pagemap: Introduce ->memory_failure() > > > > > > > > > > > > After the conversation with Dave I don't see the point of this. > > > > > > If there is a memory_failure() on a page, why not just call > >

[dm-devel] [PATCH] dm: ebs: Several typo fixes

2021-03-19 Thread Bhaskar Chowdhury
s/retrievd/retrieved/ s/misalignement/misalignment/ s/funtion/function/ Signed-off-by: Bhaskar Chowdhury --- drivers/md/dm-ebs-target.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/md/dm-ebs-target.c b/drivers/md/dm-ebs-target.c index

Re: [dm-devel] [RFC PATCH V2 05/13] block: add req flag of REQ_TAG

2021-03-19 Thread Ming Lei
On Fri, Mar 19, 2021 at 03:59:06PM +0800, JeffleXu wrote: > > > On 3/19/21 12:48 AM, Ming Lei wrote: > > Add one req flag REQ_TAG which will be used in the following patch for > > supporting bio based IO polling. > > > > Exactly this flag can help us to do: > > > > 1) request flag is cloned in