Re: [dm-devel] [PATCH 4/8] block: support delayed holder registration

2021-07-27 Thread Christoph Hellwig
On Tue, Jul 27, 2021 at 12:06:04PM -0400, Mike Snitzer wrote: > This header starts to shine some light on what is motivating this > series by touching on "all kinds of bad side effects" being fixed. > Any chance you could elaborate what you've noticed/found/hit? The proble mis that it leaves the q

Re: [dm-devel] [PATCH 0/7] device mapper target measurements using IMA

2021-07-27 Thread Tushar Sugandhi
Hi Thore, On 7/27/21 1:33 PM, Alasdair G Kergon wrote: Creating a dm-verity device with mount then removing it and now if you create it again no measurement is generated. Is that the expected behavior? Each of the relevant dm ioctls should be logged separately each time. If that's not happenin

Re: [dm-devel] switch the block layer to use kmap_local_page v3

2021-07-27 Thread Jens Axboe
On 7/26/21 11:56 PM, Christoph Hellwig wrote: > Hi all, > > this series switches the core block layer code and all users of the > existing bvec kmap helpers to use kmap_local_page. Drivers that > currently use open coded kmap_atomic calls will converted in a follow > on series. > > To do so a ne

Re: [dm-devel] use regular gendisk registration in device mapper

2021-07-27 Thread Mike Snitzer
On Tue, Jul 27 2021 at 12:18P -0400, Mike Snitzer wrote: > On Tue, Jul 27 2021 at 12:02P -0400, > Christoph Hellwig wrote: > > > On Tue, Jul 27, 2021 at 11:58:46AM -0400, Mike Snitzer wrote: > > > > This did not make a different to my testing > > > > using dmsetup and the lvm2 tools. > > > > >

Re: [dm-devel] use regular gendisk registration in device mapper

2021-07-27 Thread Milan Broz
On 27/07/2021 18:18, Mike Snitzer wrote: > On Tue, Jul 27 2021 at 12:02P -0400, > Christoph Hellwig wrote: > >> On Tue, Jul 27, 2021 at 11:58:46AM -0400, Mike Snitzer wrote: This did not make a different to my testing using dmsetup and the lvm2 tools. >>> >>> I'll try these changes runn

Re: [dm-devel] [PATCH 0/7] device mapper target measurements using IMA

2021-07-27 Thread Alasdair G Kergon
On Tue, Jul 27, 2021 at 12:18:02PM +0200, Thore Sommer wrote: > No new IMA measurement is generated if dm-verity verification fails. This is > unfortunate because to make the dm-verity measurements useful we need to be > notified when hash_failed is set to true. We will need something like > "devic

Re: [dm-devel] use regular gendisk registration in device mapper

2021-07-27 Thread Mike Snitzer
On Tue, Jul 27 2021 at 12:02P -0400, Christoph Hellwig wrote: > On Tue, Jul 27, 2021 at 11:58:46AM -0400, Mike Snitzer wrote: > > > This did not make a different to my testing > > > using dmsetup and the lvm2 tools. > > > > I'll try these changes running through the lvm2 testsuite. > > Btw, is

Re: [dm-devel] [PATCH 4/8] block: support delayed holder registration

2021-07-27 Thread Mike Snitzer
On Sun, Jul 25 2021 at 1:54P -0400, Christoph Hellwig wrote: > device mapper needs to register holders before it is ready to do I/O. > Currently it does so by registering the disk early, which has all kinds > of bad side effects. Support registering holders on an initialized but > not registere

Re: [dm-devel] use regular gendisk registration in device mapper

2021-07-27 Thread Christoph Hellwig
On Tue, Jul 27, 2021 at 11:58:46AM -0400, Mike Snitzer wrote: > > This did not make a different to my testing > > using dmsetup and the lvm2 tools. > > I'll try these changes running through the lvm2 testsuite. Btw, is ther documentation on how to run it somewhere? I noticed tests, old-tests and

Re: [dm-devel] use regular gendisk registration in device mapper

2021-07-27 Thread Mike Snitzer
On Sun, Jul 25 2021 at 1:54P -0400, Christoph Hellwig wrote: > Hi all, > > The device mapper code currently has a somewhat odd gendisk registration > scheme where it calls add_disk early, but uses a special flag to skip the > "queue registration", which is a major part of add_disk. This series

[dm-devel] [PATCH] dm-writecache: crash on invalid returned status

2021-07-27 Thread Mikulas Patocka
If some "writecache_map_*" function returns invalid status, it is a bug. So, we should report it and not fail silently. Signed-off-by: Mikulas Patocka --- drivers/md/dm-writecache.c |5 - 1 file changed, 4 insertions(+), 1 deletion(-) Index: linux-2.6/drivers/md/dm-writecache.c ===

[dm-devel] [PATCH] dm-writecache: add event counters

2021-07-27 Thread Mikulas Patocka
This patch adds 10 counters for various events and exports them in the status line. It also adds a message "clear_stats" that resets the counters. Signed-off-by: Mikulas Patocka --- Documentation/admin-guide/device-mapper/writecache.rst | 16 drivers/md/dm-writecache.c

Re: [dm-devel] [PATCH 0/7] device mapper target measurements using IMA

2021-07-27 Thread Thore Sommer
Hello Tushar, I've now tested your patches more in depth. I've used the latest changes from the dm-5.15 branch. Here are some things that I noticed during testing with dm-verity. I'm relative new to IMA and device mapper, so there are also some more general questions. No new IMA measurement is ge