On 7/20/21 8:53 PM, Guoqing Jiang wrote:
> From: Guoqing Jiang
>
> Move them (PAGE_SECTORS_SHIFT, PAGE_SECTORS and SECTOR_MASK) to the
> generic header file to remove redundancy.
Applied for 5.15, thanks.
--
Jens Axboe
--
dm-devel mailing list
dm-devel@redhat.com
Gentle ping ...
On 7/21/21 10:53 AM, Guoqing Jiang wrote:
From: Guoqing Jiang
Move them (PAGE_SECTORS_SHIFT, PAGE_SECTORS and SECTOR_MASK) to the
generic header file to remove redundancy.
Signed-off-by: Guoqing Jiang
---
drivers/block/brd.c | 3 ---
From: Martin Wilck
Add an API for string buffers that grow in size as text is added.
This API will be useful in several places of the multipath-tools code
base. Add unit tests for these helpers, too.
Signed-off-by: Martin Wilck
---
libmultipath/Makefile | 2 +-
libmultipath/strbuf.c | 207
From: Martin Wilck
Move all macros to print.c that aren't used in other source files.
Reviewed-by: Benjamin Marzinski
Signed-off-by: Martin Wilck
---
libmultipath/print.c | 66 +
libmultipath/print.h | 70 +---
2
From: Martin Wilck
A failure in find_keyword() means an internal error. Fail hard rather
than returning an empty string.
Reviewed-by: Benjamin Marzinski
Signed-off-by: Martin Wilck
---
libmultipath/print.c | 101 +++
1 file changed, 35 insertions(+),
From: Martin Wilck
Use the strbuf API in print.c, wherever growing string buffers are
appropriate. This requires a large amount of changes in print.c itself,
and in other files that use functions from print.c. It makes no sense
to separate this into smaller patches though, as the various
From: Martin Wilck
We've seen a crash of multipath in disassemble_map because of a params
string exceeding PARAMS_SIZE. While the crash could have been fixed by
a simple error check, I believe multipath should be able to work with
arbitrary long parameter strings passed from the kernel.
The
From: Martin Wilck
We can avoid some buffer length checks here, too. Also, simplify the
implementation of format_devname().
Created a wrapper for the format_devname() test case, to avoid chaning
the test cases themselves.
Reviewed-by: Benjamin Marzinski
Signed-off-by: Martin Wilck
---
From: Martin Wilck
Here, too, strbuf can be used to simplify code.
Reviewed-by: Benjamin Marzinski
Signed-off-by: Martin Wilck
---
multipathd/cli.c | 94 ++--
1 file changed, 34 insertions(+), 60 deletions(-)
diff --git a/multipathd/cli.c
From: Martin Wilck
Current libmultipath contains a lot of code writing text to pre-allocated
string buffers of fixed size while trying to avoid buffer overflows
or truncation of the output string. This code is, at least in part,
hard to verify and hard to read, as buffer sizes and positions need
From: Martin Wilck
Temporary solution for snprint_keyword(), as print.c hasn't been migrated yet.
Signed-off-by: Martin Wilck
---
libmultipath/dict.c| 314 ++---
libmultipath/dict.h| 19 +--
libmultipath/parser.c | 47 +++---
From: Martin Wilck
Instead of using fixed PARAMS_SIZE-sized arrays for parameters, use
dynamically allocated memory.
The library version needs to be bumped, because setup_map() argument
list has changed.
Signed-off-by: Martin Wilck
---
libmultipath/configure.c | 18 ++--
On Mi, 2021-07-28 at 14:03 -0500, Benjamin Marzinski wrote:
> On Thu, Jul 15, 2021 at 12:52:18PM +0200, mwi...@suse.com wrote:
> > From: Martin Wilck
> >
> > Temporary solution for snprint_keyword(), as print.c hasn't been
> > migrated yet.
>
> Mostly good. I have some minor issues with this.
>
On Mo, 2021-07-26 at 23:54 -0500, Benjamin Marzinski wrote:
> On Thu, Jul 15, 2021 at 12:52:16PM +0200, mwi...@suse.com wrote:
> > From: Martin Wilck
> >
> > Add an API for string buffers that grow in size as text is added.
> > This API will be useful in several places of the multipath-tools
> >
On Mo, 2021-07-26 at 17:17 -0500, Benjamin Marzinski wrote:
> On Thu, Jul 15, 2021 at 12:52:15PM +0200, mwi...@suse.com wrote:
> > From: Martin Wilck
> >
> > -int dm_get_status(const char *name, char *outstatus)
> > +int dm_get_status(const char *name, char **outstatus)
> > {
> > int r
On 8/11/21 8:41 AM, mwi...@suse.com wrote:
Add an API for string buffers that grow in size as text is added.
This API will be useful in several places of the multipath-tools code
base. Add unit tests for these helpers, too.
Has it been considered to switch to C++ and use std::string and/or
There is an error when complie with glibc-2.34:
comparison of integer expressions of different signedness:
'size_t' {aka 'long unsigned int'} and 'long int'
[-Werror=sign-compare]
The reason is that PTHREAD_STACK_MIN may be defined
long int which is signed in glibc-2.34+. Explicitly assign
it to
Hi,
On 04.08.2021 11:41, Christoph Hellwig wrote:
> device mapper needs to register holders before it is ready to do I/O.
> Currently it does so by registering the disk early, which can leave
> the disk and queue in a weird half state where the queue is registered
> with the disk, except for
18 matches
Mail list logo
