Re: [dm-devel] [PATCH 4/8] block: support delayed holder registration

2021-08-20 Thread Guenter Roeck
On 8/20/21 8:08 AM, Christoph Hellwig wrote: Please try the patch below: --- From 7609266da56160d211662cd2fbe26570aad11b15 Mon Sep 17 00:00:00 2001 From: Christoph Hellwig Date: Fri, 20 Aug 2021 17:00:11 +0200 Subject: mtd_blkdevs: don't hold del_mtd_blktrans_dev in blktrans_{open,release}

Re: [PATCH RESEND v6 7/9] dm: Introduce ->rmap() to find bdev offset

2021-08-20 Thread Dan Williams
On Fri, Jul 30, 2021 at 3:02 AM Shiyang Ruan wrote: > > Pmem device could be a target of mapped device. In order to find out > the global location on a mapped device, we introduce this to translate > offset from target device to mapped device. > > Currently, we implement it on linear target,

Re: [PATCH RESEND v6 6/9] xfs: Implement ->notify_failure() for XFS

2021-08-20 Thread Dan Williams
On Fri, Jul 30, 2021 at 3:02 AM Shiyang Ruan wrote: > > This function is used to handle errors which may cause data lost in > filesystem. Such as memory failure in fsdax mode. > > If the rmap feature of XFS enabled, we can query it to find files and > metadata which are associated with the

Re: [PATCH RESEND v6 6/9] xfs: Implement ->notify_failure() for XFS

2021-08-20 Thread Dan Williams
On Thu, Aug 5, 2021 at 5:50 PM Jane Chu wrote: > > > On 7/30/2021 3:01 AM, Shiyang Ruan wrote: > > + mapping = VFS_I(ip)->i_mapping; > > + if (IS_ENABLED(CONFIG_MEMORY_FAILURE)) { > > + for (i = 0; i < rec->rm_blockcount; i++) { > > + error =

Re: [PATCH RESEND v6 5/9] mm: Introduce mf_dax_kill_procs() for fsdax case

2021-08-20 Thread Dan Williams
On Fri, Jul 30, 2021 at 3:02 AM Shiyang Ruan wrote: > > This function is called at the end of RMAP routine, i.e. filesystem > recovery function. The difference between mf_generic_kill_procs() is, > mf_dax_kill_procs() accepts file mapping and offset instead of struct > page. It is because that

Re: [dm-devel] [PATCH 3/7] block: copy offload support infrastructure

2021-08-20 Thread Bart Van Assche
On 8/20/21 3:39 AM, Kanchan Joshi wrote: Bart, Mikulas On Tue, Aug 17, 2021 at 10:44 PM Bart Van Assche wrote: On 8/17/21 3:14 AM, SelvaKumar S wrote: Introduce REQ_OP_COPY, a no-merge copy offload operation. Create bio with control information as payload and submit to the device. Larger

Re: [PATCH RESEND v6 4/9] pmem,mm: Implement ->memory_failure in pmem driver

2021-08-20 Thread Dan Williams
On Fri, Jul 30, 2021 at 3:02 AM Shiyang Ruan wrote: > > With dax_holder notify support, we are able to notify the memory failure > from pmem driver to upper layers. If there is something not support in > the notify routine, memory_failure will fall back to the generic hanlder. How about: "Any

Re: [dm-devel] [PATCH 0/6] updates to device mapper target measurement using ima

2021-08-20 Thread Mike Snitzer
On Fri, Aug 13 2021 at 5:37P -0400, Tushar Sugandhi wrote: > > There were several improvements suggested for the original device mapper > target measurement patch series [1]. > > Those improvement suggestions include: > - Prefixing hashes for the DM tables being measured in ima log with the

Re: [PATCH RESEND v6 2/9] dax: Introduce holder for dax_device

2021-08-20 Thread Dan Williams
On Fri, Jul 30, 2021 at 3:02 AM Shiyang Ruan wrote: > > To easily track filesystem from a pmem device, we introduce a holder for > dax_device structure, and also its operation. This holder is used to > remember who is using this dax_device: > - When it is the backend of a filesystem, the holder

Re: [PATCH RESEND v6 3/9] mm: factor helpers for memory_failure_dev_pagemap

2021-08-20 Thread Dan Williams
On Thu, Aug 5, 2021 at 6:01 PM Jane Chu wrote: > > > On 7/30/2021 3:01 AM, Shiyang Ruan wrote: > > - /* > > - * Prevent the inode from being freed while we are interrogating > > - * the address_space, typically this would be handled by > > - * lock_page(), but dax pages do not

Re: [PATCH RESEND v6 1/9] pagemap: Introduce ->memory_failure()

2021-08-20 Thread Dan Williams
On Fri, Jul 30, 2021 at 3:02 AM Shiyang Ruan wrote: > > When memory-failure occurs, we call this function which is implemented > by each kind of devices. For the fsdax case, pmem device driver > implements it. Pmem device driver will find out the filesystem in which > the corrupted page located

Re: [PATCH RESEND v6 2/9] dax: Introduce holder for dax_device

2021-08-20 Thread Dan Williams
On Fri, Jul 30, 2021 at 3:02 AM Shiyang Ruan wrote: > > To easily track filesystem from a pmem device, we introduce a holder for > dax_device structure, and also its operation. This holder is used to > remember who is using this dax_device: > - When it is the backend of a filesystem, the holder

Re: [dm-devel] [PATCH 4/8] block: support delayed holder registration

2021-08-20 Thread Christoph Hellwig
Please try the patch below: --- >From 7609266da56160d211662cd2fbe26570aad11b15 Mon Sep 17 00:00:00 2001 From: Christoph Hellwig Date: Fri, 20 Aug 2021 17:00:11 +0200 Subject: mtd_blkdevs: don't hold del_mtd_blktrans_dev in blktrans_{open,release} There is nothing that this protects against