[dm-devel] [PATCH 04/10] scsi/sr: add error handling support for add_disk()

2021-08-23 Thread Luis Chamberlain
We never checked for errors on add_disk() as this function returned void. Now that this is fixed, use the shiny new error handling. Signed-off-by: Luis Chamberlain --- drivers/scsi/sr.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/sr.c b/drivers/scsi/sr.c

[dm-devel] [PATCH 05/10] nvme: add error handling support for add_disk()

2021-08-23 Thread Luis Chamberlain
We never checked for errors on add_disk() as this function returned void. Now that this is fixed, use the shiny new error handling. Signed-off-by: Luis Chamberlain --- drivers/nvme/host/core.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/nvme/host/core.c

[dm-devel] [PATCH 09/10] loop: add error handling support for add_disk()

2021-08-23 Thread Luis Chamberlain
We never checked for errors on add_disk() as this function returned void. Now that this is fixed, use the shiny new error handling. Signed-off-by: Luis Chamberlain Signed-off-by: Christoph Hellwig --- drivers/block/loop.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff

[dm-devel] [PATCH 02/10] scsi/sd: add error handling support for add_disk()

2021-08-23 Thread Luis Chamberlain
We never checked for errors on add_disk() as this function returned void. Now that this is fixed, use the shiny new error handling. Signed-off-by: Luis Chamberlain --- drivers/scsi/sd.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/sd.c

[dm-devel] [PATCH 07/10] md: add error handling support for add_disk()

2021-08-23 Thread Luis Chamberlain
We never checked for errors on add_disk() as this function returned void. Now that this is fixed, use the shiny new error handling. We just do the unwinding of what was not done before, and are sure to unlock prior to bailing. Signed-off-by: Luis Chamberlain --- drivers/md/md.c | 7 ++- 1

[dm-devel] [PATCH 03/10] scsi/sr: use blk_cleanup_disk() instead of put_disk()

2021-08-23 Thread Luis Chamberlain
The single put_disk() is useful if you know you're not doing a cleanup after add_disk(), but since we want to add support for that, just use the normal form of blk_cleanup_disk() to cleanup the queue and put the disk. Signed-off-by: Luis Chamberlain --- drivers/scsi/sr.c | 2 +- 1 file changed,

[dm-devel] [PATCH 10/10] nbd: add error handling support for add_disk()

2021-08-23 Thread Luis Chamberlain
We never checked for errors on add_disk() as this function returned void. Now that this is fixed, use the shiny new error handling. Signed-off-by: Luis Chamberlain Signed-off-by: Christoph Hellwig --- drivers/block/nbd.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git

[dm-devel] [PATCH 06/10] mmc/core/block: add error handling support for add_disk()

2021-08-23 Thread Luis Chamberlain
We never checked for errors on add_disk() as this function returned void. Now that this is fixed, use the shiny new error handling. The caller cleanups the disk already so all we need to do is just pass along the return value. Signed-off-by: Luis Chamberlain --- drivers/mmc/core/block.c | 4

[dm-devel] [PATCH 01/10] scsi/sd: use blk_cleanup_queue() insted of put_disk()

2021-08-23 Thread Luis Chamberlain
The single put_disk() is useful if you know you're not doing a cleanup after add_disk(), but since we want to add support for that, just use the normal form of blk_cleanup_disk() to cleanup the queue and put the disk. Signed-off-by: Luis Chamberlain --- drivers/scsi/sd.c | 2 +- 1 file changed,

[dm-devel] [PATCH 00/10] block: first batch of add_disk() error handling conversions

2021-08-23 Thread Luis Chamberlain
based on Jen's for-5.15/block branch which holds all of my pending changes, in case anyone wants to take a peak. [0] https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux-next.git/log/?h=20210823-for-axboe-add-disk-error-handling-next Luis Chamberlain (10): scsi/sd: use

[dm-devel] [PATCH 08/10] dm: add add_disk() error handling

2021-08-23 Thread Luis Chamberlain
We never checked for errors on add_disk() as this function returned void. Now that this is fixed, use the shiny new error handling. Signed-off-by: Luis Chamberlain --- drivers/md/dm.c | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/drivers/md/dm.c

Re: [dm-devel] [PATCH 0/6] updates to device mapper target measurement using ima

2021-08-23 Thread Tushar Sugandhi
Hello Mike, On 8/20/21 1:19 PM, Mike Snitzer wrote: On Fri, Aug 13 2021 at 5:37P -0400, Tushar Sugandhi wrote: There were several improvements suggested for the original device mapper target measurement patch series [1]. Those improvement suggestions include: - Prefixing hashes for the

Re: [PATCH RESEND v6 1/9] pagemap: Introduce ->memory_failure()

2021-08-23 Thread h...@lst.de
On Wed, Aug 18, 2021 at 10:10:51AM -0700, Dan Williams wrote: > > Sounds like a nice solution. I think I can add an is_notify_supported() > > interface in dax_holder_ops and check it when register dax_holder. > > Shouldn't the fs avoid registering a memory failure handler if it is > not

[dm-devel] [Q] dm: Can singleton rq-based target refer to a device?

2021-08-23 Thread Kirill Tkhai
Hi, Mike, Alasdair, all, I have out-of-tree rq-based driver. It uses dm_get_device() to acquire underlining device. My goal is to register it as just DM_TARGET_SINGLETON without DM_TARGET_IMMUTABLE flag, since I need a possibility to reload it with another target. There is a check in

Re: [dm-devel] [PATCH 4/7] block: Introduce a new ioctl for simple copy

2021-08-23 Thread Nitesh Shetty
On Wed, Aug 18, 2021 at 5:06 AM Darrick J. Wong wrote: > > On Tue, Aug 17, 2021 at 03:44:20PM +0530, SelvaKumar S wrote: > > From: Nitesh Shetty > > > > Add new BLKCOPY ioctl that offloads copying of one or more sources ranges > > to a destination in the device. COPY ioctl accepts a 'copy_range'

Re: [dm-devel] [PATCH 3/7] block: copy offload support infrastructure

2021-08-23 Thread Kanchan Joshi
Bart, Mikulas On Tue, Aug 17, 2021 at 10:44 PM Bart Van Assche wrote: > > On 8/17/21 3:14 AM, SelvaKumar S wrote: > > Introduce REQ_OP_COPY, a no-merge copy offload operation. Create > > bio with control information as payload and submit to the device. > > Larger copy operation may be divided if

Re: [dm-devel] [PATCH RESEND v6 1/9] pagemap: Introduce ->memory_failure()

2021-08-23 Thread Jane Chu
On 8/19/2021 2:10 AM, ruansy.f...@fujitsu.com wrote: From: Jane Chu Subject: Re: [PATCH RESEND v6 1/9] pagemap: Introduce ->memory_failure() Sorry, correction in line. On 8/19/2021 12:18 AM, Jane Chu wrote: Hi, Shiyang, >  > > 1) What does it take and cost to make >  > >

Re: [dm-devel] [PATCH 3/7] block: copy offload support infrastructure

2021-08-23 Thread Kanchan Joshi
On Thu, Aug 19, 2021 at 12:05 AM Martin K. Petersen wrote: > > > > Native copy offload is not supported for stacked devices. > > One of the main reasons that the historic attempts at supporting copy > offload did not get merged was that the ubiquitous deployment scenario, > stacked block devices,

Re: [dm-devel] [PATCH v2 1/3] dm: introduce audit event module for device mapper

2021-08-23 Thread Weiß , Michael
On Wed, 2021-08-18 at 14:59 -0400, Paul Moore wrote: > On Sat, Aug 14, 2021 at 2:34 PM Michael Weiß > wrote: > > To be able to send auditing events to user space, we introduce > > a generic dm-audit module. It provides helper functions to emit > > audit events through the kernel audit subsystem.

Re: [dm-devel] [PATCH 0/7] add simple copy support

2021-08-23 Thread Nitesh Shetty
On Wed, Aug 18, 2021 at 5:07 AM Darrick J. Wong wrote: > > On Tue, Aug 17, 2021 at 03:44:16PM +0530, SelvaKumar S wrote: > > This started out as an attempt to support NVMe Simple Copy Command (SCC), > > and evolved during the RFC review process. > > > > The patchset, at this point, contains - > >

Re: [dm-devel] [PATCH RESEND v6 1/9] pagemap: Introduce ->memory_failure()

2021-08-23 Thread Jane Chu
Sorry, correction in line. On 8/19/2021 12:18 AM, Jane Chu wrote: Hi, Shiyang, >  > > 1) What does it take and cost to make >  > > xfs_sb_version_hasrmapbt(>m_sb) to return true? > > Enable rmpabt feature when making xfs filesystem > `mkfs.xfs -m rmapbt=1 /path/to/device` > BTW,

Re: [dm-devel] [PATCH RESEND v6 1/9] pagemap: Introduce ->memory_failure()

2021-08-23 Thread Jane Chu
Hi, Shiyang, > > > 1) What does it take and cost to make > > > xfs_sb_version_hasrmapbt(>m_sb) to return true? > > Enable rmpabt feature when making xfs filesystem > `mkfs.xfs -m rmapbt=1 /path/to/device` > BTW, reflink is enabled by default. Thanks! I tried mkfs.xfs -d