Re: [dm-devel] [PATCH v2 30/48] multipathd: uxlsnr: add idle notification

2021-11-24 Thread Benjamin Marzinski
On Thu, Nov 18, 2021 at 11:58:22PM +0100, mwi...@suse.com wrote: > From: Martin Wilck > > The previous patches added the state machine and the timeout handling, > but there was no wakeup mechanism for the uxlsnr for cases where > client connections were waiting for the vecs lock. > > This patch

Re: [dm-devel] Any bio_clone_slow() implementation which doesn't share bi_io_vec?

2021-11-24 Thread Naohiro Aota
On Wed, Nov 24, 2021 at 07:07:18AM +0800, Qu Wenruo wrote: > > > On 2021/11/23 22:28, h...@infradead.org wrote: > > On Tue, Nov 23, 2021 at 11:39:11AM +, Johannes Thumshirn wrote: > > > I think we have to differentiate two cases here: > > > A "regular" REQ_OP_ZONE_APPEND bio and a RAID stripe

Re: [dm-devel] [PATCH v2 35/48] multipathd: uxlsnr: use recv() for command length

2021-11-24 Thread Benjamin Marzinski
On Thu, Nov 18, 2021 at 11:58:27PM +0100, mwi...@suse.com wrote: > From: Martin Wilck > > If the peer uses libmpathcmd, we can be certain that the first > 8 bytes are being sent in a single chunk of data. It's overkill > to try and receive the command length byte-by-byte. > Reviewed-by: Benjamin

Re: [dm-devel] [PATCH v2 33/48] multipathd: uxlsnr: drop client_lock

2021-11-24 Thread Benjamin Marzinski
On Thu, Nov 18, 2021 at 11:58:25PM +0100, mwi...@suse.com wrote: > From: Martin Wilck > > The list of clients is never changed anywhere except in > uxsock_listen(). No need to lock. > > Signed-off-by: Martin Wilck Reviewed-by: Benjamin Marzinski > --- > multipathd/uxlsnr.c | 33 ++

Re: [dm-devel] [PATCH v2 32/48] multipathd: uxlsnr: use poll loop for sending, too

2021-11-24 Thread Benjamin Marzinski
On Thu, Nov 18, 2021 at 11:58:24PM +0100, mwi...@suse.com wrote: > From: Martin Wilck > > send_packet() may busy-loop. By polling for POLLOUT, we can > avoid that, even if it's very unlikely in practice. > The last time I reviewed this, I mentioned that when we fall through from CLT_WORK to CLT

Re: [dm-devel] [PATCH v2 31/48] multipathd: uxlsnr: add timeout handling

2021-11-24 Thread Benjamin Marzinski
On Thu, Nov 18, 2021 at 11:58:23PM +0100, mwi...@suse.com wrote: > From: Martin Wilck > > Our ppoll() call needs to wake up when a client request times out. > This logic can be added by determining the first client that's about > to time out. The logic in handle_client() will then cause a timeout

Re: [dm-devel] [PATCH v2 29/48] multipathd: uxlsnr: merge uxsock_trigger() into state machine

2021-11-24 Thread Benjamin Marzinski
On Thu, Nov 18, 2021 at 11:58:21PM +0100, mwi...@suse.com wrote: > From: Martin Wilck > > This patch sets up the bulk of the state machine. client_state_machine() > is called in a loop, proceeding from state to state until it needs > to poll for input or wait for a lock, in which case it returns

Re: [dm-devel] [PATCH v2 29/48] multipathd: uxlsnr: merge uxsock_trigger() into state machine

2021-11-24 Thread Benjamin Marzinski
On Thu, Nov 18, 2021 at 11:58:21PM +0100, mwi...@suse.com wrote: > From: Martin Wilck > > This patch sets up the bulk of the state machine. client_state_machine() > is called in a loop, proceeding from state to state until it needs > to poll for input or wait for a lock, in which case it returns

Re: [dm-devel] [PATCH v2 12/48] multipathd: add and set cli_handlers in a single step

2021-11-24 Thread Benjamin Marzinski
On Thu, Nov 18, 2021 at 11:58:04PM +0100, mwi...@suse.com wrote: > From: Martin Wilck > > Modify set_handler_callback() such that a missing slot is created > if no matching slot is found. This way, we can skip the initialization > with NULL handlers on startup. Assigning the same handler multiple

Re: [dm-devel] [PATCH v2 07/48] multipathd: improve delayed reconfigure

2021-11-24 Thread Benjamin Marzinski
On Thu, Nov 18, 2021 at 11:57:59PM +0100, mwi...@suse.com wrote: > From: Martin Wilck > > When a reconfigure operation is requested, either by the admin > or by some condition multipathd encounters, the current code > attempts to set DAEMON_CONFIGURE state and gives up after a second > if it does

Re: [dm-devel] [PATCH v2 03/48] libmultipath: add optional wakeup functionality to lock.c

2021-11-24 Thread Benjamin Marzinski
On Thu, Nov 18, 2021 at 11:57:55PM +0100, mwi...@suse.com wrote: > From: Martin Wilck > > Have struct mutex_lock take an optional wakeup function. > unlock() is renamed to __unlock() in order to prevent it from > being called by mistake. > > This changes offsets in "struct vectors", requiring a

Re: [dm-devel] [PATCH] announcing the dm-update target

2021-11-24 Thread Mikulas Patocka
On Tue, 23 Nov 2021, David Anderson wrote: > In our ecosystem, the OTA generation and on-device application process > has evolved continually, in every release, for over 10 years now. So > we think it's unlikely that we'll stop making improvements to it. Our > current roadmap has other changes