Re: [dm-devel] [PATCH 1/5] btrfs: simplify ->flush_bio handling

2022-03-01 Thread David Sterba
On Tue, Mar 01, 2022 at 10:45:48AM +0200, Christoph Hellwig wrote: > @@ -6962,16 +6961,6 @@ struct btrfs_device *btrfs_alloc_device(struct > btrfs_fs_info *fs_info, > if (!dev) > return ERR_PTR(-ENOMEM); > > - /* > - * Preallocate a bio that's always going to be used

Re: [dm-devel] Revert "dm space maps: don't reset space map allocation cursor when committing"

2022-03-01 Thread Edward Thornber
I'm having trouble understanding your issue. Does your ramdisk only allocate backing memory on demand? (ie. is the ramdisk itself a thinly provisioned device?). If so, not supporting discard seems to be the problem. Thinp makes no promises about where it will allocate your data. If you write a

Re: [dm-devel] [PATCH 2/5] squashfs: always use bio_kmalloc in squashfs_bio_read

2022-03-01 Thread Phillip Lougher
On 01/03/2022 08:45, Christoph Hellwig wrote: If a plain kmalloc that is not backed by a mempool is safe here for a large read (and the actual page allocations), it must also be for a small one, so simplify the code a bit. Signed-off-by: Christoph Hellwig Acked-by: Phillip Lougher -- dm-dev

Re: [dm-devel] [PATCH 3/5] target/pscsi: remove pscsi_get_bio

2022-03-01 Thread Martin K. Petersen
Christoph, > Remove pscsi_get_bio and simplify the code flow in the only caller. Looks good to me. Acked-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH V3 0/3] block/dm: support bio polling

2022-03-01 Thread Ming Lei
On Tue, Mar 01, 2022 at 04:19:42PM -0500, Mike Snitzer wrote: > On Mon, Feb 28 2022 at 7:58P -0500, > Ming Lei wrote: > > > On Mon, Feb 28, 2022 at 11:27:44AM -0500, Mike Snitzer wrote: > > > > > > Hey Ming, > > > > > > I'd like us to follow-through with adding bio-based polling support. > > >

Re: [dm-devel] [PATCH] kpartx: Add -P option for partition scanning

2022-03-01 Thread Ritika Srivastava
On 2/28/22, 2:44 PM, "Benjamin Marzinski" wrote: > So unless I'm missing something, we'd only really want this for removing > a kpartx device, in the case where somehow you have /dev/loopXpY > partitions without the LO_FLAGS_PARTSCAN flag set on the disk. That That's correct. We only

Re: [dm-devel] [PATCH V3 0/3] block/dm: support bio polling

2022-03-01 Thread Mike Snitzer
On Mon, Feb 28 2022 at 7:58P -0500, Ming Lei wrote: > On Mon, Feb 28, 2022 at 11:27:44AM -0500, Mike Snitzer wrote: > > > > Hey Ming, > > > > I'd like us to follow-through with adding bio-based polling support. > > Kind of strange none of us that were sent this V3 ever responded, > > sorry abo

Re: [dm-devel] [LSF/MM/BFP ATTEND] [LSF/MM/BFP TOPIC] Storage: Copy Offload

2022-03-01 Thread Nikos Tsironis
On 1/27/22 09:14, Chaitanya Kulkarni wrote: Hi, * Background :- --- Copy offload is a feature that allows file-systems or storage devices to be instructed to copy files/logical blocks without requiring involvement of the local

Re: [dm-devel] [PATCH 1/2] dm-zoned: remove the ->name field in struct dmz_dev

2022-03-01 Thread Hannes Reinecke
On 3/1/22 09:38, Christoph Hellwig wrote: Just use the %pg format specifier to print the block device name directly. Signed-off-by: Christoph Hellwig --- drivers/md/dm-zoned-metadata.c | 4 ++-- drivers/md/dm-zoned-target.c | 1 - drivers/md/dm-zoned.h | 9 - 3 files cha

[dm-devel] [PATCH 1/2] dm-zoned: remove the ->name field in struct dmz_dev

2022-03-01 Thread Christoph Hellwig
Just use the %pg format specifier to print the block device name directly. Signed-off-by: Christoph Hellwig --- drivers/md/dm-zoned-metadata.c | 4 ++-- drivers/md/dm-zoned-target.c | 1 - drivers/md/dm-zoned.h | 9 - 3 files changed, 6 insertions(+), 8 deletions(-) diff --gi

[dm-devel] [PATCH 2/2] dm: stop using bdevname

2022-03-01 Thread Christoph Hellwig
Just use the %pg format specifier instead. Signed-off-by: Christoph Hellwig --- drivers/md/dm-cache-target.c | 10 -- drivers/md/dm-clone-target.c | 10 -- drivers/md/dm-mpath.c| 6 ++ drivers/md/dm-table.c| 30 ++ drivers/md/dm-th

[dm-devel] [PATCH 2/5] squashfs: always use bio_kmalloc in squashfs_bio_read

2022-03-01 Thread Christoph Hellwig
If a plain kmalloc that is not backed by a mempool is safe here for a large read (and the actual page allocations), it must also be for a small one, so simplify the code a bit. Signed-off-by: Christoph Hellwig --- fs/squashfs/block.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions

[dm-devel] cleanup bio_kmalloc

2022-03-01 Thread Christoph Hellwig
Hi Jens, this series finishes off the bio allocation interface cleanups by dealing with the weirdest member of the famility. bio_kmalloc combines a kmalloc for the bio and bio_vecs with a hidden bio_init call and magic cleanup semantics. This series moves a few callers away from bio_kmalloc and

[dm-devel] [PATCH 4/5] block: turn bio_kmalloc into a simple kmalloc wrapper

2022-03-01 Thread Christoph Hellwig
Remove the magic autofree semantics and require the callers to explicitly call bio_init to initialize the bio. This allows bio_free to catch accidental bio_put calls on bio_init()ed bios as well. Signed-off-by: Christoph Hellwig --- block/bio.c| 47 --

[dm-devel] [PATCH 5/5] pktcdvd: stop using bio_reset

2022-03-01 Thread Christoph Hellwig
Just initialize the bios on-demand. Signed-off-by: Christoph Hellwig --- drivers/block/pktcdvd.c | 25 + 1 file changed, 9 insertions(+), 16 deletions(-) diff --git a/drivers/block/pktcdvd.c b/drivers/block/pktcdvd.c index 6aec11ed185d8..e4ee7856483cf 100644 --- a/driver

[dm-devel] [PATCH 1/5] btrfs: simplify ->flush_bio handling

2022-03-01 Thread Christoph Hellwig
Use and embedded bios that is initialized when used instead of bio_kmalloc plus bio_reset. Signed-off-by: Christoph Hellwig --- fs/btrfs/disk-io.c | 8 +--- fs/btrfs/volumes.c | 11 --- fs/btrfs/volumes.h | 2 +- 3 files changed, 6 insertions(+), 15 deletions(-) diff --git a/fs/bt

[dm-devel] [PATCH 3/5] target/pscsi: remove pscsi_get_bio

2022-03-01 Thread Christoph Hellwig
Remove pscsi_get_bio and simplify the code flow in the only caller. Signed-off-by: Christoph Hellwig --- drivers/target/target_core_pscsi.c | 28 ++-- 1 file changed, 2 insertions(+), 26 deletions(-) diff --git a/drivers/target/target_core_pscsi.c b/drivers/target/targe