Re: [dm-devel] can we reduce bio_set_dev overhead due to bio_associate_blkg?

2022-03-30 Thread Dennis Zhou
Hello, On Wed, Mar 30, 2022 at 09:39:55PM -0700, Christoph Hellwig wrote: > On Wed, Mar 30, 2022 at 08:28:28AM -0400, Dennis Zhou wrote: > > I think cloning is a special case that I might have gotten wrong. If > > there is a bio_set_dev() call after each clone(), then the > >

Re: [dm-devel] can we reduce bio_set_dev overhead due to bio_associate_blkg?

2022-03-30 Thread Christoph Hellwig
On Wed, Mar 30, 2022 at 08:28:28AM -0400, Dennis Zhou wrote: > I think cloning is a special case that I might have gotten wrong. If > there is a bio_set_dev() call after each clone(), then the > bio_clone_blkg_association() is excess work. We'd need to audit how > bio_alloc_clone() is being used

Re: [dm-devel] can we reduce bio_set_dev overhead due to bio_associate_blkg?

2022-03-30 Thread Dennis Zhou
Hi Mike, On Wed, Mar 30, 2022 at 12:52:58PM -0400, Mike Snitzer wrote: > Hey Tejun and Dennis, > > I recently found that due to bio_set_dev()'s call to > bio_associate_blkg(), bio_set_dev() needs much more cpu than ideal; > especially when doing 4K IOs via io_uring's HIPRI bio-polling. > > I'm

[dm-devel] can we reduce bio_set_dev overhead due to bio_associate_blkg?

2022-03-30 Thread Mike Snitzer
Hey Tejun and Dennis, I recently found that due to bio_set_dev()'s call to bio_associate_blkg(), bio_set_dev() needs much more cpu than ideal; especially when doing 4K IOs via io_uring's HIPRI bio-polling. I'm very naive about blk-cgroups.. so I'm hopeful you or others can help me cut through

[dm-devel] [PATCH v2] multipath: return failure on an invalid remove command

2022-03-30 Thread Benjamin Marzinski
When "multipath -f" is run on a device that doesn't exist or isn't a multipath device, the command will not remove any device, but it will still return success. Multiple functions rely on _dm_flush_map() returning success when called with name that doesn't match any multipath device. So before

[dm-devel] [PATCH RFC] multipath-tools: update "Generic NVMe" options in hwtable

2022-03-30 Thread Xose Vazquez Perez
Removed values were default. Check ANA, else fall back to CONST(multibus). Cc: Martin Wilck Cc: Benjamin Marzinski Cc: Christophe Varoqui Cc: DM-DEVEL ML Signed-off-by: Xose Vazquez Perez --- libmultipath/hwtable.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

Re: [dm-devel] (subset) [PATCH v3 0/3] block/dm: use BIOSET_PERCPU_CACHE from bio_alloc_bioset

2022-03-30 Thread Jens Axboe
On Thu, 24 Mar 2022 16:35:23 -0400, Mike Snitzer wrote: > This v3 is a rebase of the previous v2 series ontop of the revised v2 > patch that Christoph provided. > > Linus hasn't pulled the for-5.18/dm-changes branch yet, so the 3rd DM > patch cannot be applied yet. But feel free to pickup the

Re: [dm-devel] [PATCH] multipath: return failure on an invalid remove command

2022-03-30 Thread Benjamin Marzinski
On Wed, Mar 30, 2022 at 12:50:00PM +, Martin Wilck wrote: > On Tue, 2022-03-29 at 22:21 -0500, Benjamin Marzinski wrote: > > When "multipath -f" is run on a device that doesn't exist or isn't a > > multipath device, the command will not remove any device, but it will > > still return success. 

Re: [dm-devel] [PATCH] dm: fix race condition on Alpha

2022-03-30 Thread Mikulas Patocka
On Tue, 29 Mar 2022, Hannes Reinecke wrote: > On 3/28/22 18:34, Mikulas Patocka wrote: > > Early alpha processors cannot write a single byte or short; they read 8 > > bytes, modify the value in registers and write back 8 bytes. > > > > This could cause race condition in the structure dm_io -

Re: [dm-devel] [PATCH] dm-integrity: fix a BUG if we shrink the device

2022-03-30 Thread Milan Broz
On 26/03/2022 15:24, Mikulas Patocka wrote: The patch f6f72f32c22c ("dm integrity: don't replay journal data past the end of the device") skips journal replay if the target sector points beyond the end of the device. Unfortunatelly, it doesn't set the journal entry unused, which resulted in this

Re: [dm-devel] cleanup bio_kmalloc v2

2022-03-30 Thread Jens Axboe
On Tue, 8 Mar 2022 07:15:46 +0100, Christoph Hellwig wrote: > this series finishes off the bio allocation interface cleanups by dealing > with the weirdest member of the famility. bio_kmalloc combines a kmalloc > for the bio and bio_vecs with a hidden bio_init call and magic cleanup > semantics.

Re: [dm-devel] cleanup bio_kmalloc v2

2022-03-30 Thread Jens Axboe
On 3/30/22 8:29 AM, Christoph Hellwig wrote: > I just noticed this didn't make it into the 5.18 queue. Which is a > bit sad as it leaves us with a rather inconsistent bio API in 5.18. Let me take a look, we might still be able to make it... -- Jens Axboe -- dm-devel mailing list

Re: [dm-devel] [RFC PATCH] multipathd: Don't keep starting TUR threads, if they always hang.

2022-03-30 Thread Benjamin Marzinski
On Wed, Mar 30, 2022 at 09:44:39AM +, Martin Wilck wrote: > On Tue, 2022-03-29 at 22:22 -0500, Benjamin Marzinski wrote: > > If tur thead hangs, multipathd was simply creating a new thread, and > > assuming that the old thread would get cleaned up eventually. I have > > seen a case recently

Re: [dm-devel] cleanup bio_kmalloc v2

2022-03-30 Thread Christoph Hellwig
I just noticed this didn't make it into the 5.18 queue. Which is a bit sad as it leaves us with a rather inconsistent bio API in 5.18. -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH 0/4] dm: Introduce dm-qcow2 driver to attach QCOW2 files as block device

2022-03-30 Thread Kirill Tkhai
On 29.03.2022 16:08, Christoph Hellwig wrote: > On Mon, Mar 28, 2022 at 02:18:16PM +0300, Kirill Tkhai wrote: >> This patchset adds a new driver allowing to attach QCOW2 files >> as block devices. Its idea is to implement in kernel only that >> features, which affect runtime IO performance (IO

Re: [dm-devel] [PATCH 3/4] dm-qcow2: Introduce driver to create block devices over QCOW2 files

2022-03-30 Thread Kirill Tkhai
On 29.03.2022 16:34, Christoph Hellwig wrote: > On Mon, Mar 28, 2022 at 02:18:35PM +0300, Kirill Tkhai wrote: >> The driver is request based, since this allows to use blk-mq >> merging of request. Driver splits requests itself, and every >> request (i.e., qio) after splitting fits a single

Re: [dm-devel] [PATCH 3/4] dm-qcow2: Introduce driver to create block devices over QCOW2 files

2022-03-30 Thread Kirill Tkhai
On 29.03.2022 18:24, Kirill Tkhai wrote: > On 29.03.2022 16:34, Christoph Hellwig wrote: >> On Mon, Mar 28, 2022 at 02:18:35PM +0300, Kirill Tkhai wrote: >>> The driver is request based, since this allows to use blk-mq >>> merging of request. Driver splits requests itself, and every >>> request