Re: [dm-devel] [PATCH] multipath-tools: Makefile.inc: add test for -D_FORTIFY_SOURCE=3

2022-05-09 Thread Benjamin Marzinski
On Mon, May 09, 2022 at 05:21:27PM +0200, mwi...@suse.com wrote: > From: Martin Wilck Reviewed-by: Benjamin Marzinski > > 6186645 ("Fix possibility to redefine -D_FORTIFY_SOURCE macro.") > does not work as-is, because OPTFLAGS can't be used to override CPPFLAGS. > Instead, add a test for

Re: [dm-devel] dm: dm-mpath: Provide high-resolution timer to HST with bio-mpath

2022-05-09 Thread Gabriel Krisman Bertazi
Mike Snitzer writes: > Overall your code was OK, but I nudged it a bit further to be > inkeeping with how 'features' flags have been implemented elsewhere > (e.g. dm_target_type's features) -- by using a healer to test the > flag, etc. > > I also tweaked some other small implementation details.

Re: [dm-devel] dm: dm-mpath: Provide high-resolution timer to HST with bio-mpath

2022-05-09 Thread Mike Snitzer
On Mon, May 09 2022 at 3:47P -0400, Mike Snitzer wrote: > On Wed, Apr 27 2022 at 12:57P -0400, > Gabriel Krisman Bertazi wrote: > > > The precision loss of reading IO start_time with jiffies_to_nsecs > > instead of using a high resolution timer degrades HST path prediction > > for BIO-based

Re: [dm-devel] dm: dm-mpath: Provide high-resolution timer to HST with bio-mpath

2022-05-09 Thread Mike Snitzer
On Wed, Apr 27 2022 at 12:57P -0400, Gabriel Krisman Bertazi wrote: > The precision loss of reading IO start_time with jiffies_to_nsecs > instead of using a high resolution timer degrades HST path prediction > for BIO-based mpath on high load workloads. > > Below, I show the utilization

Re: [dm-devel] [PATCH v3 11/11] dm-zoned: ensure only power of 2 zone sizes are allowed

2022-05-09 Thread David Sterba
On Fri, May 06, 2022 at 10:11:05AM +0200, Pankaj Raghav wrote: > From: Luis Chamberlain > > Today dm-zoned relies on the assumption that you have a zone size > with a power of 2. Even though the block layer today enforces this > requirement, these devices do exist and so provide a stop-gap

Re: [dm-devel] [PATCH v3 11/11] dm-zoned: ensure only power of 2 zone sizes are allowed

2022-05-09 Thread Mike Snitzer
On Mon, May 09 2022 at 7:03P -0400, Pankaj Raghav wrote: > >> --- > >> drivers/md/dm-zone.c | 12 > >> 1 file changed, 12 insertions(+) > >> > >> diff --git a/drivers/md/dm-zone.c b/drivers/md/dm-zone.c > >> index 3e7b1fe15..27dc4ddf2 100644 > >> --- a/drivers/md/dm-zone.c > >>

Re: [dm-devel] [PATCH v3 10/11] null_blk: allow non power of 2 zoned devices

2022-05-09 Thread Pankaj Raghav
On 2022-05-09 13:31, Damien Le Moal wrote: diff --git a/drivers/block/null_blk/zoned.c b/drivers/block/null_blk/zoned.c index dae54dd1a..00c34e65e 100644 --- a/drivers/block/null_blk/zoned.c +++ b/drivers/block/null_blk/zoned.c @@ -13,7 +13,10 @@ static inline

Re: [dm-devel] [PATCH v3 10/11] null_blk: allow non power of 2 zoned devices

2022-05-09 Thread Pankaj Raghav
>> diff --git a/drivers/block/null_blk/main.c b/drivers/block/null_blk/main.c >> index 5cb4c92cd..ed9a58201 100644 >> --- a/drivers/block/null_blk/main.c >> +++ b/drivers/block/null_blk/main.c >> @@ -1929,9 +1929,8 @@ static int null_validate_conf(struct nullb_device *dev) >> if

Re: [dm-devel] [PATCH v3 11/11] dm-zoned: ensure only power of 2 zone sizes are allowed

2022-05-09 Thread Pankaj Raghav
>> --- >> drivers/md/dm-zone.c | 12 >> 1 file changed, 12 insertions(+) >> >> diff --git a/drivers/md/dm-zone.c b/drivers/md/dm-zone.c >> index 3e7b1fe15..27dc4ddf2 100644 >> --- a/drivers/md/dm-zone.c >> +++ b/drivers/md/dm-zone.c >> @@ -231,6 +231,18 @@ static int

Re: [dm-devel] [PATCH v3 00/11] support non power of 2 zoned devices

2022-05-09 Thread Pankaj Raghav
On 2022-05-06 12:00, David Sterba wrote: >> The current approach for npo2 devices is to place the superblock mirror >> zones near 512GB and 4TB that is **aligned to the zone size**. > > I don't like that, the offsets have been chosen so the values are fixed > and also future proof in case

Re: [dm-devel] [RFC PATCH 1/3] dm ima: allow targets to remeasure their table entry

2022-05-09 Thread Thore Sommer
Hi Lakshmi, On 06.05.22 22:25, Lakshmi Ramasubramanian wrote: Hi Thore, On 1/6/2022 12:34 PM, Thore Sommer wrote: A new DM event dm_target_update is introduced for targets to remeasure their table entry. This is intended for targets that indicate security relevant events by updating one of

Re: [dm-devel] [RFC PATCH 2/3] dm verity: add support for IMA target update event

2022-05-09 Thread Thore Sommer
Hi Lakshmi, On 06.05.22 22:35, Lakshmi Ramasubramanian wrote: Hi Thore, On 1/6/2022 12:34 PM, Thore Sommer wrote: On first corruption the verity targets triggers a dm_target_update event. This allows other systems to check using IMA if the state of the device is still trustworthy via remote

Re: [dm-devel] [RFC PATCH 0/3] dm ima: allow targets to remeasure their state

2022-05-09 Thread Thore Sommer
Hi Lakshmi, thank you for taking a closer look at this patch set. On 06.05.22 22:16, Lakshmi Ramasubramanian wrote: Hi Thore, On 1/6/2022 12:34 PM, Thore Sommer wrote: The current DM IMA events do not cover the case where a device changes their attributes to indicate a state change. It

Re: [dm-devel] [PATCH v2] dm-crypt: make printing of the key constant-time

2022-05-09 Thread Demi Marie Obenour
Nit: did you mean CC: sta...@vger.kernel.org (colon instead of semicolon)? Also, would it be better to avoid using the formatting built-in to DMEMIT()? Finally, are there any architectures for which gcc or clang make this non-constant-time? -- Sincerely, Demi Marie Obenour (she/her/hers)

Re: [dm-devel] [PATCH v2] hex2bin: make the function hex_to_bin constant-time

2022-05-09 Thread Stafford Horne
On Thu, May 05, 2022 at 05:38:58AM +0900, Stafford Horne wrote: > On Wed, May 04, 2022 at 01:10:03PM -0700, Linus Torvalds wrote: > > On Wed, May 4, 2022 at 12:58 PM Stafford Horne wrote: > > > > > > I have uploaded a diff I created here: > > >

Re: [dm-devel] [RFC PATCH 2/3] dm verity: add support for IMA target update event

2022-05-09 Thread Lakshmi Ramasubramanian
Hi Thore, On 1/6/2022 12:34 PM, Thore Sommer wrote: On first corruption the verity targets triggers a dm_target_update event. This allows other systems to check using IMA if the state of the device is still trustworthy via remote attestation. In the patch description please state the existing

Re: [dm-devel] [RFC PATCH 1/3] dm ima: allow targets to remeasure their table entry

2022-05-09 Thread Lakshmi Ramasubramanian
Hi Thore, On 1/6/2022 12:34 PM, Thore Sommer wrote: A new DM event dm_target_update is introduced for targets to remeasure their table entry. This is intended for targets that indicate security relevant events by updating one of their table entries (e.g. verity for corruption). In the patch

Re: [dm-devel] [RFC PATCH 0/3] dm ima: allow targets to remeasure their state

2022-05-09 Thread Lakshmi Ramasubramanian
Hi Thore, On 1/6/2022 12:34 PM, Thore Sommer wrote: The current DM IMA events do not cover the case where a device changes their attributes to indicate a state change. It would be good to state here what issue(s) are caused, if any, or what data\event we might be missing as a result of not

Re: [dm-devel] [PATCH 07/11] dasd: don't set the discard_alignment queue limit

2022-05-09 Thread Jan Höppner
On 18/04/2022 06:53, Christoph Hellwig wrote: > The discard_alignment queue limit is named a bit misleading means the > offset into the block device at which the discard granularity starts. > Setting it to PAGE_SIZE while the discard granularity is the block size > that is smaller or the same as