[dm-devel] [PATCH] libmultipath: fix find_multipaths_timeout for unknown hardware

2022-07-12 Thread Benjamin Marzinski
pp->hwe is now a vector that will always be allocated for all path devices. Instead of checking if it is NULL, check if it is empty. Signed-off-by: Benjamin Marzinski --- libmultipath/propsel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libmultipath/propsel.c b/libmultip

Re: [dm-devel] [PATCH 0/2] update hwtable

2022-07-12 Thread Benjamin Marzinski
On Sun, Jul 10, 2022 at 01:07:07AM +0200, Xose Vazquez Perez wrote: > Xose Vazquez Perez (2): > multipath-tools: update Huawei OceanStor NVMe vendor id > multipath-tools: update "Generic NVMe" vendor regex in hwtable For the set Reviewed-by: Benjamin Marzinski > > libmultipath/hwtable.c |

Re: [dm-devel] [PATCH 00/14] multipath: fixes for sysfs accessors

2022-07-12 Thread Benjamin Marzinski
On Wed, Jul 06, 2022 at 04:38:08PM +0200, mwi...@suse.com wrote: > From: Martin Wilck > > This set fixes some strangeness in our sysfs accessors which I > found while looking at > https://github.com/opensvc/multipath-tools/issues/35#issuecomment-1175901745. > (The patches don't fix this issue, wh

Re: [dm-devel] [PATCH 08/14] libmultipath: sysfs_attr_set_value(): don't return 0 on partial write

2022-07-12 Thread Benjamin Marzinski
On Wed, Jul 06, 2022 at 04:38:16PM +0200, mwi...@suse.com wrote: > From: Martin Wilck > > sysfs_attr_set_value() returned 0 if not all requested bytes were written. > Change this to return the number of bytes written. Error checking is now > somewhat more involved; provide a helper macro fo it. >

Re: [dm-devel] [PATCH 05/14] libmultipath: sanitize error checking in sysfs accessors

2022-07-12 Thread Benjamin Marzinski
On Wed, Jul 06, 2022 at 04:38:13PM +0200, mwi...@suse.com wrote: > From: Martin Wilck > > udev_device_get_syspath() may return NULL; check for it, and check > for pathname overflow. Disallow a zero buffer length. The fstat() > calls were superfluous, as a read() or write() on the fd would > retur

Re: [dm-devel] clean up zoned device information v2

2022-07-12 Thread Shinichiro Kawasaki
On Jul 06, 2022 / 09:03, Christoph Hellwig wrote: > Hi all, > > this cleans up the block layer zoned device information APIs and > moves all fields currently in the request_queue to the gendisk as > they aren't relevant for passthrough I/O. > > Changes since v1: > - drop the blk-zoned/nvmet code

[dm-devel] Regarding dm-clone

2022-07-12 Thread Uday Jonnala
Hi Team, Looking to see if dm-clone is supported in 5.4.17-2136.308.9.el8uek.x86_64 : Kernel Version (OEL RHEL 8 based) Which RHEL version has dm-clone checkedin Thanks & Regards, Uday Kiran -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH v3 1/3] crypto: qat - use pre-allocated buffers in datapath

2022-07-12 Thread Lucas Segarra
On Mon, Jul 11, 2022 at 03:21:39PM +0100, Giovanni Cabiddu wrote: > On Mon, Apr 11, 2022 at 05:37:24PM +, Eric Biggers wrote: > > On Sun, Apr 10, 2022 at 08:47:05PM +0100, Giovanni Cabiddu wrote: > > > If requests exceed 4 entries buffers, memory is allocated dynamically. > > > > > > In additi

Re: [dm-devel] [linux-next:master] BUILD REGRESSION 088b9c375534d905a4d337c78db3b3bfbb52c4a0

2022-07-12 Thread Dan Carpenter
On Thu, Jul 07, 2022 at 07:02:58AM -0700, Guenter Roeck wrote: > and the NULL > dereferences in the binder driver are at the very least suspicious. The NULL dereferences in binder are just nonsense Sparse annotations. They don't affect runtime. drivers/android/binder.c:1481:19-23: ERROR: from is