Re: [dm-devel] [PATCH] multipath-tools: remove list of rebranded arrays vendors from man page

2022-07-25 Thread Benjamin Marzinski
On Thu, Jul 21, 2022 at 07:22:04PM +0200, Xose Vazquez Perez wrote: > It does not provide useful info, and it is incomplete. > Reviewed-by: Benjamin Marzinski > Cc: Martin Wilck > Cc: Benjamin Marzinski > Cc: Christophe Varoqui > Cc: DM-DEVEL ML > Signed-off-by: Xose Vazquez Perez > --- >

Re: [dm-devel] [PATCH 3/3] dm-verity: Add try_verify_in_tasklet

2022-07-25 Thread Mike Snitzer
On Fri, Jul 22 2022 at 5:38P -0400, Nathan Huckleberry wrote: > Using tasklets for disk verification can reduce IO latency. When there are > accelerated hash instructions it is often better to compute the hash > immediately > using a tasklet rather than deferring verification to a work-queue.

Re: [dm-devel] [PATCH 1/1] block: Add support for setting inline encryption key per block device

2022-07-25 Thread Daniil Lunev
On Wed, Jul 20, 2022 at 11:49:07PM -0700, Eric Biggers wrote: > I'm glad to see a proposal in this area -- this is something that is greatly > needed. Chrome OS is looking for something like "dm-crypt with inline crypto > support", which this should work for. Android is also looking for something

Re: [dm-devel] [PATCH 3/3] dm-verity: Add try_verify_in_tasklet

2022-07-25 Thread Eric Biggers
On Mon, Jul 25, 2022 at 09:58:39PM -0400, Mike Snitzer wrote: > > > @@ -1156,7 +1217,7 @@ static int verity_ctr(struct dm_target *ti, unsigned > > argc, char **argv) > > goto bad; > > } > > > > - v->tfm = crypto_alloc_ahash(v->alg_name, 0, 0); > > + v->tfm = crypto_alloc_aha

Re: [dm-devel] [PATCH 3/3] dm-verity: Add try_verify_in_tasklet

2022-07-25 Thread Mike Snitzer
On Mon, Jul 25 2022 at 11:06P -0400, Eric Biggers wrote: > On Mon, Jul 25, 2022 at 09:58:39PM -0400, Mike Snitzer wrote: > > > > > @@ -1156,7 +1217,7 @@ static int verity_ctr(struct dm_target *ti, > > > unsigned argc, char **argv) > > > goto bad; > > > } > > > > > > - v->tfm = cry