Re: [dm-devel] [PATCH v12 13/13] dm: add power-of-2 target for zoned devices with non power-of-2 zone sizes

2022-08-29 Thread Shinichiro Kawasaki
On Aug 23, 2022 / 14:18, Pankaj Raghav wrote: > Only zoned devices with power-of-2(po2) number of sectors per zone(zone > size) were supported in linux but now non power-of-2(npo2) zone sizes > support has been added to the block layer. > > Filesystems such as F2FS and btrfs have support for zoned

Re: [dm-devel] [PATCH v4 0/5] multipath: optimizations for large mptable

2022-08-29 Thread Benjamin Marzinski
On Fri, Aug 26, 2022 at 08:05:51PM +0200, mwi...@suse.com wrote: > From: Martin Wilck For the set: Reviewed-by: Benjamin Marzinski > > We observe that multipath operations take a long time if the multipaths > section in multipath.conf contains a lot of alias settings > (1+ in our case). Th

[dm-devel] [PATCH] multipathd: check for command overflow

2022-08-29 Thread Benjamin Marzinski
The code to build the command string calls snprintf() in a loop, adding the return value to the start pointer, c. Since snprintf() can return more characters than it actually printed if it runs out of space, c can end up pointing past the end of the command string buffer on sebsequent loops. Since

Re: [dm-devel] [PATCH v3 00/11] Split libmultipath and libmpathutil

2022-08-29 Thread Benjamin Marzinski
On Mon, Aug 22, 2022 at 11:22:49PM +0200, mwi...@suse.com wrote: > From: Martin Wilck > > The CI found a few more glitches in my v2 patch set. Not reposting > the entire set here, just the changed patches. For all except 01/11 & 10/11: Reviewed-by: Benjamin Marzinski > > Changes v2->v3: > f

Re: [dm-devel] [PATCH v2 10/11] multipathd: exec multipathc in interactive mode

2022-08-29 Thread Benjamin Marzinski
On Mon, Aug 22, 2022 at 10:41:18PM +0200, mwi...@suse.com wrote: > From: Martin Wilck > > A previous patch disabled interactive mode in multipathd, because > uxclnt() would return immediately without an input command > > With this patch, we reinstate interactive mode for "multipath -k", > by jus

Re: [dm-devel] [PATCH v2 01/11] multipathd: replace libreadline with getline()

2022-08-29 Thread Benjamin Marzinski
On Mon, Aug 22, 2022 at 10:41:09PM +0200, mwi...@suse.com wrote: > From: Hannes Reinecke > > libreadline changed the license to be incompatible with multipath-tools > usage, so replace it with a simple getline(). > > mwilck: Make this the default option via Makefile.inc; it is used if > READLINE