Re: [dm-devel] [PATCH v4 10/12] multipathd: exec multipathc in interactive mode

2022-08-31 Thread Benjamin Marzinski
On Tue, Aug 30, 2022 at 09:27:11PM +0200, mwi...@suse.com wrote: > From: Martin Wilck > > A previous patch disabled interactive mode in multipathd, because > uxclnt() would return immediately without an input command. > > With this patch, we reinstate interactive mode for "multipath -k", > by ju

Re: [dm-devel] [PATCH v4 12/12] multipathd: fix use-after-free in handle_path_wwid_change()

2022-08-31 Thread Benjamin Marzinski
On Tue, Aug 30, 2022 at 09:27:13PM +0200, mwi...@suse.com wrote: > From: Martin Wilck > > Found by coverity (defect #380536). > > Fixes: b4eb57e ("libmultipath, multipathd: log failure setting sysfs > attributes") Reviewed-by: Benjamin Marzinski > --- > multipathd/main.c | 5 +++-- > 1 file c

Re: [dm-devel] [PATCH v4 09/12] multipathc: add new interactive client program

2022-08-31 Thread Benjamin Marzinski
On Tue, Aug 30, 2022 at 09:27:10PM +0200, mwi...@suse.com wrote: > From: Martin Wilck > > Add a new small program, multipathc, that acts as interactive > uxsock client for multipathd. multipathc is the only program > that has an interactive mode and can thus link to either libreadline > or libedi

Re: [dm-devel] [PATCH v4 01/12] multipathd: replace libreadline with getline()

2022-08-31 Thread Benjamin Marzinski
On Tue, Aug 30, 2022 at 09:27:02PM +0200, mwi...@suse.com wrote: > From: Hannes Reinecke > > libreadline changed the license to be incompatible with multipath-tools > usage, so replace it with a simple getline(). > > mwilck: Make this the default option via Makefile.inc; it is used if > READLINE

[dm-devel] [PATCH] md: fix repeated words in comments

2022-08-31 Thread Jilin Yuan
Delete the redundant word 'that'. Signed-off-by: Jilin Yuan --- drivers/md/dm-raid.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/md/dm-raid.c b/drivers/md/dm-raid.c index c640be453313..e448fd45a914 100644 --- a/drivers/md/dm-raid.c +++ b/drivers/md/dm-raid.c @@ -2