Re: [PATCH] xfs: fail dax mount if reflink is enabled on a partition

2022-10-21 Thread Darrick J. Wong
On Thu, Oct 20, 2022 at 10:17:45PM +0800, Yang, Xiao/杨 晓 wrote: > On 2022/10/5 2:26, Darrick J. Wong wrote: > > Notice this line in generic/470: > > > > $XFS_IO_PROG -t -c "truncate $LEN" -c "mmap -S 0 $LEN" -c "mwrite 0 $LEN" \ > > -c "log_writes -d $LOGWRITES_NAME -m preunmap" \ > > -f

Re: [dm-devel] [PATCH 3/4] libmultipath: use regular array for field widths

2022-10-21 Thread Martin Wilck
On Fri, 2022-10-21 at 12:51 -0500, Benjamin Marzinski wrote: > On Fri, Oct 21, 2022 at 07:04:55AM +, Martin Wilck wrote: > > On Tue, 2022-10-11 at 16:53 -0500, Benjamin Marzinski wrote: > > > We know the size of these arrays, so we can just allocate them on > > > the > > > stack. Also,

Re: [dm-devel] [PATCH 4/8] libmultipath: fix queue_mode feature handling

2022-10-21 Thread Martin Wilck
On Fri, 2022-10-21 at 12:48 -0500, Benjamin Marzinski wrote: > On Thu, Oct 20, 2022 at 02:58:42PM +, Martin Wilck wrote: > > On Fri, 2022-10-07 at 12:35 -0500, Benjamin Marzinski wrote: > > > device-mapper is not able to change the queue_mode on a table > > > reload. > > > Make sure that when

Re: [dm-devel] [PATCH 3/4] libmultipath: use regular array for field widths

2022-10-21 Thread Benjamin Marzinski
On Fri, Oct 21, 2022 at 07:04:55AM +, Martin Wilck wrote: > On Tue, 2022-10-11 at 16:53 -0500, Benjamin Marzinski wrote: > > We know the size of these arrays, so we can just allocate them on the > > stack. Also, show_path() doesn't use the width, so don't initialize > > it > > in the first

Re: [dm-devel] [PATCH 4/8] libmultipath: fix queue_mode feature handling

2022-10-21 Thread Benjamin Marzinski
On Thu, Oct 20, 2022 at 02:58:42PM +, Martin Wilck wrote: > On Fri, 2022-10-07 at 12:35 -0500, Benjamin Marzinski wrote: > > device-mapper is not able to change the queue_mode on a table reload. > > Make sure that when multipath sets up the map, both on regular > > reloads > > and

Re: [dm-devel] [PATCH 1/8] libmultipath: cleanup remove_feature

2022-10-21 Thread Benjamin Marzinski
On Thu, Oct 20, 2022 at 02:58:23PM +, Martin Wilck wrote: > On Fri, 2022-10-07 at 12:35 -0500, Benjamin Marzinski wrote: > > remove_feature() didn't correctly handle feature strings that used > > whitespace other than spaces, which the kernel allows. It also didn't > > check if the feature

Re: [dm-devel] [PATCH 1/4] libmultipath: don't print garbage keywords

2022-10-21 Thread Martin Wilck
On Tue, 2022-10-11 at 16:53 -0500, Benjamin Marzinski wrote: > If snprint_keyword() failed to correctly set up sbuf, don't print it. > Instead, return an error. > > Signed-off-by: Benjamin Marzinski Reviewed-by: Martin Wilck > --- >  libmpathutil/parser.c | 8 +--- >  1 file changed, 5

Re: [dm-devel] [PATCH 3/4] libmultipath: use regular array for field widths

2022-10-21 Thread Martin Wilck
On Tue, 2022-10-11 at 16:53 -0500, Benjamin Marzinski wrote: > We know the size of these arrays, so we can just allocate them on the > stack. Also, show_path() doesn't use the width, so don't initialize > it > in the first place. > > Signed-off-by: Benjamin Marzinski This isn't wrong, but I'm

Re: [dm-devel] [PATCH 1/6] block: clear the holder releated fields when deleting the kobjects

2022-10-21 Thread Yu Kuai
Hi, Christoph 在 2022/10/21 0:46, Christoph Hellwig 写道: Zero out the pointers to the holder related kobjects so that the holder code doesn't incorrectly when called by dm for the delayed holder registration. Fixes: 89f871af1b26 ("dm: delay registering the gendisk") Reported-by: Yu Kuai

Re: [dm-devel] [PATCH 1/6] block: clear the holder releated fields when deleting the kobjects

2022-10-21 Thread Yu Kuai
在 2022/10/21 11:12, Yu Kuai 写道: Hi, Christoph 在 2022/10/21 0:46, Christoph Hellwig 写道: Zero out the pointers to the holder related kobjects so that the holder code doesn't incorrectly when called by dm for the delayed holder registration. Fixes: 89f871af1b26 ("dm: delay registering the