Re: [dm-devel] [PATCH 5/7] dm: track per-add_disk holder relations in DM

2022-11-10 Thread Mike Snitzer
On Wed, Nov 09 2022 at 3:26P -0500, Christoph Hellwig wrote: > On Wed, Nov 09, 2022 at 10:08:14AM +0800, Yu Kuai wrote: > >> diff --git a/drivers/md/dm.c b/drivers/md/dm.c > >> index 2917700b1e15c..7b0d6dc957549 100644 > >> --- a/drivers/md/dm.c > >> +++ b/drivers/md/dm.c > >> @@ -751,9 +751,16

Re: [dm-devel] [PATCH 0/3] fix direct io errors on dm-crypt

2022-11-10 Thread Eric Biggers
On Thu, Nov 03, 2022 at 08:25:56AM -0700, Keith Busch wrote: > From: Keith Busch > > The 6.0 kernel made some changes to the direct io interface to allow > offsets in user addresses. This based on the hardware's capabilities > reported in the request_queue's dma_alignment attribute. > > dm-crypt

Re: [dm-devel] [PATCH 5/7] dm: track per-add_disk holder relations in DM

2022-11-10 Thread Mike Snitzer
On Thu, Nov 10 2022 at 1:09P -0500, Mike Snitzer wrote: > The concern for race aside: > I am concerned that your redundant bd_link_disk_holder() (first in > open_table_device and later in dm_setup_md_queue) will result in > dangling refcount (e.g. increase of 2 when it should only be by 1) -- >

[dm-devel] [PATCHv2 3/5] block: make blk_set_default_limits() private

2022-11-10 Thread Keith Busch
From: Keith Busch There are no external users of this function. Signed-off-by: Keith Busch Reviewed-by: Christoph Hellwig --- block/blk-settings.c | 1 - block/blk.h| 1 + include/linux/blkdev.h | 1 - 3 files changed, 1 insertion(+), 2 deletions(-) diff --git a/block/blk-setti

[dm-devel] [PATCHv2 0/5] fix direct io device mapper errors

2022-11-10 Thread Keith Busch
From: Keith Busch The 6.0 kernel made some changes to the direct io interface to allow offsets in user addresses. This based on the hardware's capabilities reported in the request_queue's dma_alignment attribute. dm-crypt, -log-writes and -integrity require direct io be aligned to the block size

[dm-devel] [PATCHv2 2/5] dm-crypt: provide dma_alignment limit in io_hints

2022-11-10 Thread Keith Busch
From: Keith Busch This device mapper needs bio vectors to be sized and memory aligned to the logical block size. Set the minimum required queue limit accordingly. Link: https://lore.kernel.org/linux-block/20221101001558.648ee...@xps.demsh.org/ Fixes: b1a000d3b8ec5 ("block: relax direct io memory

[dm-devel] [PATCHv2 4/5] dm-integrity: set dma_alignment limit in io_hints

2022-11-10 Thread Keith Busch
From: Keith Busch This device mapper needs bio vectors to be sized and memory aligned to the logical block size. Set the minimum required queue limit accordingly. Signed-off-by: Keith Busch --- drivers/md/dm-integrity.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/md/dm-integrit

Re: [dm-devel] [PATCH 0/3] fix direct io errors on dm-crypt

2022-11-10 Thread Keith Busch
On Thu, Nov 10, 2022 at 06:24:03PM +, Eric Biggers wrote: > On Thu, Nov 03, 2022 at 08:25:56AM -0700, Keith Busch wrote: > > From: Keith Busch > > > > The 6.0 kernel made some changes to the direct io interface to allow > > offsets in user addresses. This based on the hardware's capabilities

[dm-devel] [PATCHv2 5/5] dm-log-writes: set dma_alignment limit in io_hints

2022-11-10 Thread Keith Busch
From: Keith Busch This device mapper needs bio vectors to be sized and memory aligned to the logical block size. Set the minimum required queue limit accordingly. Signed-off-by: Keith Busch --- drivers/md/dm-log-writes.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/md/dm-log-wri

[dm-devel] [PATCHv2 1/5] block: make dma_alignment a stacking queue_limit

2022-11-10 Thread Keith Busch
From: Keith Busch Device mappers had always been getting the default 511 dma mask, but the underlying device might have a larger alignment requirement. Since this value is used to determine alloweable direct-io alignment, this needs to be a stackable limit. Signed-off-by: Keith Busch Reviewed-b