Re: [dm-devel] [PATCH] fixup! libmultipath: use directio checker for LIO targets

2023-03-31 Thread Martin Wilck
On Fri, 2023-03-31 at 08:47 -0500, Benjamin Marzinski wrote: > On Fri, Mar 31, 2023 at 10:28:35AM +0200, mwi...@suse.com wrote: > > From: Martin Wilck > > > > When we set the check to something other than TUR, we need > > to disable checker detection, too. > > > > Signed-off-by: Martin Wilck >

Re: [dm-devel] [PATCH] dm raid: remove unused d variable

2023-03-31 Thread Heinz Mauelshagen
On Thu, Mar 30, 2023 at 11:28 PM Tom Rix wrote: > clang with W=1 reports > drivers/md/dm-raid.c:2212:15: error: variable > 'd' set but not used [-Werror,-Wunused-but-set-variable] > unsigned int d; > ^ > This variable is not used so remove it. > > Signed-off-by: Tom

Re: [dm-devel] [PATCH] fixup! libmultipath: use directio checker for LIO targets

2023-03-31 Thread Benjamin Marzinski
On Fri, Mar 31, 2023 at 10:28:35AM +0200, mwi...@suse.com wrote: > From: Martin Wilck > > When we set the check to something other than TUR, we need > to disable checker detection, too. > > Signed-off-by: Martin Wilck Reviewed-by: Benjamin Marzinski > --- > libmultipath/hwtable.c | 1 + > 1

Re: [dm-devel] [PATCH 13/19] zram: use __bio_add_page for adding single page to bio

2023-03-31 Thread Pankaj Raghav
On Wed, Mar 29, 2023 at 10:05:59AM -0700, Johannes Thumshirn wrote: > The zram writeback code uses bio_add_page() to add a page to a newly > created bio. bio_add_page() can fail, but the return value is never > checked. > > Use __bio_add_page() as adding a single page to a newly created bio is > g

Re: [dm-devel] [PATCH 01/19] swap: use __bio_add_page to add page to bio

2023-03-31 Thread Pankaj Raghav
On Wed, Mar 29, 2023 at 10:05:47AM -0700, Johannes Thumshirn wrote: > The swap code only adds a single page to a newly created bio. So use > __bio_add_page() to add the page which is guaranteed to succeed in this > case. > > This brings us closer to marking bio_add_page() as __must_check. > > Sig

Re: [dm-devel] [PATCH v2 2/7] dm: Add support for block provisioning

2023-03-31 Thread Brian Foster
On Thu, Mar 30, 2023 at 05:30:22PM -0700, Sarthak Kukreti wrote: > On Thu, Jan 5, 2023 at 6:42 AM Brian Foster wrote: > > > > On Thu, Dec 29, 2022 at 12:12:47AM -0800, Sarthak Kukreti wrote: > > > Add support to dm devices for REQ_OP_PROVISION. The default mode > > > is to pass through the request

Re: [dm-devel] [PATCH 04/19] fs: buffer: use __bio_add_page to add single page to bio

2023-03-31 Thread Pankaj Raghav
On Wed, Mar 29, 2023 at 10:05:50AM -0700, Johannes Thumshirn wrote: > The buffer_head submission code uses bio_add_page() to add a page to a > newly created bio. bio_add_page() can fail, but the return value is never > checked. > > Use __bio_add_page() as adding a single page to a newly created bi

[dm-devel] [PATCH] fixup! libmultipath: use directio checker for LIO targets

2023-03-31 Thread mwilck
From: Martin Wilck When we set the check to something other than TUR, we need to disable checker detection, too. Signed-off-by: Martin Wilck --- libmultipath/hwtable.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c index c2a024c..65bca74 100