[dm-devel] [PATCH 03/13] dm integrity: Use alloc_ordered_workqueue() to create ordered workqueues

2023-05-08 Thread Tejun Heo
BACKGROUND == When multiple work items are queued to a workqueue, their execution order doesn't match the queueing order. They may get executed in any order and simultaneously. When fully serialized execution - one by one in the queueing order - is needed, an ordered workqueue should be

[dm-devel] [PATCH 5/5] Enable configuration and building of dm-vdo.

2023-05-08 Thread J. corwin Coburn
From: corwin This adds dm-vdo to the drivers/md Kconfig and Makefile. Signed-off-by: corwin --- drivers/md/Kconfig | 16 drivers/md/Makefile | 2 ++ 2 files changed, 18 insertions(+) diff --git a/drivers/md/Kconfig b/drivers/md/Kconfig index b0a22e99bad..9fa9dec1029 100644

[dm-devel] [PATCH 4/5] Add dm-vdo-target.c

2023-05-08 Thread J. corwin Coburn
From: corwin This adds the dm-vdo target. Signed-off-by: corwin --- drivers/md/dm-vdo-target.c | 2983 1 file changed, 2983 insertions(+) create mode 100644 drivers/md/dm-vdo-target.c diff --git a/drivers/md/dm-vdo-target.c b/drivers/md/dm-vdo-target.c

[dm-devel] [PATCH 1/5] Add documentation for dm-vdo.

2023-05-08 Thread J. corwin Coburn
From: corwin This adds the admin-guide documentation for dm-vdo. vdo.rst is the guide to using dm-vdo. vdo-design is an overview of the design of dm-vdo. Signed-off-by: corwin --- .../admin-guide/device-mapper/vdo-design.rst | 390 ++ .../admin-guide/device-mapper/vdo.rst

[dm-devel] [PATCH 0/5] Add the dm-vdo deduplication and compression device mapper target.

2023-05-08 Thread J. corwin Coburn
From: corwin The dm-vdo target provides inline deduplication, compression, zero-block elimination, and thin provisioning. A dm-vdo target can be backed by up to 256TB of storage, and can present a logical size of up to 4PB. This target was originally developed at Permabit Technology Corp.

Re: [dm-devel] [PATCH v6 10/12] crypto: x86/aes - Prepare for a new AES implementation

2023-05-08 Thread Chang S. Bae
On 5/5/2023 4:27 PM, Eric Biggers wrote: On Mon, Apr 10, 2023 at 03:59:34PM -0700, Chang S. Bae wrote: Refactor the common C code to avoid code duplication. The AES-NI code uses it with a function pointer argument to call back the AES-NI assembly code. So will the AES-KL code. Actually, the

Re: [dm-devel] [PATCH v6 07/12] x86/cpu/keylocker: Load an internal wrapping key at boot-time

2023-05-08 Thread Dave Hansen
On 5/8/23 17:31, Chang S. Bae wrote: >> With the macro, they'll get no type warning.  The inline actually makes >> it easier to find bugs because folks will get _some_ type checking no >> matter how they compile the code. > > Ah, when the prototype with one or more arguments, 'static inline' >

Re: [dm-devel] [PATCH v6 07/12] x86/cpu/keylocker: Load an internal wrapping key at boot-time

2023-05-08 Thread Chang S. Bae
On 5/8/2023 2:56 PM, Dave Hansen wrote: On 5/8/23 11:18, Chang S. Bae wrote: On 5/5/2023 4:05 PM, Eric Biggers wrote: On Mon, Apr 10, 2023 at 03:59:31PM -0700, Chang S. Bae wrote:   +#ifdef CONFIG_X86_KEYLOCKER +void setup_keylocker(struct cpuinfo_x86 *c); +void destroy_keylocker_data(void);

Re: [dm-devel] [PATCH RFC 01/16] block: Add atomic write operations to request_queue limits

2023-05-08 Thread Mike Snitzer
On Wed, May 3, 2023 at 2:40 PM John Garry wrote: > > From: Himanshu Madhani > > Add the following limits: > - atomic_write_boundary > - atomic_write_max_bytes > - atomic_write_unit_max > - atomic_write_unit_min > > Signed-off-by: Himanshu Madhani > Signed-off-by: John Garry > --- >

Re: [dm-devel] [PATCH v6 08/12] x86/PM/keylocker: Restore internal wrapping key on resume from ACPI S3/4

2023-05-08 Thread Chang S. Bae
On 5/5/2023 4:09 PM, Eric Biggers wrote: On Mon, Apr 10, 2023 at 03:59:32PM -0700, Chang S. Bae wrote: +/* + * This flag is set with IWKey load. When the key restore fails, it is + * reset. This restore state is exported to the crypto library, then AES-KL + * will not be used there. So, the

Re: [dm-devel] [PATCH v6 11/12] crypto: x86/aes-kl - Support AES algorithm using Key Locker instructions

2023-05-08 Thread Elliott, Robert (Servers)
> diff --git a/crypto/Kconfig b/crypto/Kconfig ... > +config AS_HAS_KEYLOCKER > + def_bool $(as-instr,encodekey256 %eax$(comma)%eax) > + help > + Supported by binutils >= 2.36 and LLVM integrated assembler >= V12 > + > +config CRYPTO_AES_KL > + tristate "AES cipher algorithms

Re: [dm-devel] [PATCH v6 11/12] crypto: x86/aes-kl - Support AES algorithm using Key Locker instructions

2023-05-08 Thread Chang S. Bae
On 5/5/2023 5:01 PM, Eric Biggers wrote: On Mon, Apr 10, 2023 at 03:59:35PM -0700, Chang S. Bae wrote: [PATCH v6 11/12] crypto: x86/aes-kl - Support AES algorithm using Key Locker instructions Thanks for dropping the unnecessary modes of operation (CBC, ECB, CTR). It simplified the patchset

Re: [dm-devel] [PATCH v6 07/12] x86/cpu/keylocker: Load an internal wrapping key at boot-time

2023-05-08 Thread Chang S. Bae
On 5/8/2023 12:18 PM, Elliott, Robert (Servers) wrote: diff --git a/arch/x86/kernel/keylocker.c b/arch/x86/kernel/keylocker.c ... +void __init destroy_keylocker_data(void) +{ + memset(_setup.key, KEY_DESTROY, sizeof(kl_setup.key)); +} That's a special value for garbage collected

Re: [dm-devel] [PATCH v6 07/12] x86/cpu/keylocker: Load an internal wrapping key at boot-time

2023-05-08 Thread Dave Hansen
On 5/8/23 11:18, Chang S. Bae wrote: > On 5/5/2023 4:05 PM, Eric Biggers wrote: >> On Mon, Apr 10, 2023 at 03:59:31PM -0700, Chang S. Bae wrote: >>>   +#ifdef CONFIG_X86_KEYLOCKER >>> +void setup_keylocker(struct cpuinfo_x86 *c); >>> +void destroy_keylocker_data(void); >>> +#else >>> +#define

Re: [dm-devel] [PATCH v6 07/12] x86/cpu/keylocker: Load an internal wrapping key at boot-time

2023-05-08 Thread Elliott, Robert (Servers)
> diff --git a/arch/x86/kernel/keylocker.c b/arch/x86/kernel/keylocker.c ... > +void __init destroy_keylocker_data(void) > +{ > + memset(_setup.key, KEY_DESTROY, sizeof(kl_setup.key)); > +} That's a special value for garbage collected keyring keys assigned a keytype of ".dead". memzero() or

Re: [dm-devel] [PATCH v6 07/12] x86/cpu/keylocker: Load an internal wrapping key at boot-time

2023-05-08 Thread Chang S. Bae
On 5/5/2023 4:05 PM, Eric Biggers wrote: On Mon, Apr 10, 2023 at 03:59:31PM -0700, Chang S. Bae wrote: +#ifdef CONFIG_X86_KEYLOCKER +void setup_keylocker(struct cpuinfo_x86 *c); +void destroy_keylocker_data(void); +#else +#define setup_keylocker(c) do { } while (0) +#define

Re: [dm-devel] [PATCH v6 11/12] crypto: x86/aes-kl - Support AES algorithm using Key Locker instructions

2023-05-08 Thread Elliott, Robert (Servers)
> -Original Message- > From: Elliott, Robert (Servers) ... > This material belongs in arch/x86/Kconfig now (which didn't exist when > this patch series began). Sorry, omitted one level: arch/x86/crypto/Kconfig -- dm-devel mailing list dm-devel@redhat.com

Re: [dm-devel] [PATCH blktests v2] tests/dm: add a regression test

2023-05-08 Thread Shinichiro Kawasaki
On May 04, 2023 / 11:18, Yu Kuai wrote: > Hi, > > 在 2023/05/01 12:34, Shinichiro Kawasaki 写道: > > Yu, thanks for the patch. I have three minor comments below. Other than > > that, > > the patch looks good to me. If you do not mind, I can do these edits. > > Please let > > me know your thoughts.

Re: [dm-devel] [PATCH v6 11/12] crypto: x86/aes-kl - Support AES algorithm using Key Locker instructions

2023-05-08 Thread Chang S. Bae
On 5/8/2023 12:24 PM, Elliott, Robert (Servers) wrote: ... This material belongs in arch/x86/Kconfig now (which didn't exist when this patch series began). Sorry, omitted one level: arch/x86/crypto/Kconfig Thanks for pointing this out! Otherwise, it might happen to be based on