Re: [dm-devel] fuzzing bcachefs with dm-flakey

2023-06-09 Thread Kent Overstreet
On Fri, Jun 09, 2023 at 10:57:27PM +0200, Mikulas Patocka wrote: > > > On Tue, 30 May 2023, Kent Overstreet wrote: > > > On Tue, May 30, 2023 at 05:00:39PM -0400, Mikulas Patocka wrote: > > > I'd like to know how do you want to do coverage analysis? By > > > instrumenting > > > each branch

Re: [dm-devel] [PATCH v7 0/5] Introduce provisioning primitives

2023-06-09 Thread Dave Chinner
On Fri, Jun 09, 2023 at 04:31:41PM -0400, Mike Snitzer wrote: > On Wed, Jun 07 2023 at 7:27P -0400, > Mike Snitzer wrote: > > > On Mon, Jun 05 2023 at 5:14P -0400, > > Sarthak Kukreti wrote: > > > > > On Sat, Jun 3, 2023 at 8:57 AM Mike Snitzer wrote: > > > > > > > > We all just need to

Re: [dm-devel] fuzzing bcachefs with dm-flakey

2023-06-09 Thread Mikulas Patocka
On Tue, 30 May 2023, Kent Overstreet wrote: > On Tue, May 30, 2023 at 05:00:39PM -0400, Mikulas Patocka wrote: > > I'd like to know how do you want to do coverage analysis? By instrumenting > > each branch and creating a test case that tests that the branch goes both > > ways? > >

Re: [dm-devel] [PATCH v7 0/5] Introduce provisioning primitives

2023-06-09 Thread Mike Snitzer
On Wed, Jun 07 2023 at 7:27P -0400, Mike Snitzer wrote: > On Mon, Jun 05 2023 at 5:14P -0400, > Sarthak Kukreti wrote: > > > On Sat, Jun 3, 2023 at 8:57 AM Mike Snitzer wrote: > > > > > > We all just need to focus on your proposal and Joe's dm-thin > > > reservation design... > > > > > >

Re: [dm-devel] [PATCH v7 2/5] block: Introduce provisioning primitives

2023-06-09 Thread Mike Snitzer
On Thu, May 18 2023 at 6:33P -0400, Sarthak Kukreti wrote: > Introduce block request REQ_OP_PROVISION. The intent of this request > is to request underlying storage to preallocate disk space for the given > block range. Block devices that support this capability will export > a provision limit

Re: [dm-devel] fuzzing bcachefs with dm-flakey

2023-06-09 Thread Darrick J. Wong
On Fri, Jun 09, 2023 at 08:56:37PM +0200, Mikulas Patocka wrote: > > > On Thu, 1 Jun 2023, Darrick J. Wong wrote: > > > On Mon, May 29, 2023 at 04:59:40PM -0400, Mikulas Patocka wrote: > > > > > #!/bin/sh -ex > > > umount /mnt/test || true > > > dmsetup remove_all || true > > > rmmod brd ||

Re: [dm-devel] fuzzing bcachefs with dm-flakey

2023-06-09 Thread Mikulas Patocka
On Thu, 1 Jun 2023, Darrick J. Wong wrote: > On Mon, May 29, 2023 at 04:59:40PM -0400, Mikulas Patocka wrote: > > > #!/bin/sh -ex > > umount /mnt/test || true > > dmsetup remove_all || true > > rmmod brd || true > > SRC=/usr/src/git/bcachefs-tools > > while true; do > > modprobe brd

Re: [dm-devel] [PATCH v2 13/16] xen-blkback: Implement diskseq checks

2023-06-09 Thread Demi Marie Obenour
On Fri, Jun 09, 2023 at 05:13:45PM +0200, Roger Pau Monné wrote: > On Thu, Jun 08, 2023 at 11:33:26AM -0400, Demi Marie Obenour wrote: > > On Thu, Jun 08, 2023 at 10:29:18AM +0200, Roger Pau Monné wrote: > > > On Wed, Jun 07, 2023 at 12:14:46PM -0400, Demi Marie Obenour wrote: > > > > On Wed, Jun

Re: [dm-devel] [PATCH 21/30] nvme: replace the fmode_t argument to the nvme ioctl handlers with a simple bool

2023-06-09 Thread Keith Busch
Looks good. Reviewed-by: Keith Busch -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] block: fix a crash when bio_for_each_folio_all iterates over an empty bio

2023-06-09 Thread Mike Snitzer
On Tue, Apr 18 2023 at 11:20P -0400, Mike Snitzer wrote: > On Mon, Apr 17 2023 at 3:11P -0400, > Mikulas Patocka wrote: > > > If we use bio_for_each_folio_all on an empty bio, it will access the first > > bio vector unconditionally (it is uninitialized) and it may crash > > depending on the

Re: [dm-devel] dm crypt: Avoid using MAX_CIPHER_BLOCKSIZE

2023-06-09 Thread Herbert Xu
On Thu, Jun 01, 2023 at 03:10:18PM -0400, Mike Snitzer wrote: > > Strikes me as strange that open-coding skcipher_request_{alloc,free} > is ideal, but dm-crypt is the only non-crypto consumer of > MAX_CIPHER_BLOCKSIZE so really not worth standing up yet another > interface wrapper. It is pretty

Re: [dm-devel] [PATCH v2 13/16] xen-blkback: Implement diskseq checks

2023-06-09 Thread Roger Pau Monné
On Wed, Jun 07, 2023 at 12:14:46PM -0400, Demi Marie Obenour wrote: > On Wed, Jun 07, 2023 at 10:20:08AM +0200, Roger Pau Monné wrote: > > On Tue, Jun 06, 2023 at 01:01:20PM -0400, Demi Marie Obenour wrote: > > > On Tue, Jun 06, 2023 at 10:25:47AM +0200, Roger Pau Monné wrote: > > > > On Tue, May

Re: [dm-devel] [PATCH 06/31] cdrom: remove the unused mode argument to cdrom_release

2023-06-09 Thread Phillip Potter
On Thu, Jun 08, 2023 at 11:04:44AM +0200, Christoph Hellwig wrote: > On Thu, Jun 08, 2023 at 09:47:27AM +0100, Phillip Potter wrote: > > Yes indeed - I was under the impression it was appropriate for a > > maintainer to signal their approval of a patch to maintained code using > > a Signed-off-by

Re: [dm-devel] [PATCH v2 16/16] xen-blkback: Inform userspace that device has been opened

2023-06-09 Thread Roger Pau Monné
On Tue, May 30, 2023 at 04:31:16PM -0400, Demi Marie Obenour wrote: > Set "opened" to "0" before the hotplug script is called. Once the > device node has been opened, set "opened" to "1". > > "opened" is used exclusively by userspace. It serves two purposes: > > 1. It tells userspace that the

Re: [dm-devel] [PATCH v2 16/16] xen-blkback: Inform userspace that device has been opened

2023-06-09 Thread Roger Pau Monné
On Wed, Jun 07, 2023 at 12:29:26PM -0400, Demi Marie Obenour wrote: > On Wed, Jun 07, 2023 at 10:44:48AM +0200, Roger Pau Monné wrote: > > On Tue, Jun 06, 2023 at 01:31:25PM -0400, Demi Marie Obenour wrote: > > > On Tue, Jun 06, 2023 at 11:15:37AM +0200, Roger Pau Monné wrote: > > > > On Tue, May

Re: [dm-devel] [PATCH 27/30] block: replace fmode_t with a block-specific type for block open flags

2023-06-09 Thread Christian Brauner
On Thu, Jun 08, 2023 at 01:02:55PM +0200, Christoph Hellwig wrote: > The only overlap between the block open flags mapped into the fmode_t and > other uses of fmode_t are FMODE_READ and FMODE_WRITE. Define a new > blk_mode_t instead for use in blkdev_get_by_{dev,path}, ->open and > ->ioctl and

Re: [dm-devel] [PATCH 06/31] cdrom: remove the unused mode argument to cdrom_release

2023-06-09 Thread Phillip Potter
On Thu, Jun 08, 2023 at 10:41:29AM +0200, Christoph Hellwig wrote: > On Wed, Jun 07, 2023 at 12:00:57AM +0100, Phillip Potter wrote: > > Looks good, thanks. > > > > Signed-off-by: Phillip Potter > > Hmm, these signoffs don't really make sense here. Were they intended > as Reviewed-bys? > Hi

Re: [dm-devel] [PATCH 29/30] block: store the holder in file->private_data

2023-06-09 Thread Hannes Reinecke
On 6/8/23 13:02, Christoph Hellwig wrote: Store the file struct used as the holder in file->private_data as an indicator that this file descriptor was opened exclusively to remove the last use of FMODE_EXCL. Signed-off-by: Christoph Hellwig --- block/fops.c | 14 -- 1 file

[dm-devel] [PATCH 29/30] block: store the holder in file->private_data

2023-06-09 Thread Christoph Hellwig
Store the file struct used as the holder in file->private_data as an indicator that this file descriptor was opened exclusively to remove the last use of FMODE_EXCL. Signed-off-by: Christoph Hellwig --- block/fops.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff

Re: [dm-devel] [PATCH 27/30] block: replace fmode_t with a block-specific type for block open flags

2023-06-09 Thread Hannes Reinecke
On 6/8/23 13:02, Christoph Hellwig wrote: The only overlap between the block open flags mapped into the fmode_t and other uses of fmode_t are FMODE_READ and FMODE_WRITE. Define a new blk_mode_t instead for use in blkdev_get_by_{dev,path}, ->open and ->ioctl and stop abusing fmode_t.

Re: [dm-devel] [PATCH 27/30] block: replace fmode_t with a block-specific type for block open flags

2023-06-09 Thread Hannes Reinecke
On 6/8/23 13:02, Christoph Hellwig wrote: The only overlap between the block open flags mapped into the fmode_t and other uses of fmode_t are FMODE_READ and FMODE_WRITE. Define a new blk_mode_t instead for use in blkdev_get_by_{dev,path}, ->open and ->ioctl and stop abusing fmode_t.

Re: [dm-devel] [PATCH 05/30] cdrom: track if a cdrom_device_info was opened for data

2023-06-09 Thread Hannes Reinecke
On 6/8/23 13:02, Christoph Hellwig wrote: Set a flag when a cdrom_device_info is opened for writing, instead of trying to figure out this at release time. This will allow to eventually remove the mode argument to the ->release block_device_operation as nothing but the CDROM drivers uses that