Re: [dm-devel] [PATCH -next 2/3] md/dm-raid: cleanup multiple equivalent goto tags from raid_ctr()

Hi, 在 2023/07/06 21:01, Paul Menzel 写道: Dear Yu, Thank you for your patch. Some minor nits, if you are interested. Am 06.07.23 um 09:16 schrieb Yu Kuai: From: Yu Kuai There are four equivalent goto tags in raid_ctr(), clean them up to use just one, there are no functional change and prepar

Re: [dm-devel] [PATCH] libmultipath: dm_get_maps(): remove spurious assignment

On Tue, Jun 27, 2023 at 04:33:50PM +0200, mwi...@suse.com wrote: > From: Martin Wilck > > Issue found by coverity: > CID 393674: Code maintainability issues (UNUSED_VALUE) > Assigning value "NULL" to "mpp" here, but that stored value is overwritten > before it can be > > Signed-off-by: Ma

Re: [dm-devel] [PATCH 01/32] block: Provide blkdev_get_handle_* functions

On Thu 06-07-23 08:38:40, Christoph Hellwig wrote: > On Tue, Jul 04, 2023 at 02:21:28PM +0200, Jan Kara wrote: > > Create struct bdev_handle that contains all parameters that need to be > > passed to blkdev_put() and provide blkdev_get_handle_* functions that > > return this structure instead of pl

Re: [dm-devel] [PATCH v2] libmultipath: ignore nvme devices if nvme native multipath is enabled

On Mon, Jul 03, 2023 at 06:40:21PM +0200, mwi...@suse.com wrote: > From: Martin Wilck > > If the nvme native multipath driver is enabled, blacklist nvme devices > for dm-multipath by default. This is particularly useful with > "find_multipaths greedy". > > Signed-off-by: Martin Wilck Reviewed-b

Re: [dm-devel] [PATCH RFC 0/32] block: Make blkdev_get_by_*() return handle

On Tue, Jul 04, 2023 at 02:21:27PM +0200, Jan Kara wrote: > Hello, > > this patch series implements the idea of blkdev_get_by_*() calls returning > bdev_handle which is then passed to blkdev_put() [1]. This makes the get > and put calls for bdevs more obviously matching and allows us to propagate

Re: [dm-devel] [PATCH 01/32] block: Provide blkdev_get_handle_* functions

On Tue, Jul 04, 2023 at 02:21:28PM +0200, Jan Kara wrote: > Create struct bdev_handle that contains all parameters that need to be > passed to blkdev_put() and provide blkdev_get_handle_* functions that > return this structure instead of plain bdev pointer. This will > eventually allow us to pass o

[dm-devel] [PATCH -next 1/3] md/dm-raid: fix that 'reconfig_mutex' is not released from error path in raid_ctr()

From: Yu Kuai In the error path 'bad_stripe_cache' and 'bad_check_reshape', 'reconfig_mutex' is still held after raid_ctr() returns. Fixes: 9dbd1aa3a81c ("dm raid: add reshaping support to the target") Signed-off-by: Yu Kuai --- drivers/md/dm-raid.c | 9 +++-- 1 file changed, 7 insertions(

[dm-devel] [PATCH -next 0/3] dm-raid: minor fixes

From: Yu Kuai This patchset fix two straightforward and easy problems that is found by code review, please consider it for the next merge window. Yu Kuai (3): md/dm-raid: fix that 'reconfig_mutex' is not released from error path in raid_ctr() md/dm-raid: cleanup multiple equivalent goto

[dm-devel] [PATCH -next 3/3] md/dm-raid: protect md_stop() with 'reconfig_mutex'

From: Yu Kuai __md_stop_writes() and __md_stop() will modify many fields that is protected by 'reconfig_mutex', and all the callers will grab 'reconfig_mtuex' expect for md_stop(). Fixes: 9d09e663d550 ("dm: raid456 basic support") Signed-off-by: Yu Kuai --- drivers/md/dm-raid.c | 4 +++- drive

[dm-devel] [PATCH -next 2/3] md/dm-raid: cleanup multiple equivalent goto tags from raid_ctr()

From: Yu Kuai There are four equivalent goto tags in raid_ctr(), clean them up to use just one, there are no functional change and prepare to fix that md_stop() is not protected. Signed-off-by: Yu Kuai --- drivers/md/dm-raid.c | 27 +-- 1 file changed, 9 insertions(+),