On Tue, Oct 24, 2023 at 07:45:13AM +0900, Damien Le Moal wrote:
> dm-error is used in several test cases in the xfstests test suite to
> check the handling of IO errors in file syatems. However, with several
^ systems
> file systems getting native support
On Wed, Oct 25, 2023 at 05:10:56AM +0200, Marek Marczykowski-Górecki wrote:
> On Mon, Oct 23, 2023 at 10:59:40PM +0200, Mikulas Patocka wrote:
> > Hi
> >
> > It's hard to say what causes this. Perhaps dm-crypt exhausts all the
> > higher-order pages and some subsystem stalls because of it.
> >
>
On Mon, Oct 23, 2023 at 10:59:40PM +0200, Mikulas Patocka wrote:
> Hi
>
> It's hard to say what causes this. Perhaps dm-crypt exhausts all the
> higher-order pages and some subsystem stalls because of it.
>
> In drivers/md/dm-crypt.c in function crypt_alloc_buffer there is
> "unsigned int order
On 10/25/23 14:22, Naohiro Aota wrote:
> On Tue, Oct 24, 2023 at 07:45:13AM +0900, Damien Le Moal wrote:
>> dm-error is used in several test cases in the xfstests test suite to
>> check the handling of IO errors in file syatems. However, with several
> ^ sy
On Mon, 25 Sep 2023 07:06:03 +, Justin Stitt wrote:
> `strncpy` is deprecated for use on NUL-terminated destination strings
> [1] and as such we should prefer more robust and less ambiguous string
> interfaces.
>
> `lc` is already zero-allocated:
> | lc = kzalloc(sizeof(*lc), GFP_KERNEL)
On Mon, 25 Sep 2023 06:54:51 +, Justin Stitt wrote:
> `strncpy` is deprecated for use on NUL-terminated destination strings
> [1] and as such we should prefer more robust and less ambiguous string
> interfaces.
>
> We expect `spec->target_type` to be NUL-terminated based on its use with
> a fo
On Mon, 25 Sep 2023 06:35:54 +, Justin Stitt wrote:
> kzalloc() followed by strncpy() on an expected NUL-terminated string is
> just kmemdup_nul(). Let's simplify this code (while also dropping a
> deprecated strncpy() call [1]).
>
>
Applied to for-next/hardening, thanks!
[1/1] dm crypt: re
On Mon, 25 Sep 2023 06:13:12 +, Justin Stitt wrote:
> `strncpy` is deprecated for use on NUL-terminated destination strings
> [1] and as such we should prefer more robust and less ambiguous string
> interfaces.
>
> It seems `cmd->policy_name` is intended to be NUL-terminated based on a
> now c
Looks good to me,
Reviewed-by: Johannes Thumshirn
