to the blacklist unit tests to verify the
inverse matching code and the new default blacklist.
Signed-off-by: Benjamin Marzinski
---
libmultipath/blacklist.c | 41 +-
libmultipath/blacklist.h | 3 +
multipath/multipath.conf.5 | 17 --
tests/blacklist.c | 110 +
l
>
> This patch set implements this idea.
>
Reviewed-by: Benjamin Marzinski
For the set.
> Regards,
> Martin
>
>
> Martin Wilck (2):
> libmultipath: set "enable_foreign" to NONE by default
> multipath: add "-e" option
On Sat, Jun 06, 2020 at 07:23:28PM +, Martin Wilck wrote:
> On Fri, 2020-06-05 at 17:27 -0500, Benjamin Marzinski wrote:
> > On Fri, Jun 05, 2020 at 07:20:26PM +, Martin Wilck wrote:
> > > Hi Ben,
> > >
> > > On Thu, 2020-06-04 at 19:30 -0500, Benjamin
On Fri, Jun 05, 2020 at 07:20:26PM +, Martin Wilck wrote:
> Hi Ben,
>
> On Thu, 2020-06-04 at 19:30 -0500, Benjamin Marzinski wrote:
> > I recently got a request to add the Oracle ASM filer driver devices
> > to
> > multipath's builtin devnode blacklist. However,
Instead of taking the blist and elist devnode vectors, filter device
now takes a config struct. This change is necessary to enable future
commits. It makes no functional changes to the code.
Signed-off-by: Benjamin Marzinski
---
libmultipath/blacklist.c | 8
libmultipath/blacklist.h
.c:132:25: note: format string is defined here
132 | condlog(4, "%s: %s -> '%s'", __func__, attr, p);
| ^~
If p is NULL, use "(null)" instead.
Signed-off-by: Benjamin Marzinski
---
libmultipath/uevent.c | 2 +-
1 file changed, 1 insertio
it
with "multipathd show config" or "multipath -t", since those are
expected to print a valid condig. It is displayed in the "multipathd
show blacklist" output, however.
The blacklist unit tests have also been updated to deal with the
changes.
Signed-off-by: Benjam
the multipath udev rules already do. If people don't like
this solution, the alternative is to add another line to the default
devnode blacklist like "^(asm/|oracleafd/|ofsctl)".
Benjamin Marzinski (2):
libmultipath: change filter_devnode arguments
libmultipath: change how default devnode
s were created during initrd processing,
> but udev processing for the change events of these maps didn't
> complete because udevd was killed to switch root. So, in the coldplug
> case, play safe and process the rules once more.
>
> Signed-off-by: Martin Wilck
Reviewed-by: Benjamin
On Fri, May 29, 2020 at 09:12:30AM +, Martin Wilck wrote:
> Hi Ben,
>
> On Thu, 2020-05-28 at 23:10 -0500, Benjamin Marzinski wrote:
> > From: Björn Esser
> >
> > TRUE/FALSE are not defined anymore. 1 and 0 are used instead.
> > This is backwards compatib
This is a patch I got to keep libdmmp working with the latest json-c
release.
Björn Esser (1):
libdmmp: Add support for upcoming json-c 0.14.0.
libdmmp/libdmmp_private.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
2.17.2
--
dm-devel mailing list
dm-devel@redhat.com
From: Björn Esser
TRUE/FALSE are not defined anymore. 1 and 0 are used instead.
This is backwards compatible, as earlier versions of json-c are
using the same integer values in their present definitions.
Signed-off-by: Benjamin Marzinski
---
libdmmp/libdmmp_private.h | 2 +-
1 file changed
the locking work (which made it necessary to write
a file, even just to check if a file existed), simply check for files
with lstat(), create them with open(), and remove them with unlink().
Reviewed-by: Martin Wilck
Signed-off-by: Benjamin Marzinski
---
libmultipath/wwids.c | 131
. This code will give almost the same answer as the
existing code, with the exception that now, if a device is currently
multipathed, it will always be a valid multipath path.
Reviewed-by: Martin Wilck
Signed-off-by: Benjamin Marzinski
---
libmultipath/Makefile| 2 +-
libmultipath
sysfs_is_multipathed reads the wwid of the dm device holding a path to
check if its a multipath device. Add code to optinally set pp->wwid to
that wwid. This will be used by a future patch.
Reviewed-by: Martin Wilck
Signed-off-by: Benjamin Marzinski
---
libmultipath/sysfs.c |
-off-by: Benjamin Marzinski
---
libmultipath/wwids.c | 42 +-
1 file changed, 29 insertions(+), 13 deletions(-)
diff --git a/libmultipath/wwids.c b/libmultipath/wwids.c
index aab5da8a..61d9c39e 100644
--- a/libmultipath/wwids.c
+++ b/libmultipath/wwids.c
.
Also make dm_prereq a global function.
Reviewed-by: Martin Wilck
Signed-off-by: Benjamin Marzinski
---
libmultipath/devmapper.c | 17 +
libmultipath/devmapper.h | 3 ++-
2 files changed, 15 insertions(+), 5 deletions(-)
diff --git a/libmultipath/devmapper.c b/libmultipath
thd code in various ways, instead
of skipping it, as suggested by Martin Wilck
Changes from v2:
rebased patches on top of Martin's previous patch sets
Benjamin Marzinski (5):
libmultipath: make libmp_dm_init optional
libmultipath: make sysfs_is_multipathed able to return wwid
multipath: ce
Reviewed-by: Martin Wilck
Signed-off-by: Benjamin Marzinski
---
tests/Makefile | 4 +-
tests/valid.c | 486 +
2 files changed, 489 insertions(+), 1 deletion(-)
create mode 100644 tests/valid.c
diff --git a/tests/Makefile b/tests/Makefile
On Tue, May 19, 2020 at 02:55:05PM +0200, Martin Wilck wrote:
> On Mon, 2020-05-18 at 23:57 -0500, Benjamin Marzinski wrote:
> > I've been playing around with the SID code more and I've decided to
> > hold
> > off on submitting the library until I have it working with the SID
thd code in various ways, instead
of skipping it, as suggested by Martin Wilck
Benjamin Marzinski (5):
libmultipath: make libmp_dm_init optional
libmultipath: make sysfs_is_multipathed able to return wwid
multipath: centralize validation code
Unit tests for is_path_valid()
libmultipath: s
sysfs_is_multipathed reads the wwid of the dm device holding a path to
check if its a multipath device. Add code to optinally set pp->wwid to
that wwid. This will be used by a future patch.
Reviewed-by: Martin Wilck
Signed-off-by: Benjamin Marzinski
---
libmultipath/sysfs.c |
Signed-off-by: Benjamin Marzinski
---
tests/Makefile | 4 +-
tests/valid.c | 486 +
2 files changed, 489 insertions(+), 1 deletion(-)
create mode 100644 tests/valid.c
diff --git a/tests/Makefile b/tests/Makefile
index 77ff3249..7fc261c3 100644
-off-by: Benjamin Marzinski
---
libmultipath/wwids.c | 42 +-
1 file changed, 29 insertions(+), 13 deletions(-)
diff --git a/libmultipath/wwids.c b/libmultipath/wwids.c
index da55924b..c7a16636 100644
--- a/libmultipath/wwids.c
+++ b/libmultipath/wwids.c
.
Also make dm_prereq a global function.
Reviewed-by: Martin Wilck
Signed-off-by: Benjamin Marzinski
---
libmultipath/devmapper.c | 17 +
libmultipath/devmapper.h | 3 ++-
2 files changed, 15 insertions(+), 5 deletions(-)
diff --git a/libmultipath/devmapper.c b/libmultipath
the locking work (which made it necessary to write
a file, even just to check if a file existed), simply check for files
with lstat(), create them with open(), and remove them with unlink().
Reviewed-by: Martin Wilck
Signed-off-by: Benjamin Marzinski
---
libmultipath/wwids.c | 131
. This code will give almost the same answer as the
existing code, with the exception that now, if a device is currently
multipathed, it will always be a valid multipath path.
Signed-off-by: Benjamin Marzinski
---
libmultipath/Makefile| 3 +-
libmultipath/devmapper.c | 45
On Fri, May 15, 2020 at 08:37:23PM +, Martin Wilck wrote:
> On Thu, 2020-05-14 at 20:59 -0500, Benjamin Marzinski wrote:
> > Signed-off-by: Benjamin Marzinski
>
> Two minor nits below, otherwise ack.
Sure. I can fix those up.
-Ben
>
> > ---
> > tests/Makefi
On Fri, May 15, 2020 at 08:37:16PM +, Martin Wilck wrote:
> On Thu, 2020-05-14 at 20:59 -0500, Benjamin Marzinski wrote:
> > This code pulls the multipath path validation code out of
> > configure(),
> > and puts it into its own function, check_path_valid(). This fun
On Thu, May 14, 2020 at 08:59:16PM -0500, Benjamin Marzinski wrote:
> I've been playing around with the SID code more and I've decided to hold
> off on submitting the library until I have it working with the SID
> multipath module better. Instead, I've pulled out the common code that
&g
the locking work (which made it necessary to write
a file, even just to check if a file existed), simply check for files
with lstat(), create them with open(), and remove them with unlink().
Signed-off-by: Benjamin Marzinski
---
libmultipath/wwids.c | 131 ++-
1
-off-by: Benjamin Marzinski
---
libmultipath/wwids.c | 42 +-
1 file changed, 29 insertions(+), 13 deletions(-)
diff --git a/libmultipath/wwids.c b/libmultipath/wwids.c
index aab5da8a..61d9c39e 100644
--- a/libmultipath/wwids.c
+++ b/libmultipath/wwids.c
sysfs_is_multipathed reads the wwid of the dm device holding a path to
check if its a multipath device. Add code to optinally set pp->wwid to
that wwid. This will be used by a future patch.
Signed-off-by: Benjamin Marzinski
---
libmultipath/sysfs.c | 24 +++-
libmultip
. This code will give almost the same answer as the
existing code, with the exception that now, if a device is currently
multipathed, it will always be a valid multipath path.
Signed-off-by: Benjamin Marzinski
---
libmultipath/Makefile| 2 +-
libmultipath/devmapper.c | 49
.
Also make dm_prereq a global function.
Reviewed-by: Martin Wilck
Signed-off-by: Benjamin Marzinski
---
libmultipath/devmapper.c | 17 +
libmultipath/devmapper.h | 3 ++-
2 files changed, 15 insertions(+), 5 deletions(-)
diff --git a/libmultipath/devmapper.c b/libmultipath
Signed-off-by: Benjamin Marzinski
---
tests/Makefile | 4 +-
tests/valid.c | 424 +
2 files changed, 427 insertions(+), 1 deletion(-)
create mode 100644 tests/valid.c
diff --git a/tests/Makefile b/tests/Makefile
index 1b8706a7..125553b8 100644
move is a long-overdue cleanup.
>
Reviewed-by: Benjamin Marzinski
For the set
> Regards
> Martin
>
> Martin Wilck (2):
> libmultipath: move libsg into libmultipath
> multipath-tools Makefile: add install dependency
>
> Makefile
; on our build server.
>
> Regards
> Martin
Reviewed-by: Benjamin Marzinski
For the set.
>
> Martin Wilck (11):
> multipath-tools: Makefile: more dependency fixes for parallel build
> multipath-tools: Makefile.inc: separate out OPTFLAGS
> multipath-tools:
On Fri, May 08, 2020 at 09:15:32AM +, Martin Wilck wrote:
> On Fri, 2020-05-01 at 17:39 -0500, Benjamin Marzinski wrote:
> > The (is|mark|unmark)_failed_wwid code is needlessly complicated.
> > Locking a file is necssary if multiple processes could otherwise be
> > writ
On Tue, Apr 28, 2020 at 09:48:03PM +, Martin Wilck wrote:
> On Fri, 2020-04-03 at 01:50 -0500, Benjamin Marzinski wrote:
> > This patchset is for a new library that programs can use to determine
> > if a device belongs to multipath. The primary user that this is
> >
On Tue, Apr 28, 2020 at 09:42:52PM +, Martin Wilck wrote:
> On Fri, 2020-04-03 at 01:50 -0500, Benjamin Marzinski wrote:
> > +int mpath_get_mode(void)
> > +{
> > + int mode;
> > + struct config *conf;
> > +
> > + conf = load_config(DEFAULT_CONF
On Fri, Apr 03, 2020 at 09:14:58AM +, Martin Wilck wrote:
> Hi Ben,
>
> On Tue, 2020-03-31 at 12:31 -0500, Benjamin Marzinski wrote:
> > On Tue, Mar 31, 2020 at 03:38:25PM +, Martin Wilck wrote:
> > > On Mon, 2020-03-30 at 21:00 -0500, Benjamin Marzinski wrote:
>
quot; events with DM_ACTIVATION=="1".
>
> 11-dm-mpath.rules resets DM_ACTIVATION to 0 if nothing should change in upper
> layers. In this case importing DM_SUBSYSTEM_UDEV_FLAG1 is correct, too. kpartx
> will not be called anyway, because 11-dm-mpath.rules also sets
> MPATH_UNCH
set up properly
> by device-mapper before. This flag should be respected by kpartx.
>
Reviewed-by: Benjamin Marzinski
> Signed-off-by: Martin Wilck
> ---
> kpartx/kpartx.rules | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/kpartx/kpartx.rules b/kpartx/kpartx.
sysfs_is_multipathed reads the wwid of the dm device holding a path to
check if its a multipath device. Add code to optinally set pp->wwid to
that wwid. This will be used by a future patch.
Signed-off-by: Benjamin Marzinski
---
libmultipath/sysfs.c | 24 +++-
libmultip
.
Also make dm_prereq a global function.
Reviewed-by: Martin Wilck
Signed-off-by: Benjamin Marzinski
---
libmultipath/devmapper.c | 17 +
libmultipath/devmapper.h | 3 ++-
2 files changed, 15 insertions(+), 5 deletions(-)
diff --git a/libmultipath/devmapper.c b/libmultipath
with this difference is the
responsiblity of the caller of the mpathvalid library. mpath_get_mode(),
will let it know what the configured find_multipaths mode is.
Benjamin Marzinski (3):
libmultipath: make libmp_dm_init optional
libmultipath: make sysfs_is_multipathed able to return wwid
multipath: add l
g. It also uses a statically
compiled version of libmultipath, both to keep that library from
polluting the namespace of the caller, and to avoid the caller needing
to set up the variables and functions (like logsink, and
get_multipath_config) that it expects.
Signed-off-by: Benjamin Marzinski
---
On Tue, Mar 31, 2020 at 03:38:25PM +, Martin Wilck wrote:
> On Mon, 2020-03-30 at 21:00 -0500, Benjamin Marzinski wrote:
> > This library allows other programs to check if a path should be
> > claimed
> > by multipath. Currently, it only includes one function,
> > m
On Tue, Mar 31, 2020 at 01:06:01PM +, Martin Wilck wrote:
> On Mon, 2020-03-30 at 21:00 -0500, Benjamin Marzinski wrote:
> > @@ -342,9 +342,25 @@ bool sysfs_is_multipathed(const struct path *pp)
> > if (nr == sizeof(uuid) && !memcmp(uuid, &q
lso uses a statically
compiled version of libmultipath, both to keep that library from
polluting the namespace of the caller, and to avoid the caller needing
to set up the variables and functions (like logsink, and
get_multipath_config) that it expects.
Signed-off-by: Ben
a path's WWID, without ever needing to
open the path.
Benjamin Marzinski (3):
libmultipath: make libmp_dm_init optional
libmultipath: make sysfs_is_multipathed able to return wwid
multipath: add libmpathvalid library
Makefile| 1 +
Makefile.inc
.
Also make dm_prereq a global function.
Signed-off-by: Benjamin Marzinski
---
libmultipath/devmapper.c | 17 +
libmultipath/devmapper.h | 3 ++-
2 files changed, 15 insertions(+), 5 deletions(-)
diff --git a/libmultipath/devmapper.c b/libmultipath/devmapper.c
index 13a1cf53
sysfs_is_multipathed reads the wwid of the dm device holding a path to
check if its a multipath device. Add code to optinally set pp->wwid to
that wwid. This will be used by a future patch.
Signed-off-by: Benjamin Marzinski
---
libmultipath/sysfs.c | 22 +++---
libmultip
ing kpartx when the first valid
path appeared, even though the dm activation rules get run in this case.
This changes 11-dm-mpath.rules to run kpartx when a device goes from no
usable paths to having usable paths.
Reviewed-by: Martin Wilck
Signed-off-by: Benjamin Marzinski
---
libmultipath/configur
,
and update the version requirements if so.
Signed-off-by: Benjamin Marzinski
---
libmultipath/Makefile| 4
libmultipath/devmapper.c | 7 ++-
2 files changed, 10 insertions(+), 1 deletion(-)
diff --git a/libmultipath/Makefile b/libmultipath/Makefile
index e5651e49..ad690a49 100644
in
this function [-Werror=maybe-uninitialized]
bool is_queueing;
^~~
so, assign a value to make it happy.
Reviewed-by: Martin Wilck
Signed-off-by: Benjamin Marzinski
---
libmultipath/structs_vec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libmultipath
On Wed, Mar 25, 2020 at 03:52:55PM -0500, Benjamin Marzinski wrote:
> On Wed, Mar 25, 2020 at 03:16:50PM +, Martin Wilck wrote:
> > On Tue, 2020-03-24 at 16:03 -0500, Benjamin Marzinski wrote:
> >
> > AFAICS, this function has been in libdm since 1.02.111. We suppor
On Wed, Mar 25, 2020 at 03:16:50PM +, Martin Wilck wrote:
> On Tue, 2020-03-24 at 16:03 -0500, Benjamin Marzinski wrote:
> > If dm_hold_control_open() isn't set, when dm_lib_release() is called,
> > it
> > will close the control fd. The control fd will get re-o
in
this function [-Werror=maybe-uninitialized]
bool is_queueing;
^~~
so, assign a value to make it happy.
Signed-off-by: Benjamin Marzinski
---
libmultipath/structs_vec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libmultipath/structs_vec.c b/libmultipath
ing kpartx when the first valid
path appeared, even though the dm activation rules get run in this case.
This changes 11-dm-mpath.rules to run kpartx when a device goes from no
usable paths to having usable paths.
Signed-off-by: Benjamin Marzinski
---
libmultipath/configure.c| 6 --
multi
happen with the vecs lock held, this wasn't too
noticeable, but there is code that calls dm_task_run() without the
vecs lock held, notably the dmevent waiter code.
Signed-off-by: Benjamin Marzinski
---
libmultipath/devmapper.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/libmultipath
On Sun, Mar 15, 2020 at 10:05:21PM +0100, mwi...@suse.com wrote:
> From: Martin Wilck
>
> Make sure that data structures used for PERSISTENT RESERVE IN/OUT
> fit into 8k buffers.
>
> This patch breaks the libmpathpersist ABI, because the offsets of
> struct print_fulldescr_list.descriptors and
On Sun, Mar 15, 2020 at 10:05:19PM +0100, mwi...@suse.com wrote:
> From: Martin Wilck
>
> This limits the PERSISTENT RESERVE OUT data size to max. 8192 bytes.
>
Reviewed-by: Benjamin Marzinski
> Signed-off-by: Martin Wilck
> ---
> libmpathpersist/
on't really see a way for users to
hurt themselves because of this change, without making some pretty odd
assumptions. Am I missing something?
Reviewed-by: Benjamin Marzinski
> Signed-off-by: Martin Wilck
> ---
> libmpathpersist/mpath_persist.h | 15 +++
> 1 file chang
On Sat, Mar 07, 2020 at 12:06:04AM +0100, mwi...@suse.com wrote:
> From: Martin Wilck
>
> This changes no semantics, but it will allow changing the size of
> prin_readfd.private_buffer in a follow-up patch.
>
Reviewed-by: Benjamin Marzinski
> Signed-of
On Sat, Mar 07, 2020 at 12:06:03AM +0100, mwi...@suse.com wrote:
> From: Martin Wilck
>
> This limits the PERSISTENT RESERVE OUT data size to max. 8192 bytes.
>
> Signed-off-by: Martin Wilck
> ---
> libmpathpersist/mpath_pr_ioctl.c | 26 --
> 1 file changed, 24
the SCSI specs that
> the allocation lengh may not exceed 8k, an 8k limit is also enforced
> by sg_persist(8), and actually by mpathpersist itself for the
> --allocation-length option, but not for the auto-determined length.
>
> Fix that.
>
Reviewed-by: Benjamin Marzins
On Mon, Mar 02, 2020 at 11:20:21PM +0100, mwi...@suse.com wrote:
> From: Martin Wilck
>
> Hi Christophe, hi Ben,
>
> as announced in my previous post, here's a set of minor fixups for the
> unit tests. The README.md should have been created long ago. My main
> issue is that I'd prefer not to
On Mon, Mar 02, 2020 at 11:19:08AM +0100, Christophe Varoqui wrote:
> Hi ben, Martin,
>
> I finally catched up with your changes from october till now.
> Please review I did not mess up the merges, then i'll commit a version bump.
Sorry for the delay. Everything looks fine on my end.
-Ben
>
>
On Wed, Feb 19, 2020 at 05:17:48PM +0100, Martin Wilck wrote:
> multipath-tools has support for "foreign" libraries in multipath-tools
> since 0.8.0, and support for enabling/disabling them at runtime since
> 0.8.3.
>
> The only foreign library that exists is "nvme" (for native NVMe
> multipath),
which is run when the checker is reset or unloaded.
Changing this broke a number of tests, so the unit tests have been
updated as well.
Reviewed-by: Martin Wilck
Signed-off-by: Benjamin Marzinski
---
libmultipath/checkers.c | 26 ++---
libmultipath/checkers.h | 2
Instead of always allocating space in the path structure for vpd_data,
only allocte it when necessary.
Also, fix comments on vpd tests
Reviewed-by: Martin Wilck
Signed-off-by: Benjamin Marzinski
---
libmultipath/discovery.c | 17 +++--
libmultipath/print.c | 4
that in will virtually always set the path to pending on the
check when the IO is issued.
Reviewed-by: Martin Wilck
Signed-off-by: Benjamin Marzinski
---
libmultipath/checkers/directio.c | 13 -
tests/directio.c | 1 -
2 files changed, 4 insertions(+), 10 deletions
get_events() used a NULL or a zeroed timeout to mean "don't wait".
io_getevents() uses a NULL timeout to mean "wait forever" and a
zeroed timeout to mean "don't wait". Make get_events() work like
io_getevents().
Reviewed-by: Martin Wilck
Signed-off-by: Benjami
Signed-off-by: Benjamin Marzinski
---
kpartx/dasd.c| 6 +++---
libmultipath/print.c | 16
multipath/main.c | 2 +-
3 files changed, 12 insertions(+), 12 deletions(-)
diff --git a/kpartx/dasd.c b/kpartx/dasd.c
index 1486ccaa..14b9d3aa 100644
--- a/kpartx/dasd.c
These patches resolve various minor issues that Martin had with my
previous patch set.
Changes in v2:
0001: now uses memcmp() instead of strncmp(), and safe_sprintf()
instead of strlcpy(), as suggested by Martin Wilck.
Benjamin Marzinski (5):
multipath: fix issues found by compiling
On Wed, Feb 19, 2020 at 10:28:31AM +0100, Martin Wilck wrote:
> On Wed, 2020-02-19 at 00:54 -0600, Benjamin Marzinski wrote:
> > Signed-off-by: Benjamin Marzinski
> > ---
> > kpartx/dasd.c| 6 +++---
> > libmultipath/print.c | 3 ++-
> > multipath/main.
get_events() used a NULL or a zeroed timeout to mean "don't wait".
io_getevents() uses a NULL timeout to mean "wait forever" and a
zeroed timeout to mean "don't wait". Make get_events() work like
io_getevents().
Signed-off-by: Benjamin Marzinski
---
libmult
that in will virtually always set the path to pending on the
check when the IO is issued.
Signed-off-by: Benjamin Marzinski
---
libmultipath/checkers/directio.c | 13 -
tests/directio.c | 1 -
2 files changed, 4 insertions(+), 10 deletions(-)
diff --git a/libmultipath
Signed-off-by: Benjamin Marzinski
---
kpartx/dasd.c| 6 +++---
libmultipath/print.c | 3 ++-
multipath/main.c | 2 +-
3 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/kpartx/dasd.c b/kpartx/dasd.c
index 1486ccaa..57305825 100644
--- a/kpartx/dasd.c
+++ b/kpartx/dasd.c
Instead of always allocating space in the path structure for vpd_data,
only allocte it when necessary.
Also, fix comments on vpd tests
Signed-off-by: Benjamin Marzinski
---
libmultipath/discovery.c | 17 +++--
libmultipath/print.c | 4 ++--
libmultipath/structs.c | 3
which is run when the checker is reset or unloaded.
Changing this broke a number of tests, so the unit tests have been
updated as well.
Signed-off-by: Benjamin Marzinski
---
libmultipath/checkers.c | 26 ++---
libmultipath/checkers.h | 2 +-
libmultipath/checkers/directio.c
These patches resolve various minor issues that Martin had with my
previous patch set.
Benjamin Marzinski (5):
multipath: fix issues found by compiling with gcc 10
libmultipath: turn pp->vpd_data into a pointer
libmultipath: change loading and resetting in directio
libmultipath: cha
There is now a file in tests called directio_test_dev. If the commented
out test device line is uncommented and set to a device, it can be used
to test the directio checker on that device, instead of faking the
device.
Signed-off-by: Benjamin Marzinski
---
tests/Makefile | 16
If the persistent in command fails, the response buffer must be freed.
Found by Coverity
Reviewed-by: Martin Wilck
Signed-off-by: Benjamin Marzinski
---
mpathpersist/main.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/mpathpersist/main.c b/mpathpersist/main.c
index 56761668..28bfe410
From: Martin Wilck
Signed-off-by: Benjamin Marzinski
---
libmultipath/discovery.c | 2 +-
libmultipath/propsel.c | 2 +-
libmultipath/propsel.h | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/libmultipath/discovery.c b/libmultipath/discovery.c
index 33a313a2
Signed-off-by: Benjamin Marzinski
---
multipathd/main.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/multipathd/main.c b/multipathd/main.c
index a590ba8d..e607acf3 100644
--- a/multipathd/main.c
+++ b/multipathd/main.c
@@ -872,9 +872,8 @@ uev_add_path (struct
in the devices section of multipath.conf with the
vpd_vendor parameter. Currently, the only devices that use this are HPE
3PAR arrays, to return the Volume Name.
Signed-off-by: Benjamin Marzinski
---
libmultipath/config.c | 2 ++
libmultipath/config.h | 1 +
libmultipath/dict.c
sts, then
no checker can use it. Since no checker is using it, there is no checker
to clear out the orphaned requests. In this (likely rare) case, the
last checker from that group to be freed and leave behind an orphaned
request will call io_destroy() and remove the group.
Signed-off-by: Benjamin Marzin
, modify the tests to verify the new behavior.
Signed-off-by: Benjamin Marzinski
---
libmultipath/discovery.c | 12 +++
tests/vpd.c | 77
2 files changed, 52 insertions(+), 37 deletions(-)
diff --git a/libmultipath/discovery.c b/libmultipath
Signed-off-by: Benjamin Marzinski
---
multipathd/uxlsnr.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/multipathd/uxlsnr.c b/multipathd/uxlsnr.c
index 020d7a9b..1c5ce9d2 100644
--- a/multipathd/uxlsnr.c
+++ b/multipathd/uxlsnr.c
@@ -40,7 +40,7 @@
#include
. They are designed to setup, reset, and destroy
global state that all checkers of this class use. They will be used
in future commits.
Reviewed-by: Martin Wilck
Signed-off-by: Benjamin Marzinski
---
libmultipath/checkers.c | 29 -
libmultipath/checkers.h | 1 +
multipathd
Reviewed-by: Martin Wilck
Signed-off-by: Benjamin Marzinski
---
libmultipath/unaligned.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/libmultipath/unaligned.h b/libmultipath/unaligned.h
index 68c07742..b9eaa7cb 100644
--- a/libmultipath/unaligned.h
+++ b/libmultipath
set that checker class to async (assuming
force_sync wasn't set). After that, no matter when a checker from that
class was called, it would always run in async mode. Multipathd doesn't
need to run checkers in sync mode at all, so don't.
Reviewed-by: Martin Wilck
Signed-off-by: Benjamin Marzinski
Reviewed-by: Martin Wilck
Signed-off-by: Benjamin Marzinski
---
libmultipath/structs.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/libmultipath/structs.h b/libmultipath/structs.h
index c978fb8a..250623af 100644
--- a/libmultipath/structs.h
+++ b/libmultipath/structs.h
@@ -273,7 +273,6
This tells multipath how it should decode vendor specific pages. It will
be used by a future patch.
Reviewed-by: Martin Wilck
Signed-off-by: Benjamin Marzinski
---
libmultipath/discovery.c | 4 ++--
libmultipath/discovery.h | 2 +-
libmultipath/propsel.c | 2 +-
tests/vpd.c
repeatedly polling for files that aren't likely to appear.
Signed-off-by: Benjamin Marzinski
---
libmultipath/config.h | 1 +
multipathd/main.c | 1 +
multipathd/uxlsnr.c | 138 --
3 files changed, 134 insertions(+), 6 deletions(-)
diff --git
he directio tests on an actual device
Benjamin Marzinski (16):
multipathd: warn when configuration has been changed.
multipathd: staticify uxlsnr variables/functions
Fix leak in mpathpersist
libmultipath: remove unused path->prio_args
libmultipath: constify get_unaligned_be*
libmultip
talking to the device, multipath
shouldn't completely skip attempting to get the priority of these paths,
but it should set a small timeout, so that it isn't hanging in the
case where it needs to contact a device through a failed path.
Signed-off-by: Benjamin Marzinski
---
libmultipath/discovery.c
1001 - 1100 of 2020 matches
Mail list logo
