Re: [dm-devel] [PATCH v1 1/1] dm integrity: Use %*ph for printing hexdump of a small buffer

2023-06-14 Thread David Laight
From: Andy Shevchenko > Sent: 12 June 2023 22:48 > > The kernel already has a helper to print a hexdump of a small > buffer via pointer extension. Use that instead of open coded > variant. > > In long term it helps to kill pr_cont() or at least narrow down > its use. > > Note, the format is

Re: [dm-devel] [PATCH] hex2bin: make the function hex_to_bin constant-time

2022-04-27 Thread David Laight
From: Linus Torvalds > Sent: 24 April 2022 22:42 > > On Sun, Apr 24, 2022 at 2:37 PM Linus Torvalds > wrote: > > > > Finally, for the same reason - please don't use ">> 8". Because I do > > not believe that bit 8 is well-defined in your arithmetic. The *sign* > > bit will be, but I'm not

Re: [dm-devel] [PATCH] hex2bin: make the function hex_to_bin constant-time

2022-04-27 Thread David Laight
From: Mikulas Patocka > Sent: 25 April 2022 12:04 > > On Mon, 25 Apr 2022, David Laight wrote: > > > From: Linus Torvalds > > > Sent: 24 April 2022 22:42 > > > > > > On Sun, Apr 24, 2022 at 2:37 PM Linus Torvalds > > > wrote: > > >

Re: [dm-devel] [RFC PATCH v5 0/4] add simple copy support

2021-02-22 Thread David Laight
From: SelvaKumar S > Sent: 19 February 2021 12:45 > > This patchset tries to add support for TP4065a ("Simple Copy Command"), > v2020.05.04 ("Ratified") > > The Specification can be found in following link. > https://nvmexpress.org/wp-content/uploads/NVM-Express-1.4-Ratified-TPs-1.zip > >

Re: [dm-devel] [PATCH] x86: introduce memcpy_flushcache_clflushopt

2020-04-20 Thread David Laight
From: Mikulas Patocka > Sent: 18 April 2020 16:21 > > On Sat, 18 Apr 2020, David Laight wrote: > > > From: Mikulas Patocka > > > Sent: 17 April 2020 13:47 > > ... > > > I

Re: [dm-devel] [PATCH] x86: introduce memcpy_flushcache_clflushopt

2020-04-20 Thread David Laight
From: Mikulas Patocka > Sent: 17 April 2020 13:47 ... > Index: linux-2.6/drivers/md/dm-writecache.c > === > --- linux-2.6.orig/drivers/md/dm-writecache.c 2020-04-17 14:06:35.13000 > +0200 > +++

RE: [PATCH] sched: make struct task_struct::state 32-bit

2019-09-04 Thread David Laight
From: Alexey Dobriyan > Sent: 03 September 2019 19:19 ... > > How did you come up with this changeset, did you pickaxe for some regexp? > > No, manually, backtracking up to the call chain. > Maybe I missed a few places. Renaming the structure field and getting the compiler to find all the uses