Re: [dm-devel] [PATCH 07/14] btrfs: rename bitmap_set_bits() -> btrfs_bitmap_set_bits()

2023-10-10 Thread David Sterba
d the prefix to exclude such possible conflict. > > Reviewed-by: Przemek Kitszel > Signed-off-by: Alexander Lobakin Acked-by: David Sterba We don't have any other code pending that would potentially collide with this change so I don't care when and via which tree this gets merged. I can

Re: [dm-devel] [PATCH 16/31] block: use the holder as indication for exclusive opens

2023-06-08 Thread David Sterba
drivers/target/target_core_pscsi.c | 8 +++--- For > fs/btrfs/dev-replace.c | 6 ++--- > fs/btrfs/ioctl.c| 12 - > fs/btrfs/volumes.c | 28 ++--- > fs/btrfs/volumes.h | 6 ++--- Acked-by: D

Re: [dm-devel] [PATCH 15/31] btrfs: don't pass a holder for non-exclusive blkdev_get_by_path

2023-06-08 Thread David Sterba
. Please add "Exclusive mode for device scanning is not used since 50d281fc434c ("btrfs: scan device in non-exclusive mode")." Acked-by: David Sterba -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH v2 00/19] bio: check return values of bio_add_page

2023-03-30 Thread David Sterba
On Thu, Mar 30, 2023 at 04:41:58PM +, Johannes Thumshirn wrote: > On 30.03.23 17:52, David Sterba wrote: > > On Thu, Mar 30, 2023 at 03:43:42AM -0700, Johannes Thumshirn wrote: > >> We have two functions for adding a page to a bio, __bio_add_page() which is > >>

Re: [dm-devel] [PATCH v2 00/19] bio: check return values of bio_add_page

2023-03-30 Thread David Sterba
On Thu, Mar 30, 2023 at 03:43:42AM -0700, Johannes Thumshirn wrote: > We have two functions for adding a page to a bio, __bio_add_page() which is > used to add a single page to a freshly created bio and bio_add_page() which is > used to add a page to an existing bio. > > While __bio_add_page() is

Re: [dm-devel] [PATCH v8 07/11] dm-zoned: ensure only power of 2 zone sizes are allowed

2022-07-28 Thread David Sterba
On Wed, Jul 27, 2022 at 06:22:41PM +0200, Pankaj Raghav wrote: > --- a/drivers/md/dm-zoned-target.c > +++ b/drivers/md/dm-zoned-target.c > @@ -792,6 +792,10 @@ static int dmz_fixup_devices(struct dm_target *ti) > return -EINVAL; > } >

Re: [dm-devel] [PATCH v4 00/13] support non power of 2 zoned devices

2022-05-20 Thread David Sterba
On Fri, May 20, 2022 at 11:30:09AM +0200, Pankaj Raghav wrote: > On 5/20/22 08:41, Damien Le Moal wrote: > >> Note that for F2FS there is no blocker. Jaegeuk picked the initial > >> patches, and he agreed to add native support. > > > > And until that is done, f2fs will not work with these new

Re: [dm-devel] [PATCH v4 07/13] btrfs: zoned: use generic btrfs zone helpers to support npo2 zoned devices

2022-05-18 Thread David Sterba
On Wed, May 18, 2022 at 11:40:22AM +0200, Pankaj Raghav wrote: > On 2022-05-17 14:30, David Sterba wrote: > > On Mon, May 16, 2022 at 06:54:10PM +0200, Pankaj Raghav wrote: > >> @@ -1108,14 +1101,14 @@ int btrfs_reset_device_zone(struct btrfs_device > >> *devi

Re: [dm-devel] [PATCH v4 08/13] btrfs:zoned: make sb for npo2 zone devices align with sb log offsets

2022-05-17 Thread David Sterba
On Mon, May 16, 2022 at 06:54:11PM +0200, Pankaj Raghav wrote: > Superblocks for zoned devices are fixed as 2 zones at 0, 512GB and 4TB. > These are fixed at these locations so that recovery tools can reliably > retrieve the superblocks even if one of the mirror gets corrupted. > > power of 2

Re: [dm-devel] [PATCH v4 07/13] btrfs: zoned: use generic btrfs zone helpers to support npo2 zoned devices

2022-05-17 Thread David Sterba
On Mon, May 16, 2022 at 06:54:10PM +0200, Pankaj Raghav wrote: > Add helpers to calculate alignment, round up and round down > for zoned devices. These helpers encapsulates the necessary handling for > power_of_2 and non-power_of_2 zone sizes. Optimized calculations are > performed for zone sizes

Re: [dm-devel] [PATCH v4 06/13] btrfs: zoned: Make sb_zone_number function non power of 2 compatible

2022-05-17 Thread David Sterba
On Tue, May 17, 2022 at 06:53:40AM +, Johannes Thumshirn wrote: > On 16/05/2022 18:54, Pankaj Raghav wrote: > > /* Cache the sb zone number */ > > for (i = 0; i < BTRFS_SUPER_MIRROR_MAX; ++i) { > > zone_info->sb_zone_location[i] = > > -

Re: [dm-devel] [PATCH v4 05/13] btrfs: zoned: Cache superblock location in btrfs_zoned_device_info

2022-05-16 Thread David Sterba
On Mon, May 16, 2022 at 06:54:08PM +0200, Pankaj Raghav wrote: > Instead of calculating the superblock location every time, cache the > superblock zone location in btrfs_zoned_device_info struct and use it to > locate the zone index. > > The functions such as btrfs_sb_log_location_bdev() and >

Re: [dm-devel] [PATCH v3 11/11] dm-zoned: ensure only power of 2 zone sizes are allowed

2022-05-11 Thread David Sterba
On Wed, May 11, 2022 at 04:39:17PM +0200, Pankaj Raghav wrote: > Hi David, > > On 2022-05-09 20:54, David Sterba wrote:>> diff --git > a/drivers/md/dm-zone.c b/drivers/md/dm-zone.c > >> index 3e7b1fe15..27dc4ddf2 100644 > >> --- a/drivers/md/dm-zo

Re: [dm-devel] [PATCH v3 11/11] dm-zoned: ensure only power of 2 zone sizes are allowed

2022-05-09 Thread David Sterba
On Fri, May 06, 2022 at 10:11:05AM +0200, Pankaj Raghav wrote: > From: Luis Chamberlain > > Today dm-zoned relies on the assumption that you have a zone size > with a power of 2. Even though the block layer today enforces this > requirement, these devices do exist and so provide a stop-gap

Re: [dm-devel] [PATCH v3 00/11] support non power of 2 zoned devices

2022-05-06 Thread David Sterba
On Fri, May 06, 2022 at 10:10:54AM +0200, Pankaj Raghav wrote: > - Open issue: > * btrfs superblock location for zoned devices is expected to be in 0, > 512GB(mirror) and 4TB(mirror) in the device. Zoned devices with po2 > zone size will naturally align with these superblock location but non >

Re: [dm-devel] [PATCH 00/16] support non power of 2 zoned devices

2022-05-04 Thread David Sterba
gnment constraint for zoned > devices` makes sure the zone size is BTRFS_STRIPE_LEN aligned (64K). So > even the npo2 zoned device should be aligned to `fs_info->sectorsize`, > which is typically 4k. > > This was one of the comment that came from David Sterba: > https://lore.k

Re: [dm-devel] [PATCH 27/27] direct-io: remove random prefetches

2022-04-20 Thread David Sterba
added the prefetch, 65dd2aa90aa1 ("dio: optimize cache misses in the submission path") and also remove #include as there are no more uses of prefetch in the file. With that Reviewed-by: David Sterba -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH 25/27] block: add a bdev_discard_granularity helper

2022-04-12 Thread David Sterba
tersen > Acked-by: Christoph Böhmwalder [btrfs] This is for drbd > Acked-by: Ryusuke Konishi > Acked-by: David Sterba [btrfs] -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH 08/27] btrfs: use bdev_max_active_zones instead of open coding it

2022-04-12 Thread David Sterba
On Sat, Apr 09, 2022 at 06:50:24AM +0200, Christoph Hellwig wrote: > Signed-off-by: Christoph Hellwig > Reviewed-by: Johannes Thumshirn Acked-by: David Sterba -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH 24/27] block: remove QUEUE_FLAG_DISCARD

2022-04-12 Thread David Sterba
-- > drivers/mmc/core/queue.c| 1 - > drivers/mtd/mtd_blkdevs.c | 1 - > drivers/nvme/host/core.c| 6 ++ > drivers/s390/block/dasd_fba.c | 1 - > drivers/scsi/sd.c | 2 -- > drivers/target/target_core_device.c | 2

Re: [dm-devel] [PATCH 23/27] block: add a bdev_max_discard_sectors helper

2022-04-11 Thread David Sterba
e_device.c | 8 +++- For > fs/btrfs/extent-tree.c | 4 ++-- > fs/btrfs/ioctl.c| 2 +- Acked-by: David Sterba -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH 11/27] block: add a bdev_write_cache helper

2022-04-11 Thread David Sterba
bd-srv.c | 2 +- > drivers/block/xen-blkback/xenbus.c | 2 +- > drivers/target/target_core_iblock.c | 8 ++-- For > fs/btrfs/disk-io.c | 3 +-- Acked-by: David Sterba -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH 07/27] btrfs: use bdev_max_active_zones instead of open coding it

2022-04-11 Thread David Sterba
On Wed, Apr 06, 2022 at 08:04:56AM +0200, Christoph Hellwig wrote: > Signed-off-by: Christoph Hellwig As it's a standalone patch I can take it (possibly with other similar prep btrfs patches) in current development cycle to relieve the inter-tree dependencies. -- dm-devel mailing list

Re: [dm-devel] [PATCH 26/27] block: uncouple REQ_OP_SECURE_ERASE from REQ_OP_DISCARD

2022-04-11 Thread David Sterba
vers/md/raid5-cache.c| 6 +-- > drivers/mmc/core/queue.c| 2 +- > drivers/nvme/target/io-cmd-bdev.c | 2 +- > drivers/target/target_core_file.c | 2 +- > drivers/target/target_core_iblock.c | 2 +- For > fs/btrfs/extent-tree.c

Re: [dm-devel] [PATCH 24/27] block: add a bdev_discard_granularity helper

2022-04-11 Thread David Sterba
| 5 ++--- > drivers/block/drbd/drbd_nl.c| 9 + > drivers/block/drbd/drbd_receiver.c | 3 +-- > drivers/block/loop.c| 2 +- > drivers/target/target_core_device.c | 3 +-- For > fs/btrfs/ioctl.c| 12 ++++ Ack

Re: [dm-devel] [PATCH 10/27] block: add a bdev_nonrot helper

2022-04-11 Thread David Sterba
| 2 +- > drivers/target/target_core_file.c | 3 +-- > drivers/target/target_core_iblock.c | 2 +- For > fs/btrfs/volumes.c | 4 ++-- Acked-by: David Sterba -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH 1/5] btrfs: simplify ->flush_bio handling

2022-03-01 Thread David Sterba
lumes.h > @@ -117,7 +117,7 @@ struct btrfs_device { > u64 commit_bytes_used; > > /* for sending down flush barriers */ > - struct bio *flush_bio; Please add this comment to the struct member declaration: /* Bio used for flushing device barriers */ > +

Re: [dm-devel] [PATCH 12/30] btrfs: use bdev_nr_bytes instead of open coding it

2021-10-18 Thread David Sterba
On Fri, Oct 15, 2021 at 03:26:25PM +0200, Christoph Hellwig wrote: > Use the proper helper to read the block device size. > > Signed-off-by: Christoph Hellwig > Reviewed-by: Anand Jain > Reviewed-by: Chaitanya Kulkarni Acked-by: David Sterba -- dm-devel mailing list dm-d

Re: [dm-devel] [PATCH 3/4] btrfs: zoned: fail mount if the device does not support zone append

2021-04-20 Thread David Sterba
On Mon, Apr 19, 2021 at 09:46:36AM +, Damien Le Moal wrote: > On 2021/04/19 18:41, h...@infradead.org wrote: > > On Mon, Apr 19, 2021 at 09:35:37AM +, Damien Le Moal wrote: > >> This is only to avoid someone from running zoned-btrfs on top of dm-crypt. > >> Without this patch, mount will

Re: [dm-devel] [PATCH 3/4] btrfs: zoned: fail mount if the device does not support zone append

2021-04-19 Thread David Sterba
On Fri, Apr 16, 2021 at 12:05:27PM +0900, Damien Le Moal wrote: > From: Johannes Thumshirn > > For zoned btrfs, zone append is mandatory to write to a sequential write > only zone, otherwise parallel writes to the same zone could result in > unaligned write errors. > > If a zoned block device

Re: [dm-devel] [PATCH 12/44] block: add a bdev_kobj helper

2020-11-29 Thread David Sterba
; Acked-by: Tejun Heo > Acked-by: Coly Li [bcache] > --- > drivers/md/bcache/super.c | 7 ++- > drivers/md/md.c | 4 +--- > fs/block_dev.c| 6 +++--- For btrfs > fs/btrfs/sysfs.c | 15 +++ Acked-by: David Sterba -- dm

Re: [dm-devel] [PATCH 07/12] bdi: remove BDI_CAP_CGROUP_WRITEBACK

2020-09-17 Thread David Sterba
k > layer, which always supports cgroup writeback. > > Signed-off-by: Christoph Hellwig > Reviewed-by: Johannes Thumshirn Acked-by: David Sterba -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH 04/14] bdi: initialize ->ra_pages in bdi_init

2020-07-23 Thread David Sterba
On Wed, Jul 22, 2020 at 08:25:42AM +0200, Christoph Hellwig wrote: > Set up a readahead size by default, as very few users have a good > reason to change it. > > Signed-off-by: Christoph Hellwig > --- For the btrfs bits > fs/btrfs/disk-io.c | 1 - Acked-by: David St

Re: [dm-devel] [PATCH 4/4] writeback: remove bdi->congested_fn

2020-07-01 Thread David Sterba
the btrfs bits > fs/btrfs/disk-io.c | 23 - Acked-by: David Sterba -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] dedicated error codes for the block layer V2

2017-05-30 Thread David Sterba
btrfs bits in patch 13 Acked-by: David Sterba <dste...@suse.com> -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH 05/13] fs: remove the unused error argument to dio_end_io()

2017-05-30 Thread David Sterba
On Fri, May 26, 2017 at 11:56:12AM +0300, Christoph Hellwig wrote: > Signed-off-by: Christoph Hellwig <h...@lst.de> > Reviewed-by: Bart Van Assche <bart.vanass...@sandisk.com> For the btrfs bits Acked-by: David Sterba <dste...@suse.com> -- dm-devel mailing list d

Re: [dm-devel] dedicated error codes for the block layer

2017-05-18 Thread David Sterba
On Thu, May 18, 2017 at 03:17:57PM +0200, Christoph Hellwig wrote: > This series introduces a new blk_status_t error code type for the block > layer so that we can have tigher control and explicit semantics for > block layer errors. > > All but the last three patches are cleanups that lead to the