Re: [dm-devel] [PATCH V3 6/13] input: serio: use time_is_before_jiffies() instead of open coding it

2022-02-15 Thread Dmitry Torokhov
Hi Wang, On Mon, Feb 14, 2022 at 05:55:43PM -0800, Qing Wang wrote: > From: Wang Qing > > Use the helper function time_is_{before,after}_jiffies() to improve > code readability. I applied changes by Danilo Krummrich converting the driver to use ktime_t (see

Re: [dm-devel] [PATCH v4 0/5] bitmap: Introduce alloc/free helpers

2018-08-02 Thread Dmitry Torokhov
On Tue, Jul 24, 2018 at 02:35:53PM +0300, Andy Shevchenko wrote: > On Thu, 2018-07-05 at 00:30 +0300, Andy Shevchenko wrote: > > On Sat, Jun 30, 2018 at 11:17 PM, Andy Shevchenko > > wrote: > > > A lot of code is using allocation of bitmaps using BITS_PER_LONG() > > > macro and > > >

Re: [dm-devel] [PATCH v3 3/5] bitmap: Add bitmap_alloc(), bitmap_zalloc() and bitmap_free()

2018-06-25 Thread Dmitry Torokhov
On Thu, Jun 21, 2018 at 05:13:39AM +0300, Andy Shevchenko wrote: > On Tue, Jun 19, 2018 at 2:10 AM, Andrew Morton > wrote: > > On Mon, 18 Jun 2018 15:01:43 -0700 Dmitry Torokhov > > wrote: > > >> We can't as we end up including bitmap.h (by the way of cpumask.

Re: [dm-devel] [PATCH v2 5/5] Input: evdev - Switch to bitmap_zalloc()

2018-06-21 Thread Dmitry Torokhov
On Wed, Jun 20, 2018 at 11:13:21AM +0300, Yury Norov wrote: > On Tue, Jun 19, 2018 at 11:33:16AM -0700, Dmitry Torokhov wrote: > > External Email > > > > On Sat, Jun 16, 2018 at 12:42:31AM +0300, Yury Norov wrote: > > > Hi Andy, > > > > > >

Re: [dm-devel] [PATCH v2 5/5] Input: evdev - Switch to bitmap_zalloc()

2018-06-20 Thread Dmitry Torokhov
nstead of opaque void *. > > > > Acked-by: Dmitry Torokhov > > Signed-off-by: Andy Shevchenko > > --- > > drivers/input/evdev.c | 16 +++- > > 1 file changed, 7 insertions(+), 9 deletions(-) > > > > diff --git a/drivers/input/evdev.

Re: [dm-devel] [PATCH v3 3/5] bitmap: Add bitmap_alloc(), bitmap_zalloc() and bitmap_free()

2018-06-19 Thread Dmitry Torokhov
On Mon, Jun 18, 2018 at 2:14 PM Andrew Morton wrote: > > On Mon, 18 Jun 2018 16:10:01 +0300 Andy Shevchenko > wrote: > > > A lot of code become ugly because of open coding allocations for bitmaps. > > > > Introduce three helpers to allow users be more clear of intention > > and keep their code