Re: [dm-devel] [PATCH 5.15] dm init: add dm-mod.waitfor to wait for asynchronously probed block devices

2023-07-21 Thread Greg KH
On Fri, Jul 21, 2023 at 02:38:45PM +0800, Mark-PK Tsai wrote: > > On Mon, Jul 17, 2023 at 09:57:28AM +0800, Mark-PK Tsai wrote: > > > > On Sun, Jul 16, 2023, 11:16 AM Greg KH > > > > wrote: > > > > > > > > > On Thu, Jul 13, 2023 at 01:5

Re: [dm-devel] [PATCH 5.15] dm init: add dm-mod.waitfor to wait for asynchronously probed block devices

2023-07-20 Thread Greg KH
On Mon, Jul 17, 2023 at 09:57:28AM +0800, Mark-PK Tsai wrote: > > On Sun, Jul 16, 2023, 11:16 AM Greg KH wrote: > > > > > On Thu, Jul 13, 2023 at 01:58:37PM +0800, Mark-PK Tsai wrote: > > > > From: Peter Korsgaard > > > > > > > > Jus

Re: [dm-devel] [PATCH 5.15] dm init: add dm-mod.waitfor to wait for asynchronously probed block devices

2023-07-16 Thread Greg KH
On Sun, Jul 16, 2023 at 11:36:36AM -0400, Mike Snitzer wrote: > On Sun, Jul 16, 2023, 11:16 AM Greg KH wrote: > > > On Thu, Jul 13, 2023 at 01:58:37PM +0800, Mark-PK Tsai wrote: > > > From: Peter Korsgaard > > > > > > Just calling wait_for_devi

Re: [dm-devel] [PATCH 5.15] dm init: add dm-mod.waitfor to wait for asynchronously probed block devices

2023-07-16 Thread Greg KH
On Thu, Jul 13, 2023 at 01:58:37PM +0800, Mark-PK Tsai wrote: > From: Peter Korsgaard > > Just calling wait_for_device_probe() is not enough to ensure that > asynchronously probed block devices are available (E.G. mmc, usb), so > add a "dm-mod.waitfor=[,..,]" parameter to get > dm-init to explici

Re: [dm-devel] [PATCH stable 5.10 1/3] block: look up holders by bdev

2022-08-01 Thread Greg KH
On Mon, Aug 01, 2022 at 08:04:58PM +0200, Christoph Hellwig wrote: > On Mon, Aug 01, 2022 at 01:19:09PM +0200, Greg KH wrote: > > This is very different from the upstream version, and forces the change > > onto everyone, not just those who had CONFIG_BLOCK_HOLDER_DEPRECATED >

Re: [dm-devel] [PATCH stable 5.10 1/3] block: look up holders by bdev

2022-08-01 Thread Greg KH
On Mon, Aug 01, 2022 at 09:39:30PM +0800, Yu Kuai wrote: > Hi, Greg > > 在 2022/08/01 21:17, Greg KH 写道: > > On Mon, Aug 01, 2022 at 08:25:27PM +0800, Yu Kuai wrote: > > > Hi, Greg > > > > > > 在 2022/08/01 19:19, Greg KH 写道: > > > > O

Re: [dm-devel] [PATCH stable 5.10 1/3] block: look up holders by bdev

2022-08-01 Thread Greg KH
On Mon, Aug 01, 2022 at 08:25:27PM +0800, Yu Kuai wrote: > Hi, Greg > > 在 2022/08/01 19:19, Greg KH 写道: > > On Fri, Jul 29, 2022 at 02:23:54PM +0800, Yu Kuai wrote: > > > From: Christoph Hellwig > > > > > > commit 0dbcfe247f22a6d73302dfa691c48b3c14d31

Re: [dm-devel] [PATCH stable 5.10 1/3] block: look up holders by bdev

2022-08-01 Thread Greg KH
On Fri, Jul 29, 2022 at 02:23:54PM +0800, Yu Kuai wrote: > From: Christoph Hellwig > > commit 0dbcfe247f22a6d73302dfa691c48b3c14d31c4c upstream. > > Invert they way the holder relations are tracked. This very > slightly reduces the memory overhead for partitioned devices. > > Signed-off-by: Ch

Re: [dm-devel] [PATCH 5.10 1/2] block: split bio_kmalloc from bio_alloc_bioset

2022-07-28 Thread Greg KH
On Thu, Jul 28, 2022 at 04:45:20PM +0200, Christoph Hellwig wrote: > On Thu, Jul 28, 2022 at 04:42:35PM +0200, Greg KH wrote: > > > > Link: > > > > https://syzkaller.appspot.com/bug?id=a3416231e37024a75f2b95bd95db0d8ce8132a84 > > > > > > Both now que

Re: [dm-devel] [PATCH 5.10 1/2] block: split bio_kmalloc from bio_alloc_bioset

2022-07-28 Thread Greg KH
On Sat, Jul 23, 2022 at 04:59:42PM +0200, Greg KH wrote: > On Mon, Jul 18, 2022 at 02:12:25PM -0700, Tadeusz Struk wrote: > > From: Christoph Hellwig > > > > From: Christoph Hellwig > > > > Upstream commit: 3175199ab0ac ("block: split bio_kmalloc from &

Re: [dm-devel] [PATCH 5.10 1/2] block: split bio_kmalloc from bio_alloc_bioset

2022-07-23 Thread Greg KH
On Mon, Jul 18, 2022 at 02:12:25PM -0700, Tadeusz Struk wrote: > From: Christoph Hellwig > > From: Christoph Hellwig > > Upstream commit: 3175199ab0ac ("block: split bio_kmalloc from > bio_alloc_bioset") > > This is backport to stable 5.10. It fixes an issue reported by syzbot. > Link: > htt

Re: [dm-devel] [linux-next:master] BUILD REGRESSION 088b9c375534d905a4d337c78db3b3bfbb52c4a0

2022-07-07 Thread Greg KH
On Thu, Jul 07, 2022 at 02:56:34PM +0800, kernel test robot wrote: > tree/branch: > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > branch HEAD: 088b9c375534d905a4d337c78db3b3bfbb52c4a0 Add linux-next > specific files for 20220706 > > Error/Warning reports: > > htt

Re: [dm-devel] [5.4.y PATCH v2] dm: remove special-casing of bio-based immutable singleton target on NVMe

2022-06-23 Thread Greg KH
On Tue, Jun 21, 2022 at 12:35:04PM -0400, Mike Snitzer wrote: > Commit 9c37de297f6590937f95a28bec1b7ac68a38618f upstream. > > There is no benefit to DM special-casing NVMe. Remove all code used to > establish DM_TYPE_NVME_BIO_BASED. > > Also, remove 3 'struct mapped_device *md' variables in __map

Re: [dm-devel] [PATCH 5.4 26/34] dm verity: set DM_TARGET_IMMUTABLE feature flag

2022-06-20 Thread Greg KH
gt; > > On Mon, Jun 13, 2022 at 11:13:21AM +0200, Greg KH wrote: > > > > > On Fri, Jun 10, 2022 at 11:11:00AM -0400, Mike Snitzer wrote: > > > > > > On Fri, Jun 10 2022 at 1:15P -0400, > > > > > > Greg KH wrote: > > > > >

Re: [dm-devel] [PATCH 5.4 26/34] dm verity: set DM_TARGET_IMMUTABLE feature flag

2022-06-13 Thread Greg KH
On Fri, Jun 10, 2022 at 11:11:00AM -0400, Mike Snitzer wrote: > On Fri, Jun 10 2022 at 1:15P -0400, > Greg KH wrote: > > > On Fri, Jun 10, 2022 at 04:22:00AM +, Oleksandr Tymoshenko wrote: > > > I believe this commit introduced a regression in dm verity on systems &g

Re: [dm-devel] [PATCH] dm: fix mempool NULL pointer race when completing IO

2022-04-25 Thread Greg KH
On Mon, Apr 25, 2022 at 08:28:12AM +, Akilesh Kailash wrote: > From: Jiazi Li > > commit d208b89401e073de986dc891037c5a668f5d5d95 upstream. > > This is a backport of the upstream patch to 5.10.y stable branch. Now queued up, thanks. greg k-h -- dm-devel mailing list dm-devel@redhat.com ht

Re: [dm-devel] Intel QAT on A2SDi-8C-HLN4F causes massive data corruption with dm-crypt + xfs

2022-03-02 Thread Greg KH
On Wed, Mar 02, 2022 at 11:49:16AM +, Giovanni Cabiddu wrote: > Hi Greg, > > On Wed, Mar 02, 2022 at 11:29:00AM +0100, Greg KH wrote: > > On Tue, Mar 01, 2022 at 04:11:13PM +1200, Herbert Xu wrote: > > > On Mon, Feb 28, 2022 at 05:12:20PM -0800, Linus Torvalds wr

Re: [dm-devel] Intel QAT on A2SDi-8C-HLN4F causes massive data corruption with dm-crypt + xfs

2022-03-02 Thread Greg KH
On Tue, Mar 01, 2022 at 04:11:13PM +1200, Herbert Xu wrote: > On Mon, Feb 28, 2022 at 05:12:20PM -0800, Linus Torvalds wrote: > > > > It sounds like it was incidental and almost accidental that it fixed > > that thing, and nobody realized it should perhaps be also moved to > > stable. > > Yes thi

Re: [dm-devel] Intel QAT on A2SDi-8C-HLN4F causes massive data corruption with dm-crypt + xfs

2022-02-28 Thread Greg KH
On Mon, Feb 28, 2022 at 08:39:11PM +, Giovanni Cabiddu wrote: > On Mon, Feb 28, 2022 at 11:25:49AM -0800, Linus Torvalds wrote: > > On Mon, Feb 28, 2022 at 12:18 AM Kyle Sanderson wrote: > > > > > > Makes sense - this kernel driver has been destroying users for many > > > years. I'm disappoint

Re: [dm-devel] Kernel 4.14: Using dm-verity with squashfs rootfs - mounting issue

2021-09-08 Thread Greg KH
On Wed, Sep 08, 2021 at 04:57:45PM +0530, Pintu Agarwal wrote: > Hi, > > On Mon, 6 Sept 2021 at 21:58, Pintu Agarwal wrote: > > > On Tue, 31 Aug 2021 at 18:49, Pintu Agarwal wrote: > > > > > > No, but you can backport it easily. Back at > > > > http://lists.infradead.org/pipermail/openwrt-devel

Re: [dm-devel] [PATCH 4/7] block: Introduce a new ioctl for simple copy

2021-08-17 Thread Greg KH
On Tue, Aug 17, 2021 at 03:44:20PM +0530, SelvaKumar S wrote: > From: Nitesh Shetty > > Add new BLKCOPY ioctl that offloads copying of one or more sources ranges > to a destination in the device. COPY ioctl accepts a 'copy_range' > structure that contains destination (in sectors), no of sources a

Re: [dm-devel] [PATCH 2/7] block: Introduce queue limits for copy-offload support

2021-08-17 Thread Greg KH
On Tue, Aug 17, 2021 at 03:44:18PM +0530, SelvaKumar S wrote: > From: Nitesh Shetty > > Add device limits as sysfs entries, > - copy_offload (READ_WRITE) > - max_copy_sectors (READ_ONLY) > - max_copy_ranges_sectors (READ_ONLY) > - max_copy_nr_ranges (READ_ONLY) Yo

Re: [dm-devel] [PATCH 4/7] block: Introduce a new ioctl for simple copy

2021-08-17 Thread Greg KH
On Tue, Aug 17, 2021 at 03:44:20PM +0530, SelvaKumar S wrote: > From: Nitesh Shetty > > Add new BLKCOPY ioctl that offloads copying of one or more sources ranges > to a destination in the device. COPY ioctl accepts a 'copy_range' > structure that contains destination (in sectors), no of sources a

Re: [dm-devel] [PATCH v4 4/6] dm: new ioctl DM_DEV_REMAP_CMD

2021-02-03 Thread Greg KH
On Wed, Feb 03, 2021 at 06:53:56PM +0300, Sergei Shtepa wrote: > --- a/include/uapi/linux/dm-ioctl.h > +++ b/include/uapi/linux/dm-ioctl.h > @@ -214,6 +214,15 @@ struct dm_target_msg { > char message[0]; > }; > > +enum { > + REMAP_START_CMD = 1, > + REMAP_FINISH_CMD, Don't you nee

Re: [dm-devel] merge struct block_device and struct hd_struct

2020-11-18 Thread Greg KH
On Wed, Nov 18, 2020 at 10:23:51AM +0100, Jan Beulich wrote: > On 18.11.2020 10:09, Greg KH wrote: > > On Wed, Nov 18, 2020 at 10:04:04AM +0100, Jan Beulich wrote: > >> On 18.11.2020 09:58, Christoph Hellwig wrote: > >>> On Wed, Nov 18, 2020 at 09:56:11AM +0100, J

Re: [dm-devel] merge struct block_device and struct hd_struct

2020-11-18 Thread Greg KH
On Wed, Nov 18, 2020 at 10:04:04AM +0100, Jan Beulich wrote: > On 18.11.2020 09:58, Christoph Hellwig wrote: > > On Wed, Nov 18, 2020 at 09:56:11AM +0100, Jan Beulich wrote: > >> since this isn't the first series from you recently spamming > >> xen-devel, may I ask that you don't Cc entire series t

Re: [dm-devel] merge struct block_device and struct hd_struct

2020-11-18 Thread Greg KH
On Wed, Nov 18, 2020 at 09:47:40AM +0100, Christoph Hellwig wrote: > Hi Jens, > > this series cleans up our main per-device node data structure by merging > the block_device and hd_struct data structures that have the same scope, > but different life times. The main effect (besides removing lots

Re: [dm-devel] [PATCH 19/20] bcache: remove a superflous lookup_bdev all

2020-11-18 Thread Greg KH
On Wed, Nov 18, 2020 at 04:54:51PM +0800, Coly Li wrote: > On 11/18/20 4:47 PM, Christoph Hellwig wrote: > > Don't bother to call lookup_bdev for just a slightly different error > > message without any functional change. > > > > Signed-off-by: Christoph Hellwig ist > > Hi Christoph, > > NACK. Th

Re: [dm-devel] PROBLEM: 5.9.0-rc6 fails to compile due to 'redefinition of ‘dax_supported’'

2020-09-21 Thread Greg KH
On Mon, Sep 21, 2020 at 11:34:17AM +0530, Naresh Kamboju wrote: > On Mon, 21 Sep 2020 at 06:34, Stuart Little wrote: > > > > I am trying to compile for an x86_64 machine (Intel(R) Core(TM) i7-7500U > > CPU @ 2.70GHz). The config file I am currently using is at > > > > https://termbin.com/xin7 > >

Re: [dm-devel] fixing 4.14-stable's broken DM cache writethrough support [was: Re: [(resend) PATCH v3: {linux-4.14.y} ] dm cache: submit writethrough writes in parallel to origin and cache]

2020-08-20 Thread Greg KH
On Wed, Aug 05, 2020 at 03:34:09PM -0400, Mike Snitzer wrote: > On Wed, Aug 05 2020 at 10:32am -0400, > Greg KH wrote: > > > On Tue, Aug 04, 2020 at 02:20:38PM -0400, Mike Snitzer wrote: > > > On Tue, Aug 04 2020 at 8:47am -0400, > > > Greg KH wrote: > >

Re: fstrim discarding too many or wrong blocks on Linux 5.1, leading to data loss

2019-05-24 Thread Greg KH
On Fri, May 24, 2019 at 05:00:51PM +0200, Andrea Gelmini wrote: > Hi Mike, >I'm doing setup to replicate and test the condition. I see your > patch is already in the 5.2 dev kernel. >I'm going to try with latest git, and see what happens. Anyway, > don't you this it would be good >to ha

Re: [dm-devel] [PATCH] dm-bufio: adjust the reserved buffer for dm-verify-target.

2018-08-07 Thread Greg KH
On Wed, Aug 08, 2018 at 01:07:03PM +0800, xiao jin wrote: > We hit the BUG() report at include/linux/scatterlist.h:144! > The callback is as bellow: > => verity_work > => verity_hash_for_block > => verity_verify_level > => verity_hash > => verity_hash_update > => sg_init_one > => sg_s

Re: [dm-devel] multipath-tools licenses (was Re: [PATCH] multipath-tools: replace FSF address with a www pointer)

2018-04-06 Thread Greg KH
On Fri, Apr 06, 2018 at 06:10:48PM +0200, Xose Vazquez Perez wrote: > On 03/28/2018 05:14 PM, Martin Wilck wrote: > > > On Wed, 2018-03-28 at 00:24 +0200, Xose Vazquez Perez wrote: > > > Multiple licenses are acceptable for multipath-tools, too. Yet we need > > to understand, and clearly communic

Re: [dm-devel] Patch "dm: ensure bio submission follows a depth-first tree walk" has been added to the 4.15-stable tree

2018-03-22 Thread Greg KH
On Thu, Mar 22, 2018 at 09:47:59AM -0400, Mike Snitzer wrote: > On Thu, Mar 22 2018 at 9:06am -0400, > gre...@linuxfoundation.org wrote: > > > > > This is a note to let you know that I've just added the patch titled > > > > dm: ensure bio submission follows a depth-first tree walk > > > >

Re: [dm-devel] [PATCH 00/18] use ARRAY_SIZE macro

2017-10-01 Thread Greg KH
On Sun, Oct 01, 2017 at 08:52:20PM -0400, Jérémy Lefaure wrote: > On Mon, 2 Oct 2017 09:01:31 +1100 > "Tobin C. Harding" wrote: > > > > In order to reduce the size of the To: and Cc: lines, each patch of the > > > series is sent only to the maintainers and lists concerned by the patch. > > > This

Re: [dm-devel] [PATCH 3.18-stable] dm bufio: hide bogus warning

2017-04-27 Thread Greg KH
On Fri, Apr 21, 2017 at 03:41:10PM +0200, Arnd Bergmann wrote: > mips-gcc-5.3 warns about correct code on linux-3.18 and earlier: > > In file included from ../include/linux/blkdev.h:4:0, > from ../drivers/md/dm-bufio.h:12, > from ../drivers/md/dm-bufio.c:9: > ../d

Re: [dm-devel] [PATCH] kobject: support passing in variables for synthetic uevents

2017-04-08 Thread Greg KH
On Wed, Mar 15, 2017 at 04:17:24PM +0100, Peter Rajnoha wrote: > This patch makes it possible to pass additional arguments in addition > to uevent action name when writing /sys/.../uevent attribute. These > additional arguments are then inserted into generated synthetic uevent > as additional envir

Re: [dm-devel] [PATCH 0/9] Generate uevents for all DM events

2016-10-04 Thread Greg KH
On Wed, Oct 05, 2016 at 01:40:05AM +0100, Alasdair G Kergon wrote: > On Tue, Oct 04, 2016 at 04:39:28PM -0700, Andy Grover wrote: > > devicemapper is using uevents for: > > a. dm-verity detected corruption > > b. dm-multipath: path failed or reinstated > > c. dm device renamed > > d. there's also s

Re: [dm-devel] [PATCH 0/9] Generate uevents for all DM events

2016-10-04 Thread Greg KH
On Mon, Oct 03, 2016 at 12:22:51PM -0700, Andy Grover wrote: > Hi Mike and GregKH, > > I want a way to get devicemapper events without using the DM ioctl, > because that requires creating a thread to sleep in the ioctl for each > dm device I want events from. > > It would seem like using uevents

Re: [dm-devel] [PATCH 3/26] staging: rtl8192e: Replace uses of obsolete blkcipher and hash

2016-01-24 Thread Greg KH
On Sun, Jan 24, 2016 at 09:16:26PM +0800, Herbert Xu wrote: > The interfaces blkcipher and hash are obsolete. This patch replaces > them with skcipher and ahash respectively. > > Signed-off-by: Herbert Xu > --- > > drivers/staging/rtl8192e/rtllib_crypt_tkip.c | 99 > ++--

Re: [dm-devel] [PATCH 6/26] staging: rtl8192u: Use skcipher and ahash

2016-01-24 Thread Greg KH
On Sun, Jan 24, 2016 at 09:16:57PM +0800, Herbert Xu wrote: > This patch replaces uses of blkcipher with skcipher, and the long > obsolete hash interface with ahash. > > Signed-off-by: Herbert Xu > --- > > drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_tkip.c | 92 > +++--- >