Re: [dm-devel] [PATCH 06/31] cdrom: remove the unused mode argument to cdrom_release

2023-06-26 Thread Guenter Roeck
On Tue, Jun 06, 2023 at 09:39:25AM +0200, Christoph Hellwig wrote: > Signed-off-by: Christoph Hellwig > --- $ git grep cdrom_release Documentation/cdrom/cdrom-standard.rst: cdrom_release, /* release */ Documentation/cdrom/cdrom-standard.rst:the door, should be left over to the

Re: [dm-devel] [PATCH 08/24] init: pass root_device_name explicitly

2023-06-26 Thread Guenter Roeck
On 6/26/23 00:53, Christoph Hellwig wrote: On Fri, Jun 23, 2023 at 05:08:59PM -0700, Guenter Roeck wrote: Hi, On Wed, May 31, 2023 at 02:55:19PM +0200, Christoph Hellwig wrote: Instead of declaring root_device_name as a global variable pass it as an argument to the functions using it. Signed

Re: [dm-devel] [PATCH 08/24] init: pass root_device_name explicitly

2023-06-23 Thread Guenter Roeck
Hi, On Wed, May 31, 2023 at 02:55:19PM +0200, Christoph Hellwig wrote: > Instead of declaring root_device_name as a global variable pass it as an > argument to the functions using it. > > Signed-off-by: Christoph Hellwig This patch results in the following build error when trying to build

Re: [dm-devel] [PATCH 14/24] init: clear root_wait on all invalid root= strings

2023-06-22 Thread Guenter Roeck
On 6/22/23 07:40, Christoph Hellwig wrote: On Thu, Jun 22, 2023 at 06:54:41AM -0700, Guenter Roeck wrote: On 6/21/23 23:00, Christoph Hellwig wrote: Hi Guenter, can you try this patch? diff --git a/block/early-lookup.c b/block/early-lookup.c index a5be3c68ed079c..66e4514d671179 100644

Re: [dm-devel] [PATCH 14/24] init: clear root_wait on all invalid root= strings

2023-06-22 Thread Guenter Roeck
On 6/21/23 23:00, Christoph Hellwig wrote: Hi Guenter, can you try this patch? diff --git a/block/early-lookup.c b/block/early-lookup.c index a5be3c68ed079c..66e4514d671179 100644 --- a/block/early-lookup.c +++ b/block/early-lookup.c @@ -174,7 +174,7 @@ static int __init

Re: [dm-devel] [PATCH 14/24] init: clear root_wait on all invalid root= strings

2023-06-21 Thread Guenter Roeck
On 6/21/23 20:51, Christoph Hellwig wrote: On Wed, Jun 21, 2023 at 02:07:13PM -0700, Guenter Roeck wrote: On Tue, May 23, 2023 at 09:45:25AM +0200, Christoph Hellwig wrote: Instead of only clearing root_wait in devt_from_partuuid when the UUID format was invalid, do that in parse_root_device

Re: [dm-devel] [PATCH 14/24] init: clear root_wait on all invalid root= strings

2023-06-21 Thread Guenter Roeck
Hi, On Tue, May 23, 2023 at 09:45:25AM +0200, Christoph Hellwig wrote: > Instead of only clearing root_wait in devt_from_partuuid when the UUID > format was invalid, do that in parse_root_device for all strings that > failed to parse. > > Signed-off-by: Christoph Hellwig In linux-next, almost

Re: [dm-devel] [linux-next:master] BUILD REGRESSION 088b9c375534d905a4d337c78db3b3bfbb52c4a0

2022-07-07 Thread Guenter Roeck
On Thu, Jul 07, 2022 at 10:08:33AM +0200, Greg KH wrote: [ ... ] > > > > Unverified Error/Warning (likely false positive, please contact us if > > interested): > > > > arch/x86/events/core.c:2114 init_hw_perf_events() warn: missing error code > > 'err' > > drivers/android/binder.c:1481:19-23:

Re: [dm-devel] [PATCH 5.4 26/34] dm verity: set DM_TARGET_IMMUTABLE feature flag

2022-06-16 Thread Guenter Roeck
On 6/15/22 13:02, Mike Snitzer wrote: On Wed, Jun 15 2022 at 1:50P -0400, Guenter Roeck wrote: On 6/15/22 08:29, Mike Snitzer wrote: On Wed, Jun 15 2022 at 10:36P -0400, Guenter Roeck wrote: On Mon, Jun 13, 2022 at 11:13:21AM +0200, Greg KH wrote: On Fri, Jun 10, 2022 at 11:11:00AM

Re: [dm-devel] [PATCH 5.4 26/34] dm verity: set DM_TARGET_IMMUTABLE feature flag

2022-06-15 Thread Guenter Roeck
On Wed, Jun 15, 2022 at 04:02:36PM -0400, Mike Snitzer wrote: > On Wed, Jun 15 2022 at 1:50P -0400, > Guenter Roeck wrote: > > > On 6/15/22 08:29, Mike Snitzer wrote: > > > On Wed, Jun 15 2022 at 10:36P -0400, > > > Guenter Roeck wrote: > > > > &

Re: [dm-devel] [PATCH 5.4 26/34] dm verity: set DM_TARGET_IMMUTABLE feature flag

2022-06-15 Thread Guenter Roeck
On Wed, Jun 15, 2022 at 04:02:36PM -0400, Mike Snitzer wrote: [ ... ] > > OK, well this is pretty easy to fix in general. If there are slight > differences across older trees they are easily resolved. Fact that > stable@ couldn't cope with backporting 9c37de297f65 is.. what it is. > > But this

Re: [dm-devel] [PATCH 5.4 26/34] dm verity: set DM_TARGET_IMMUTABLE feature flag

2022-06-15 Thread Guenter Roeck
On 6/15/22 08:29, Mike Snitzer wrote: On Wed, Jun 15 2022 at 10:36P -0400, Guenter Roeck wrote: On Mon, Jun 13, 2022 at 11:13:21AM +0200, Greg KH wrote: On Fri, Jun 10, 2022 at 11:11:00AM -0400, Mike Snitzer wrote: On Fri, Jun 10 2022 at 1:15P -0400, Greg KH wrote: On Fri, Jun 10, 2022

Re: [dm-devel] [PATCH 5.4 26/34] dm verity: set DM_TARGET_IMMUTABLE feature flag

2022-06-15 Thread Guenter Roeck
On Mon, Jun 13, 2022 at 11:13:21AM +0200, Greg KH wrote: > On Fri, Jun 10, 2022 at 11:11:00AM -0400, Mike Snitzer wrote: > > On Fri, Jun 10 2022 at 1:15P -0400, > > Greg KH wrote: > > > > > On Fri, Jun 10, 2022 at 04:22:00AM +, Oleksandr Tymoshenko wrote: > > > > I believe this commit

Re: [dm-devel] [PATCH 01/19] fs: remove mpage_alloc

2022-03-23 Thread Guenter Roeck
gfp = mapping_gfp_constraint(page->mapping, GFP_KERNEL); > + gfp |= __GFP_NORETRY | __GFP_NOWARN; > } > > if (page_has_buffers(page)) That fixes the problem for me. Tested-by: Guenter Roeck Guenter -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH 01/19] fs: remove mpage_alloc

2022-03-22 Thread Guenter Roeck
On Mon, Jan 24, 2022 at 10:10:49AM +0100, Christoph Hellwig wrote: > open code mpage_alloc in it's two callers and simplify the results > because of the context: > > - __mpage_writepage always passes GFP_NOFS and can thus always sleep and > will never get a NULL return from bio_alloc at all.

Re: [dm-devel] [PATCH 4/8] block: support delayed holder registration

2021-08-20 Thread Guenter Roeck
} There is nothing that this protects against except for slightly reducing the window when new opens can appear just before calling del_gendisk. Signed-off-by: Christoph Hellwig A cautious Tested-by: Guenter Roeck Cautious because -next is a bit broken right now and I can not run a complete

Re: [dm-devel] [PATCH 4/8] block: support delayed holder registration

2021-08-17 Thread Guenter Roeck
On Mon, Aug 16, 2021 at 09:21:58AM +0200, Christoph Hellwig wrote: > On Sun, Aug 15, 2021 at 07:27:37AM -0700, Guenter Roeck wrote: > > [ 14.467748][T1] Possible unsafe locking scenario: > > [ 14.467748][T1] > > [ 14.467928][T1]CPU0

Re: [dm-devel] [PATCH 4/8] block: support delayed holder registration

2021-08-16 Thread Guenter Roeck
On Mon, Aug 16, 2021 at 09:21:58AM +0200, Christoph Hellwig wrote: > On Sun, Aug 15, 2021 at 07:27:37AM -0700, Guenter Roeck wrote: > > [ 14.467748][T1] Possible unsafe locking scenario: > > [ 14.467748][T1] > > [ 14.467928][T1]CPU0

Re: [dm-devel] [PATCH 4/8] block: support delayed holder registration

2021-08-15 Thread Guenter Roeck
On 8/15/21 12:07 AM, Christoph Hellwig wrote: On Sat, Aug 14, 2021 at 02:13:09PM -0700, Guenter Roeck wrote: On Wed, Aug 04, 2021 at 11:41:43AM +0200, Christoph Hellwig wrote: device mapper needs to register holders before it is ready to do I/O. Currently it does so by registering the disk

Re: [dm-devel] [PATCH 4/8] block: support delayed holder registration

2021-08-14 Thread Guenter Roeck
On Wed, Aug 04, 2021 at 11:41:43AM +0200, Christoph Hellwig wrote: > device mapper needs to register holders before it is ready to do I/O. > Currently it does so by registering the disk early, which can leave > the disk and queue in a weird half state where the queue is registered > with the disk,

Re: [dm-devel] [PATCH] dm: Avoid sleeping while holding the dm_bufio lock

2016-11-17 Thread Guenter Roeck
lock() that the thread holds. You want to > pass GFP_NOWAIT instead of GFP_NOIO to alloc_buffer() when holding a > mutex that can be contended by a concurrent slab shrinker (if > count_objects didn't use a trylock, this pattern would trivially > deadlock). > > Suggested-by: David Rientj