Re: [dm-devel] [PATCH] fix writing to the filesystem after unmount

2023-09-08 Thread John Stoffel
> "Christian" == Christian Brauner writes: >> Well, currently you click some "Eject / safely remove / whatever" button >> and then you get a "wait" dialog until everything is done after which >> you're told the stick is safe to remove. What I imagine is that the "wait" >> dialog needs to be

Re: [dm-devel] RAID4 with no striping mode request

2023-02-13 Thread John Stoffel
> "Kyle" == Kyle Sanderson writes: > hi DM and Linux-RAID, > There have been multiple proprietary solutions (some nearly 20 years > old now) with a number of (userspace) bugs that are becoming untenable > for me as an end user. Basically how they work is a closed MD module > (typically

Re: [dm-devel] [PATCH 1/4] block: introduce submit_bio_noacct_add_head

2020-12-30 Thread John Stoffel
>>>>> "Danny" == Danny Shih writes: Danny> Hi, John, Danny> Thank you for taking the time to write a review. Danny> John Stoffel writes: >>>>>>> "dannyshih" == dannyshih writes: dannyshih> From: Danny Shih dannyshih>

Re: [dm-devel] [PATCH 1/4] block: introduce submit_bio_noacct_add_head

2020-12-30 Thread John Stoffel
>>>>> "antlists" == antlists writes: antlists> On 30/12/2020 00:00, John Stoffel wrote: dannyshih> From: Danny Shih dannyshih> Porvide a way for stacking block device to re-submit the bio dannyshih> which sholud be handled firstly. >> >> Yo

Re: [dm-devel] [PATCH 1/4] block: introduce submit_bio_noacct_add_head

2020-12-29 Thread John Stoffel
> "dannyshih" == dannyshih writes: dannyshih> From: Danny Shih dannyshih> Porvide a way for stacking block device to re-submit the bio dannyshih> which sholud be handled firstly. You're spelling needs to be fixed in these messages. dannyshih> Signed-off-by: Danny Shih dannyshih>

Re: [dm-devel] [general question] rare silent data corruption when writing data

2020-05-08 Thread John Stoffel
ichal> note: as suggested, I'm also CCing this to linux-lvm; the full Michal> context with replies starts at: Michal> https://www.spinics.net/lists/raid/msg64364.html There is also Michal> the initial post at the bottom as well. Michal> On 5/8/20 2:54 AM, John Stoffel wrote: &

Re: [dm-devel] [PATCH 10/15] libmultipath: change how the checker async is set

2020-01-21 Thread John Stoffel
>>>>> "Benjamin" == Benjamin Marzinski writes: Benjamin> On Mon, Jan 20, 2020 at 03:20:14PM -0500, John Stoffel wrote: >> >>>>> "Benjamin" == Benjamin Marzinski writes: >> Benjamin> On Sat, Jan 18, 2020 at 12:43:49PM -05

Re: [dm-devel] [PATCH 10/15] libmultipath: change how the checker async is set

2020-01-20 Thread John Stoffel
>>>>> "Benjamin" == Benjamin Marzinski writes: Benjamin> On Sat, Jan 18, 2020 at 12:43:49PM -0500, John Stoffel wrote: >> >>>>> "Benjamin" == Benjamin Marzinski writes: >> Benjamin> The way that the checkers async mode wo

Re: [dm-devel] [PATCH 10/15] libmultipath: change how the checker async is set

2020-01-18 Thread John Stoffel
> "Benjamin" == Benjamin Marzinski writes: Benjamin> The way that the checkers async mode worked in multipathd didn't make Benjamin> much sense. When multipathd starts up, all checker classes are in the Benjamin> sync mode, and any pathinfo() calls on devices would run the checker in

Re: [dm-devel] [PATCH 09/15] libmultipath: add code to get vendor specific vpd data

2020-01-18 Thread John Stoffel
> "Benjamin" == Benjamin Marzinski writes: Benjamin> This adds the wildcard 'g' for multipath and path formatted Benjamin> printing, which returns extra data from a device's vendor Benjamin> specific vpd page. The specific vendor vpd page to use, and Benjamin> the vendor/product id to

Re: [dm-devel] [PATCH V2] dm-raid: fix updating of max_discard_sectors limit

2019-09-11 Thread John Stoffel
> "Mike" == Mike Snitzer writes: Mike> On Wed, Sep 11 2019 at 7:31am -0400, Mike> Ming Lei wrote: >> Unit of 'chunk_size' is byte, instead of sector, so fix it. >> >> Without this fix, too big max_discard_sectors is applied on the request queue >> of dm-raid, finally raid code has to

Re: [dm-devel] Serial console is causing system lock-up

2019-03-07 Thread John Stoffel
> "John" == John Ogness writes: John> On 2019-03-06, Steven Rostedt wrote: >>> This bug only happens if we select large logbuffer (millions of >>> characters). With smaller log buffer, there are messages "** X printk >>> messages dropped", but there's no lockup. >>> >>> The kernel

Re: [dm-devel] Possible bug in mirror target

2019-02-12 Thread John Stoffel
>>>>> "Zdenek" == Zdenek Kabelac writes: Zdenek> Dne 10. 02. 19 v 22:58 John Stoffel napsal(a): >>>>>>> "Zdenek" == Zdenek Kabelac writes: >> Zdenek> Dne 05. 02. 19 v 1:47 Drew Hastings napsal(a): >>>> Hi,

Re: [dm-devel] Possible bug in mirror target

2019-02-10 Thread John Stoffel
> "Zdenek" == Zdenek Kabelac writes: Zdenek> Dne 05. 02. 19 v 1:47 Drew Hastings napsal(a): >> Hi, >> >> I'm assuming all user space code is expected to use the handle_errors >> feature, >> so this isn't that big of a deal. I'm also using 4.19.13, which I think is >> more recent than the

Re: [dm-devel] [PATCH] mm: set PF_LESS_THROTTLE when allocating memory for i/o

2018-07-05 Thread John Stoffel
> "Mikulas" == Mikulas Patocka writes: Mikulas> It has been noticed that congestion throttling can slow down Mikulas> allocations path that participate in the IO and thus help the Mikulas> memory reclaim. Stalling those allocation is therefore not Mikulas> productive. Moreover mempool

Re: [dm-devel] [PATCH v5] fault-injection: introduce kvmalloc fallback options

2018-05-02 Thread John Stoffel
>>>>> "Mikulas" == Mikulas Patocka <mpato...@redhat.com> writes: Mikulas> On Mon, 30 Apr 2018, John Stoffel wrote: >> >>>>> "Mikulas" == Mikulas Patocka <mpato...@redhat.com> writes: >> Mikulas> On T

Re: [dm-devel] kvmalloc: always use vmalloc if CONFIG_DEBUG_VM

2018-05-02 Thread John Stoffel
> "Mike" == Mike Snitzer writes: Mike> On Tue, May 01 2018 at 8:36pm -0400, Mike> Andrew Morton wrote: >> On Tue, 24 Apr 2018 12:33:01 -0400 (EDT) Mikulas Patocka >> wrote: >> >> > >> > >> > On Tue, 24 Apr 2018,

Re: [dm-devel] [PATCH v5] fault-injection: introduce kvmalloc fallback options

2018-04-30 Thread John Stoffel
>>>>> "Mikulas" == Mikulas Patocka <mpato...@redhat.com> writes: Mikulas> On Thu, 26 Apr 2018, John Stoffel wrote: >> >>>>> "James" == James Bottomley <james.bottom...@hansenpartnership.com> >> >>>>> wr

Re: [dm-devel] [PATCH v5] fault-injection: introduce kvmalloc fallback options

2018-04-26 Thread John Stoffel
> "James" == James Bottomley writes: James> On Wed, 2018-04-25 at 19:00 -0400, Mikulas Patocka wrote: >> >> On Wed, 25 Apr 2018, James Bottomley wrote: >> >> > > > Do we really need the new config option?  This could just be >> > > > manually  tunable

Re: [dm-devel] [PATCH V4] blk-mq: introduce BLK_STS_DEV_RESOURCE

2018-02-01 Thread John Stoffel
> "Bart" == Bart Van Assche writes: Bart> On Mon, 2018-01-29 at 16:44 -0500, Mike Snitzer wrote: >> But regardless of which wins the race, the queue will have been run. >> Which is all we care about right? Bart> Running the queue is not sufficient. With this patch

Re: [dm-devel] [PATCH] dm-crypt: limit the number of allocated pages

2017-08-21 Thread John Stoffel
>>>>> "Mikulas" == Mikulas Patocka <mpato...@redhat.com> writes: Mikulas> On Fri, 18 Aug 2017, John Stoffel wrote: Mikulas> The limit can't be changed. I expect that no one will run a system with Mikulas> such a tight requirements that the memor

Re: [dm-devel] [PATCH] dm-crypt: limit the number of allocated pages

2017-08-17 Thread John Stoffel
>>>>> "Mikulas" == Mikulas Patocka <mpato...@redhat.com> writes: Mikulas> On Mon, 14 Aug 2017, John Stoffel wrote: >> >>>>> "Mikulas" == Mikulas Patocka <mpato...@redhat.com> writes: >> Mikulas> dm-crypt consumes ex

Re: [dm-devel] [PATCH] dm-crypt: limit the number of allocated pages

2017-08-14 Thread John Stoffel
> "Mikulas" == Mikulas Patocka writes: Mikulas> dm-crypt consumes excessive amount memory when the user attempts to zero Mikulas> a dm-crypt device with "blkdiscard -z". The command "blkdiscard -z" calls Mikulas> the BLKZEROOUT ioctl, it goes to the function

Re: [dm-devel] dm-integrity: fix inefficient allocation of stack space

2017-07-20 Thread John Stoffel
>>>>> "Mikulas" == Mikulas Patocka <mpato...@redhat.com> writes: Mikulas> On Wed, 19 Jul 2017, John Stoffel wrote: >> I'd like to argue that you should never use BUG_ON at all, esp since >> if you have integrity running on just one critical device,

Re: [dm-devel] [PATCH] dm-integrity: fix inefficient allocation of stack space

2017-07-20 Thread John Stoffel
>>>>> "Mikulas" == Mikulas Patocka <mpato...@redhat.com> writes: Mikulas> On Wed, 19 Jul 2017, John Stoffel wrote: >> >>>>> "Mikulas" == Mikulas Patocka <mpato...@redhat.com> writes: >> Mikulas> When using block

Re: [dm-devel] dm-integrity: fix inefficient allocation of stack space

2017-07-19 Thread John Stoffel
>>>>> "Mike" == Mike Snitzer <snit...@redhat.com> writes: Mike> On Wed, Jul 19 2017 at 2:39pm -0400, Mike> John Stoffel <j...@stoffel.org> wrote: >> >>>>> "Mikulas" == Mikulas Patocka <mpato...@redhat.com> wri

Re: [dm-devel] [PATCH] dm-integrity: fix inefficient allocation of stack space

2017-07-19 Thread John Stoffel
> "Mikulas" == Mikulas Patocka writes: Mikulas> When using block size greater than 512 bytes, the dm-integrity target Mikulas> allocates journal space inefficiently, it allocates one entry for each Mikulas> 512-byte chunk of data, fills entries for each block of data and

Re: [dm-devel] dm-cache issue

2016-11-15 Thread John Stoffel
Alexander> I am in a process of evaluating dm-cache for our backup system. Why are you bothering to cache your backup destination? What filesystems are you using for your destinations? Alexander> Currently I have an issue when restart the backup Alexander> server. The server is booting for

Re: [dm-devel] getting feedback on dm-cache statistics tool

2016-05-27 Thread John Stoffel
>>>>> "Ben" == Ben England <bengl...@redhat.com> writes: Ben> John, thanks for reply, comments inline... Ben> ----- Original Message - >> From: "John Stoffel" <j...@stoffel.org> >> To: "Ben England" <bengl...@re

Re: [dm-devel] [PATCH 01/17] multipathd: use /run instead of /var/run

2016-03-30 Thread John Stoffel
>>>>> "Benjamin" == Benjamin Marzinski <bmarz...@redhat.com> writes: Benjamin> On Tue, Mar 29, 2016 at 09:57:25AM -0400, John Stoffel wrote: >> Benjamin> /var/run is now usually a symlink to /run. If /var is on a separate Benjamin> filesytem, when

Re: [dm-devel] [PATCH] [dm-cache] Make the mq policy an alias for smq

2016-02-10 Thread John Stoffel
Can you add in some documentation on how you tell which dm_cache policy is actually being used, and how to measure it, etc? It's a black box and some info would be nice. John -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel