Re: [dm-devel] [PATCH v2 0/6] kaddr and pfn can be NULL to ->direct_access()

at > is to say callers may have no need for kaddr or pfn, so this series of > patch are prepared for allowing them to pass in NULL instead of having > to pass in a local pointer or variable that they then just throw away. Looks good. For the series: Reviewed-by: Ross Zwisler -- dm-

Re: [dm-devel] [PATCH v3 1/3] pmem: only set QUEUE_FLAG_DAX for fsdax mode

On Thu, Jun 28, 2018 at 05:42:34PM +, Kani, Toshi wrote: > On Tue, 2018-06-26 at 16:04 -0600, Ross Zwisler wrote: > > On Tue, Jun 26, 2018 at 02:51:52PM -0700, Dan Williams wrote: > > > On Tue, Jun 26, 2018 at 2:31 PM, Kani, Toshi wrote: > > > > On Tue, 2018-06-2

Re: [dm-devel] [PATCH v3 1/3] pmem: only set QUEUE_FLAG_DAX for fsdax mode

On Tue, Jun 26, 2018 at 02:51:52PM -0700, Dan Williams wrote: > On Tue, Jun 26, 2018 at 2:31 PM, Kani, Toshi wrote: > > On Tue, 2018-06-26 at 14:28 -0700, Dan Williams wrote: > >> On Tue, Jun 26, 2018 at 2:23 PM, Kani, Toshi wrote: > >> > On Tue, 2018-06-26 at 14:02 -0700, Dan Williams wrote: >

[dm-devel] [PATCH v5 3/3] dm: prevent DAX mounts if not supported

in dm_table_set_restrictions(). Now that bdev_dax_supported() explicitly checks for QUEUE_FLAG_DAX, this will ensure that filesystems built upon DM devices will only be able to mount with DAX if all underlying devices also support DAX. Signed-off-by: Ross Zwisler Fixes: commit 545ed20e6df6 ("dm: add infrastru

[dm-devel] [PATCH v3 3/3] dm: prevent DAX mounts if not supported

be able to mount with DAX if all underlying devices also support DAX. Signed-off-by: Ross Zwisler Fixes: commit 545ed20e6df6 ("dm: add infrastructure for DAX support") Cc: sta...@vger.kernel.org --- drivers/md/dm-ioctl.c | 5 + drivers/md/dm-table.c | 7 +++

[dm-devel] [PATCH v3 0/3] Fix DM DAX handling

of DM_TYPE_DAX_BIO_BASED reworks. (Mike) * Dropped the first 2 prep patches of v2 since they were merged for v4.18-rc1. (Thanks, Darrick!) --- Mike, can you take this series through your tree? Personally I think this should be treated as a bug fix and merged in the v4.18-rc* series. Ross Zwisler (3

[dm-devel] [PATCH v3 1/3] pmem: only set QUEUE_FLAG_DAX for fsdax mode

QUEUE_FLAG_DAX is an indication that a given block device supports filesystem DAX and should not be set for PMEM namespaces which are in "raw" or "sector" modes. These namespaces lack struct page and are prevented from participating in filesystem DAX. Signed-off-by: Ros

[dm-devel] [PATCH v4 3/3] dm: prevent DAX mounts if not supported

be able to mount with DAX if all underlying devices also support DAX. Signed-off-by: Ross Zwisler Fixes: commit 545ed20e6df6 ("dm: add infrastructure for DAX support") Cc: sta...@vger.kernel.org --- Changes in v4: * Set/clear QUEUE_FLAG_DAX in dm_table_set_restrictions(). (Mike) --

[dm-devel] [PATCH v3 2/3] dax: bdev_dax_supported() check for QUEUE_FLAG_DAX

a filesystem on that device mount with the DAX option. Signed-off-by: Ross Zwisler Suggested-by: Mike Snitzer Cc: sta...@vger.kernel.org --- drivers/dax/super.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/dax/super.c b/drivers/dax/super.c index 903d9c473749..45276abf03aa 100644

Re: [dm-devel] [PATCH v3 1/3] pmem: only set QUEUE_FLAG_DAX for fsdax mode

On Tue, Jun 26, 2018 at 12:07:40PM -0700, Dan Williams wrote: > On Tue, Jun 26, 2018 at 11:58 AM, Mike Snitzer wrote: > > On Tue, Jun 26 2018 at 2:52pm -0400, > > Dan Williams wrote: > > > >> On Tue, Jun 26, 2018 at 10:59 AM, Ross Zwisler > >> wrote:

Re: [dm-devel] [PATCH v3 1/3] pmem: only set QUEUE_FLAG_DAX for fsdax mode

On Tue, Jun 26, 2018 at 02:58:30PM -0400, Mike Snitzer wrote: > On Tue, Jun 26 2018 at 2:52pm -0400, > Dan Williams wrote: > > > On Tue, Jun 26, 2018 at 10:59 AM, Ross Zwisler > > wrote: > > > QUEUE_FLAG_DAX is an indication that a given block device supports &

[dm-devel] [PATCH v5 2/3] dax: bdev_dax_supported() check for QUEUE_FLAG_DAX

a filesystem on that device mount with the DAX option. Signed-off-by: Ross Zwisler Suggested-by: Mike Snitzer Fixes: commit 545ed20e6df6 ("dm: add infrastructure for DAX support") Cc: sta...@vger.kernel.org --- drivers/dax/super.c | 8 1 file changed, 8 insertions(+) diff --git a/d

[dm-devel] [PATCH v5 0/3] Fix DM DAX handling

ramdisk which can hold a filesystem mounted with the -o dax mount option. All I/O to this filesystem will fail. --- Changes since v4: * No code changes. * Updated the changelogs for patches 1 and 3. * Removed the Cc: stable from patch 1. * Added a Fixes: tag to patch 2. Ross Zwisler

Re: [dm-devel] [PATCH v2 4/7] dm: prevent DAX mounts if not supported

On Wed, Jun 20, 2018 at 11:17:49AM -0400, Mike Snitzer wrote: > On Mon, Jun 04 2018 at 7:15pm -0400, > Ross Zwisler wrote: > > > On Fri, Jun 01, 2018 at 05:55:13PM -0400, Mike Snitzer wrote: > > > On Tue, May 29 2018 at 3:51pm -0400, > > > Ross Zwisler wrote:

Re: [dm-devel] [PATCH v2 5/7] dm: remove DM_TYPE_DAX_BIO_BASED dm_queue_mode

On Mon, Jun 04, 2018 at 08:46:28PM -0400, Mike Snitzer wrote: > On Mon, Jun 04 2018 at 7:24pm -0400, > Ross Zwisler wrote: > > > On Fri, Jun 01, 2018 at 06:04:43PM -0400, Mike Snitzer wrote: > > > On Tue, May 29 2018 at 3:51pm -0400, &

Re: [dm-devel] [PATCH v2 4/7] dm: prevent DAX mounts if not supported

On Fri, Jun 01, 2018 at 05:55:13PM -0400, Mike Snitzer wrote: > On Tue, May 29 2018 at 3:51pm -0400, > Ross Zwisler wrote: > > > Currently the code in dm_dax_direct_access() only checks whether the target > > type has a direct_access() operation defined, not whether the

Re: [dm-devel] [PATCH v2 5/7] dm: remove DM_TYPE_DAX_BIO_BASED dm_queue_mode

On Fri, Jun 01, 2018 at 06:04:43PM -0400, Mike Snitzer wrote: > On Tue, May 29 2018 at 3:51pm -0400, > Ross Zwisler wrote: > > > The DM_TYPE_DAX_BIO_BASED dm_queue_mode was introduced to prevent DM > > devices that could possibly support DAX from transitioning into DM de

Re: [dm-devel] [PATCH v2 3/7] dm: fix test for DAX device support

On Fri, Jun 01, 2018 at 04:46:04PM -0400, Mike Snitzer wrote: > On Fri, Jun 01 2018 at 4:19P -0400, > Mike Snitzer wrote: > > > On Tue, May 29 2018 at 3:51P -0400, > > Ross Zwisler wrote: > > > > > Currently device_supports_dax() just checks to see if

Re: [dm-devel] [PATCH v2 2/7] dax: change bdev_dax_supported() to support boolean returns

On Thu, May 31, 2018 at 03:26:45PM -0700, Darrick J. Wong wrote: > On Thu, May 31, 2018 at 04:52:06PM -0400, Mike Snitzer wrote: > > On Thu, May 31 2018 at 3:13pm -0400, > > Darrick J. Wong wrote: > > > > > On Tue, May 29, 2018 at 04:01:14PM -0600, Ross Zwisler

Re: [dm-devel] [PATCH v2 2/7] dax: change bdev_dax_supported() to support boolean returns

On Thu, May 31, 2018 at 12:13:32PM -0700, Darrick J. Wong wrote: > On Tue, May 29, 2018 at 04:01:14PM -0600, Ross Zwisler wrote: > > On Tue, May 29, 2018 at 02:25:10PM -0700, Darrick J. Wong wrote: > > > On Tue, May 29, 2018 at 01:51:01PM -0600, Ross Zwisler wrote: > &

Re: [dm-devel] [PATCH v2 2/7] dax: change bdev_dax_supported() to support boolean returns

On Thu, May 31, 2018 at 12:13:32PM -0700, Darrick J. Wong wrote: > On Tue, May 29, 2018 at 04:01:14PM -0600, Ross Zwisler wrote: > > On Tue, May 29, 2018 at 02:25:10PM -0700, Darrick J. Wong wrote: > > > On Tue, May 29, 2018 at 01:51:01PM -0600, Ross Zwisler wrote: > &

[dm-devel] [PATCH v2 4/7] dm: prevent DAX mounts if not supported

() if QUEUE_FLAG_DAX isn't set we let the filesystem know we don't support DAX at mount time. The filesystem will then silently fall back and remove the dax mount option, causing it to work properly. Signed-off-by: Ross Zwisler Fixes: commit 545ed20e6df6 ("dm: add infrastructure for DAX su

[dm-devel] [PATCH v2 7/7] dm-error: remove unnecessary direct_access() stub

This stub was added so that we could use dm-error with DM_TYPE_DAX_BIO_BASED mode devices. That mode and the transition issues associated with it no longer exist, so we can remove this dead code. Signed-off-by: Ross Zwisler --- drivers/md/dm-target.c | 7 --- 1 file changed, 7 deletions

[dm-devel] [PATCH v2 2/7] dax: change bdev_dax_supported() to support boolean returns

and no DAX support returns false. Signed-off-by: Dave Jiang Signed-off-by: Ross Zwisler --- drivers/dax/super.c | 16 fs/ext2/super.c | 3 +-- fs/ext4/super.c | 3 +-- fs/xfs/xfs_ioctl.c | 4 ++-- fs/xfs/xfs_super.c | 12 ++-- include/linux/dax.h | 8 6

Re: [dm-devel] [PATCH v2 2/7] dax: change bdev_dax_supported() to support boolean returns

On Tue, May 29, 2018 at 02:25:10PM -0700, Darrick J. Wong wrote: > On Tue, May 29, 2018 at 01:51:01PM -0600, Ross Zwisler wrote: > > From: Dave Jiang > > > > The function return values are confusing with the way the function is > > named. We expect a true or false r

[dm-devel] [PATCH v2 1/7] fs: allow per-device dax status checking for filesystems

istinguish between datadev and rtdev. This patch fixes the problem where we screw up the dax support checking in xfs if the datadev and rtdev have different dax capabilities. Signed-off-by: Darrick J. Wong [rez: Re-added __bdev_dax_supported() for !CONFIG_FS_DAX cases] Signed-off-by: Ross Zwisler

[dm-devel] [PATCH v2 6/7] dm-snap: remove unnecessary direct_access() stub

This stub was added so that we could use dm-snap with DM_TYPE_DAX_BIO_BASED mode devices. That mode and the transition issues associated with it no longer exist, so we can remove this dead code. Signed-off-by: Ross Zwisler --- drivers/md/dm-snap.c | 8 1 file changed, 8 deletions

[dm-devel] [PATCH v2 0/7] Fix DM DAX handling

() to support boolean returns Ross Zwisler (5): dm: fix test for DAX device support dm: prevent DAX mounts if not supported dm: remove DM_TYPE_DAX_BIO_BASED dm_queue_mode dm-snap: remove unnecessary direct_access() stub dm-error: remove unnecessary direct_access() stub drivers/dax

[dm-devel] [PATCH] dm-writecache: fix compilation issue with !DAX

for the 'p' (persistent memory) flag so that fails on both architectures that don't support persistent memory and on kernels that don't have DAX support configured. This prevents us from ever hitting the BUG() in the persistent_memory_claim() stub. Signed-off-by: Ross Zwisler Reported-by: Arnd Bergmann

[dm-devel] [PATCH v2 3/7] dm: fix test for DAX device support

the dax_direct_access() path works. Signed-off-by: Ross Zwisler Fixes: commit 545ed20e6df6 ("dm: add infrastructure for DAX support") --- drivers/md/dm-table.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/md/dm-table.c b/drivers/md/dm-table.c index 05

[dm-devel] [PATCH v2 5/7] dm: remove DM_TYPE_DAX_BIO_BASED dm_queue_mode

then know at mount time whether DAX is a supported mount option or not. Signed-off-by: Ross Zwisler --- drivers/md/dm-ioctl.c | 16 ++-- drivers/md/dm-table.c | 25 ++--- drivers/md/dm.c | 2 -- include/linux/device-mapper.h | 8 ++

Re: [dm-devel] [PATCH] dm: writecache: add DAX dependency

On Mon, May 28, 2018 at 05:38:10PM +0200, Arnd Bergmann wrote: > The new dm-writecache driver inconditionally uses the dax unconditionally > subsystem, leading to link errors in some configurations: > > drivers/md/dm-writecache.o: In function `writecache_ctr': >

Re: [dm-devel] [PATCH 1/7] fs: allow per-device dax status checking for filesystems

On Thu, May 24, 2018 at 10:02:18PM -0700, Darrick J. Wong wrote: > On Thu, May 24, 2018 at 08:55:12PM -0600, Ross Zwisler wrote: > > From: "Darrick J. Wong" <darrick.w...@oracle.com> > > > > Remove __bdev_dax_supported and change to bdev_dax_supp

[dm-devel] [PATCH resend 2/7] dax: change bdev_dax_supported() to support boolean returns

ported then return true and no DAX support returns false. Signed-off-by: Dave Jiang <dave.ji...@intel.com> Signed-off-by: Ross Zwisler <ross.zwis...@linux.intel.com> Reviewed-by: Darrick J. Wong <darrick.w...@oracle.com> --- drivers/dax/super.c | 16 fs/ext2/super

[dm-devel] [PATCH resend 0/7] Fix DM DAX handling

feel that this series simplifies the handling of DAX devices in DM, and the last 5 DM-related patches have a net code reduction of 50 lines. Darrick J. Wong (1): fs: allow per-device dax status checking for filesystems Dave Jiang (1): dax: change bdev_dax_supported() to support boolean returns

[dm-devel] [PATCH resend 4/7] dm: prevent DAX mounts if not supported

() if QUEUE_FLAG_DAX isn't set we let the filesystem know we don't support DAX at mount time. The filesystem will then silently fall back and remove the dax mount option, causing it to work properly. Signed-off-by: Ross Zwisler <ross.zwis...@linux.intel.com> Fixes: commit 545ed20e6df6 (&q

[dm-devel] [PATCH resend 7/7] dm-error: remove unnecessary direct_access() stub

This stub was added so that we could use dm-error with DM_TYPE_DAX_BIO_BASED mode devices. That mode and the transition issues associated with it no longer exist, so we can remove this dead code. Signed-off-by: Ross Zwisler <ross.zwis...@linux.intel.com> --- drivers/md/dm-target

Re: [dm-devel] [PATCH 4/7] dm: prevent DAX mounts if not supported

On Fri, May 25, 2018 at 03:54:10PM -0400, Mike Snitzer wrote: > On Thu, May 24 2018 at 10:55pm -0400, > Ross Zwisler <ross.zwis...@linux.intel.com> wrote: > > > Currently the code in dm_dax_direct_access() only checks whether the target > > type has a direct

[dm-devel] [PATCH resend 5/7] dm: remove DM_TYPE_DAX_BIO_BASED dm_queue_mode

then know at mount time whether DAX is a supported mount option or not. Signed-off-by: Ross Zwisler <ross.zwis...@linux.intel.com> --- drivers/md/dm-ioctl.c | 16 ++-- drivers/md/dm-table.c | 25 ++--- drivers/md/dm.c | 2 --

[dm-devel] [PATCH resend 1/7] fs: allow per-device dax status checking for filesystems

actually fix all the parts of XFS where we need to be able to distinguish between datadev and rtdev. This patch fixes the problem where we screw up the dax support checking in xfs if the datadev and rtdev have different dax capabilities. Signed-off-by: Darrick J. Wong <darrick.w...@oracle.com&g

[dm-devel] [PATCH 4/7] dm: prevent DAX mounts if not supported

() if QUEUE_FLAG_DAX isn't set we let the filesystem know we don't support DAX at mount time. The filesystem will then silently fall back and remove the dax mount option, causing it to work properly. Signed-off-by: Ross Zwisler <ross.zwis...@linux.intel.com> Fixes: commit 545ed20e6df6 (&q

[dm-devel] [PATCH 2/7] dax: change bdev_dax_supported() to support boolean returns

ported then return true and no DAX support returns false. Signed-off-by: Dave Jiang <dave.ji...@intel.com> Signed-off-by: Ross Zwisler <ross.zwis...@linux.intel.com> --- drivers/dax/super.c | 16 fs/ext2/super.c | 3 +-- fs/ext4/super.c | 3 +-- fs/xfs

[dm-devel] [PATCH 0/7] Fix DM DAX handling

code reduction of 50 lines. Darrick J. Wong (1): fs: allow per-device dax status checking for filesystems Dave Jiang (1): dax: change bdev_dax_supported() to support boolean returns Ross Zwisler (5): dm: fix test for DAX device support dm: prevent DAX mounts if not supported dm: remove

[dm-devel] [PATCH 7/7] dm-error: remove unnecessary direct_access() stub

This stub was added so that we could use dm-error with DM_TYPE_DAX_BIO_BASED mode devices. That mode and the transition issues associated with it no longer exist, so we can remove this dead code. Signed-off-by: Ross Zwisler <ross.zwis...@linux.intel.com> --- drivers/md/dm-target

[dm-devel] [PATCH 6/7] dm-snap: remove unnecessary direct_access() stub

This stub was added so that we could use dm-snap with DM_TYPE_DAX_BIO_BASED mode devices. That mode and the transition issues associated with it no longer exist, so we can remove this dead code. Signed-off-by: Ross Zwisler <ross.zwis...@linux.intel.com> --- drivers/md/dm-snap.c | 8 -

[dm-devel] [PATCH 3/7] dm: fix test for DAX device support

the dax_direct_access() path works. Signed-off-by: Ross Zwisler <ross.zwis...@linux.intel.com> Fixes: commit 545ed20e6df6 ("dm: add infrastructure for DAX support") --- drivers/md/dm-table.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/md/dm-tabl

[dm-devel] [PATCH 5/7] dm: remove DM_TYPE_DAX_BIO_BASED dm_queue_mode

then know at mount time whether DAX is a supported mount option or not. Signed-off-by: Ross Zwisler <ross.zwis...@linux.intel.com> --- drivers/md/dm-ioctl.c | 16 ++-- drivers/md/dm-table.c | 25 ++--- drivers/md/dm.c | 2 --

[dm-devel] [PATCH 1/7] fs: allow per-device dax status checking for filesystems

actually fix all the parts of XFS where we need to be able to distinguish between datadev and rtdev. This patch fixes the problem where we screw up the dax support checking in xfs if the datadev and rtdev have different dax capabilities. Signed-off-by: Darrick J. Wong <darrick.w...@oracle.com&g

Re: [dm-devel] [fstests PATCH v3] generic: add test for DAX MAP_SYNC support

On Thu, Oct 26, 2017 at 07:59:39AM +0300, Amir Goldstein wrote: > On Wed, Oct 25, 2017 at 11:47 PM, Ross Zwisler > <ross.zwis...@linux.intel.com> wrote: > > Add a test that exercises DAX's new MAP_SYNC flag. > > > > This test creates a file and writes to it via an m

Re: [dm-devel] [fstests PATCH v3] generic: add test for DAX MAP_SYNC support

On Thu, Nov 16, 2017 at 02:28:15PM -0700, Ross Zwisler wrote: > On Thu, Oct 26, 2017 at 08:56:38AM +1100, Dave Chinner wrote: > > Perhaps stat -c %b $SCRATCH_MNT/test ? > > Maybe, but doesn't the output of 'stat -c %b' depend on the block size the > filesystem is using? I thi

Re: [dm-devel] [fstests PATCH v3] generic: add test for DAX MAP_SYNC support

On Thu, Oct 26, 2017 at 08:56:38AM +1100, Dave Chinner wrote: > On Wed, Oct 25, 2017 at 02:47:04PM -0600, Ross Zwisler wrote: > > Add a test that exercises DAX's new MAP_SYNC flag. > > > > This test creates a file and writes to it via an mmap(), but never syncs > > via

[dm-devel] [fstests PATCH v3] generic: add test for DAX MAP_SYNC support

the mmap(), so we can't do any data integrity checking. We can only verify that the metadata writes for the page faults happened. Signed-off-by: Ross Zwisler <ross.zwis...@linux.intel.com> --- Changes since v2: - Fixed _require_log_writes() so that DAX will be disallowed if the v

Re: [dm-devel] [fstests PATCH v2] generic: add test for DAX MAP_SYNC support

On Wed, Oct 25, 2017 at 03:19:22PM +0300, Amir Goldstein wrote: > On Sun, Oct 22, 2017 at 9:56 AM, Amir Goldstein <amir7...@gmail.com> wrote: > > On Sat, Oct 21, 2017 at 12:25 AM, Ross Zwisler > > <ross.zwis...@linux.intel.com> wrote: > >> Add a test th

Re: [dm-devel] [PATCH 2/2] dm log writes: add support for DAX

On Tue, Oct 24, 2017 at 03:22:23PM -0400, Mike Snitzer wrote: > On Fri, Oct 20 2017 at 1:24am -0400, > Ross Zwisler <ross.zwis...@linux.intel.com> wrote: > > > Now that we have the ability log filesystem writes using a flat buffer, add > > support for DAX. Unfortun

Re: [dm-devel] [dm:for-next 8/9] drivers//md/dm-log-writes.c:279:17: note: in expansion of macro 'min'

On Wed, Oct 25, 2017 at 05:44:34AM +0800, kbuild test robot wrote: > tree: > https://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git > for-next > head: ae613bbb0144e84cb3c0ebfa9f4fd4d1507c2f0e > commit: 6a697d036324c7fbe63fb49599027269006161e7 [8/9] dm log writes: add >

Re: [dm-devel] [PATCH 2/2] dm log writes: add support for DAX

On Mon, Oct 23, 2017 at 01:34:09PM -0400, Josef Bacik wrote: > On Thu, Oct 19, 2017 at 11:24:04PM -0600, Ross Zwisler wrote: > > Now that we have the ability log filesystem writes using a flat buffer, add > > support for DAX. Unfortunately we can't easily track data that has been

[dm-devel] [fstests PATCH v2] generic: add test for DAX MAP_SYNC support

the mmap(), so we can't do any data integrity checking. We can only verify that the metadata writes for the page faults happened. Signed-off-by: Ross Zwisler <ross.zwis...@linux.intel.com> --- Changes since v1: - Addressed review feedback from Amir. Thank you for the review! --- .git

[dm-devel] [PATCH 2/2] dm log writes: add support for DAX

that can test the new MAP_SYNC DAX flag. By logging the filesystem activity with dm-log-writes we can show that the MAP_SYNC page faults are writing out their metadata as they happen, instead of requiring an explicit msync/fsync. Signed-off-by: Ross Zwisler <ross.zwis...@linux.intel.com>

[dm-devel] [fstests PATCH] generic: add test for DAX MAP_SYNC support

the mmap(), so we can't do any data integrity checking. We can only verify that the metadata writes for the page faults happened. Signed-off-by: Ross Zwisler <ross.zwis...@linux.intel.com> --- For this test to run successfully you'll need both Jan's MAP_SYNC series: https://www.spinics.net

[dm-devel] [PATCH 1/2] dm log writes: Add support for inline data buffers

() which allows us to write filesystem data using a flat buffer as a source, and wire it up in log_one_block(). Signed-off-by: Ross Zwisler <ross.zwis...@linux.intel.com> --- drivers/md/dm-log-writes.c | 90 +++--- 1 file changed, 86 insertions

Re: [dm-devel] [PATCH 42/45] block, fs, drivers: remove REQ_OP compat defs and related code

On Sun, Jun 5, 2016 at 1:32 PM, wrote: > From: Mike Christie > > This patch drops the compat definition of req_op where it matches > the rq_flag_bits definitions, and drops the related old and compat > code that allowed users to set either the op or

Re: [dm-devel] [PATCH 37/45] drivers: use req op accessor

On Sun, Jun 5, 2016 at 1:32 PM, wrote: > From: Mike Christie > > The req operation REQ_OP is separated from the rq_flag_bits > definition. This converts the block layer drivers to > use req_op to get the op from the request struct. > > Signed-off-by: