ual to NULL, that
> is to say callers may have no need for kaddr or pfn, so this series of
> patch are prepared for allowing them to pass in NULL instead of having
> to pass in a local pointer or variable that they then just throw away.
Looks good. For the series:
Reviewed-by: Ross Z
On Thu, Jun 28, 2018 at 05:42:34PM +, Kani, Toshi wrote:
> On Tue, 2018-06-26 at 16:04 -0600, Ross Zwisler wrote:
> > On Tue, Jun 26, 2018 at 02:51:52PM -0700, Dan Williams wrote:
> > > On Tue, Jun 26, 2018 at 2:31 PM, Kani, Toshi wrote:
> > > > On Tue, 2018-06-2
On Tue, Jun 26, 2018 at 02:51:52PM -0700, Dan Williams wrote:
> On Tue, Jun 26, 2018 at 2:31 PM, Kani, Toshi wrote:
> > On Tue, 2018-06-26 at 14:28 -0700, Dan Williams wrote:
> >> On Tue, Jun 26, 2018 at 2:23 PM, Kani, Toshi wrote:
> >> > On Tue, 2018-06-26 at 14:02 -0700, Dan Williams wrote:
> >
r flags
in dm_table_set_restrictions().
Now that bdev_dax_supported() explicitly checks for QUEUE_FLAG_DAX, this
will ensure that filesystems built upon DM devices will only be able to
mount with DAX if all underlying devices also support DAX.
Signed-off-by: Ross Zwisler
Fixes: commit 545ed20e6df6 ("dm: add inf
QUEUE_FLAG_DAX is an indication that a given block device supports
filesystem DAX and should not be set for PMEM namespaces which are in "raw"
or "sector" modes. These namespaces lack struct page and are prevented
from participating in filesystem DAX.
Signed-off-by: Ross Z
will only be able to mount with DAX if all underlying
devices also support DAX.
Signed-off-by: Ross Zwisler
Fixes: commit 545ed20e6df6 ("dm: add infrastructure for DAX support")
Cc: sta...@vger.kernel.org
---
Changes in v4:
* Set/clear QUEUE_FLAG_DAX in dm_table_set_restrictions().
filesystem on that device mount with the DAX option.
Signed-off-by: Ross Zwisler
Suggested-by: Mike Snitzer
Cc: sta...@vger.kernel.org
---
drivers/dax/super.c | 8
1 file changed, 8 insertions(+)
diff --git a/drivers/dax/super.c b/drivers/dax/super.c
index 903d9c473749..45276abf03aa 100644
On Tue, Jun 26, 2018 at 12:07:40PM -0700, Dan Williams wrote:
> On Tue, Jun 26, 2018 at 11:58 AM, Mike Snitzer wrote:
> > On Tue, Jun 26 2018 at 2:52pm -0400,
> > Dan Williams wrote:
> >
> >> On Tue, Jun 26, 2018 at 10:59 AM, Ross Zwisler
> >> wrote:
>
On Tue, Jun 26, 2018 at 02:58:30PM -0400, Mike Snitzer wrote:
> On Tue, Jun 26 2018 at 2:52pm -0400,
> Dan Williams wrote:
>
> > On Tue, Jun 26, 2018 at 10:59 AM, Ross Zwisler
> > wrote:
> > > QUEUE_FLAG_DAX is an indication that a given block device supports
&
will only be able to mount with DAX if all underlying
devices also support DAX.
Signed-off-by: Ross Zwisler
Fixes: commit 545ed20e6df6 ("dm: add infrastructure for DAX support")
Cc: sta...@vger.kernel.org
---
drivers/md/dm-ioctl.c | 5 +
drivers/md/dm-table.c | 7
id of DM_TYPE_DAX_BIO_BASED reworks. (Mike)
* Dropped the first 2 prep patches of v2 since they were merged for
v4.18-rc1. (Thanks, Darrick!)
---
Mike, can you take this series through your tree?
Personally I think this should be treated as a bug fix and merged in the
v4.18-rc* series.
Ross Zwisl
filesystem on that device mount with the DAX option.
Signed-off-by: Ross Zwisler
Suggested-by: Mike Snitzer
Fixes: commit 545ed20e6df6 ("dm: add infrastructure for DAX support")
Cc: sta...@vger.kernel.org
---
drivers/dax/super.c | 8
1 file changed, 8 insertions(+)
diff --git a/d
a BRD ramdisk which can hold a filesystem
mounted with the -o dax mount option. All I/O to this filesystem
will fail.
---
Changes since v4:
* No code changes.
* Updated the changelogs for patches 1 and 3.
* Removed the Cc: stable from patch 1.
* Added a Fixes: tag to patch 2.
Ross Zw
#x27;struct page' by default for filesystem dax".
Signed-off-by: Ross Zwisler
Suggested-by: Mike Snitzer
---
drivers/nvdimm/pmem.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/nvdimm/pmem.c b/drivers/nvdimm/pmem.c
index 68940356cad3..8b1fd7f1a224 1006
On Wed, Jun 20, 2018 at 11:17:49AM -0400, Mike Snitzer wrote:
> On Mon, Jun 04 2018 at 7:15pm -0400,
> Ross Zwisler wrote:
>
> > On Fri, Jun 01, 2018 at 05:55:13PM -0400, Mike Snitzer wrote:
> > > On Tue, May 29 2018 at 3:51pm -0400,
> > > Ross Zwisler wrote:
On Mon, Jun 04, 2018 at 08:46:28PM -0400, Mike Snitzer wrote:
> On Mon, Jun 04 2018 at 7:24pm -0400,
> Ross Zwisler wrote:
>
> > On Fri, Jun 01, 2018 at 06:04:43PM -0400, Mike Snitzer wrote:
> > > On Tue, May 29 2018 at 3:51pm -0400,
> > > Ross Z
On Fri, Jun 01, 2018 at 05:55:13PM -0400, Mike Snitzer wrote:
> On Tue, May 29 2018 at 3:51pm -0400,
> Ross Zwisler wrote:
>
> > Currently the code in dm_dax_direct_access() only checks whether the target
> > type has a direct_access() operation defined, not whether the
On Fri, Jun 01, 2018 at 06:04:43PM -0400, Mike Snitzer wrote:
> On Tue, May 29 2018 at 3:51pm -0400,
> Ross Zwisler wrote:
>
> > The DM_TYPE_DAX_BIO_BASED dm_queue_mode was introduced to prevent DM
> > devices that could possibly support DAX from transitioning into DM de
On Fri, Jun 01, 2018 at 04:46:04PM -0400, Mike Snitzer wrote:
> On Fri, Jun 01 2018 at 4:19P -0400,
> Mike Snitzer wrote:
>
> > On Tue, May 29 2018 at 3:51P -0400,
> > Ross Zwisler wrote:
> >
> > > Currently device_supports_dax() just checks to see if the
On Thu, May 31, 2018 at 03:26:45PM -0700, Darrick J. Wong wrote:
> On Thu, May 31, 2018 at 04:52:06PM -0400, Mike Snitzer wrote:
> > On Thu, May 31 2018 at 3:13pm -0400,
> > Darrick J. Wong wrote:
> >
> > > On Tue, May 29, 2018 at 04:01:14PM -0600, Ross Zwisler
On Thu, May 31, 2018 at 12:13:32PM -0700, Darrick J. Wong wrote:
> On Tue, May 29, 2018 at 04:01:14PM -0600, Ross Zwisler wrote:
> > On Tue, May 29, 2018 at 02:25:10PM -0700, Darrick J. Wong wrote:
> > > On Tue, May 29, 2018 at 01:51:01PM -0600, Ross Zwisler wrote:
> &
On Thu, May 31, 2018 at 12:13:32PM -0700, Darrick J. Wong wrote:
> On Tue, May 29, 2018 at 04:01:14PM -0600, Ross Zwisler wrote:
> > On Tue, May 29, 2018 at 02:25:10PM -0700, Darrick J. Wong wrote:
> > > On Tue, May 29, 2018 at 01:51:01PM -0600, Ross Zwisler wrote:
> &
dm_dax_direct_access() if QUEUE_FLAG_DAX isn't set we let
the filesystem know we don't support DAX at mount time. The filesystem
will then silently fall back and remove the dax mount option, causing it to
work properly.
Signed-off-by: Ross Zwisler
Fixes: commit 545ed20e6df6 (&quo
This stub was added so that we could use dm-error with
DM_TYPE_DAX_BIO_BASED mode devices. That mode and the transition issues
associated with it no longer exist, so we can remove this dead code.
Signed-off-by: Ross Zwisler
---
drivers/md/dm-target.c | 7 ---
1 file changed, 7 deletions
no DAX
support returns false.
Signed-off-by: Dave Jiang
Signed-off-by: Ross Zwisler
---
drivers/dax/super.c | 16
fs/ext2/super.c | 3 +--
fs/ext4/super.c | 3 +--
fs/xfs/xfs_ioctl.c | 4 ++--
fs/xfs/xfs_super.c | 12 ++--
include/linux/dax.h | 8
6
On Tue, May 29, 2018 at 02:25:10PM -0700, Darrick J. Wong wrote:
> On Tue, May 29, 2018 at 01:51:01PM -0600, Ross Zwisler wrote:
> > From: Dave Jiang
> >
> > The function return values are confusing with the way the function is
> > named. We expect a true or false r
to distinguish between datadev and
rtdev.
This patch fixes the problem where we screw up the dax support checking
in xfs if the datadev and rtdev have different dax capabilities.
Signed-off-by: Darrick J. Wong
[rez: Re-added __bdev_dax_supported() for !CONFIG_FS_DAX cases]
Signed-off-by: Ross Zwisl
This stub was added so that we could use dm-snap with DM_TYPE_DAX_BIO_BASED
mode devices. That mode and the transition issues associated with it no
longer exist, so we can remove this dead code.
Signed-off-by: Ross Zwisler
---
drivers/md/dm-snap.c | 8
1 file changed, 8 deletions
make sure the dax_direct_access() path works.
Signed-off-by: Ross Zwisler
Fixes: commit 545ed20e6df6 ("dm: add infrastructure for DAX support")
---
drivers/md/dm-table.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/md/dm-table.c b/drivers/md/dm-table.
dax: change bdev_dax_supported() to support boolean returns
Ross Zwisler (5):
dm: fix test for DAX device support
dm: prevent DAX mounts if not supported
dm: remove DM_TYPE_DAX_BIO_BASED dm_queue_mode
dm-snap: remove unnecessary direct_access() stub
dm-error: remove unnecessary dire
pand the failure case for the 'p' (persistent memory) flag so
that fails on both architectures that don't support persistent memory and
on kernels that don't have DAX support configured. This prevents us from
ever hitting the BUG() in the persistent_memory_claim() stub.
Signed-off
stem will then know at mount time whether DAX is a
supported mount option or not.
Signed-off-by: Ross Zwisler
---
drivers/md/dm-ioctl.c | 16 ++--
drivers/md/dm-table.c | 25 ++---
drivers/md/dm.c | 2 --
include/linux/device-mapper
On Mon, May 28, 2018 at 05:38:10PM +0200, Arnd Bergmann wrote:
> The new dm-writecache driver inconditionally uses the dax
unconditionally
> subsystem, leading to link errors in some configurations:
>
> drivers/md/dm-writecache.o: In function `writecache_ctr':
> dm-
This stub was added so that we could use dm-snap with DM_TYPE_DAX_BIO_BASED
mode devices. That mode and the transition issues associated with it no
longer exist, so we can remove this dead code.
Signed-off-by: Ross Zwisler
---
drivers/md/dm-snap.c | 8
1 file changed, 8 deletions
On Thu, May 24, 2018 at 10:02:18PM -0700, Darrick J. Wong wrote:
> On Thu, May 24, 2018 at 08:55:12PM -0600, Ross Zwisler wrote:
> > From: "Darrick J. Wong"
> >
> > Remove __bdev_dax_supported and change to bdev_dax_supported that takes a
> > bdev
no DAX
support returns false.
Signed-off-by: Dave Jiang
Signed-off-by: Ross Zwisler
Reviewed-by: Darrick J. Wong
---
drivers/dax/super.c | 16
fs/ext2/super.c | 3 +--
fs/ext4/super.c | 3 +--
fs/xfs/xfs_ioctl.c | 4 ++--
fs/xfs/xfs_super.c | 12
make sure the dax_direct_access() path works.
Signed-off-by: Ross Zwisler
Fixes: commit 545ed20e6df6 ("dm: add infrastructure for DAX support")
---
drivers/md/dm-table.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/md/dm-table.c b/drivers/md/dm-table.
in DM. I feel that this series simplifies the
handling of DAX devices in DM, and the last 5 DM-related patches have a
net code reduction of 50 lines.
Darrick J. Wong (1):
fs: allow per-device dax status checking for filesystems
Dave Jiang (1):
dax: change bdev_dax_supported() to support bo
dm_dax_direct_access() if QUEUE_FLAG_DAX isn't set we let
the filesystem know we don't support DAX at mount time. The filesystem
will then silently fall back and remove the dax mount option, causing it to
work properly.
Signed-off-by: Ross Zwisler
Fixes: commit 545ed20e6df6 (&quo
This stub was added so that we could use dm-error with
DM_TYPE_DAX_BIO_BASED mode devices. That mode and the transition issues
associated with it no longer exist, so we can remove this dead code.
Signed-off-by: Ross Zwisler
---
drivers/md/dm-target.c | 7 ---
1 file changed, 7 deletions
On Fri, May 25, 2018 at 03:54:10PM -0400, Mike Snitzer wrote:
> On Thu, May 24 2018 at 10:55pm -0400,
> Ross Zwisler wrote:
>
> > Currently the code in dm_dax_direct_access() only checks whether the target
> > type has a direct_access() operation defined, not whether the
stem will then know at mount time whether DAX is a
supported mount option or not.
Signed-off-by: Ross Zwisler
---
drivers/md/dm-ioctl.c | 16 ++--
drivers/md/dm-table.c | 25 ++---
drivers/md/dm.c | 2 --
include/linux/device-mapper
of XFS where we need to be able to
distinguish between datadev and rtdev.
This patch fixes the problem where we screw up the dax support checking
in xfs if the datadev and rtdev have different dax capabilities.
Signed-off-by: Darrick J. Wong
Signed-off-by: Ross Zwisler
---
drivers/d
dm_dax_direct_access() if QUEUE_FLAG_DAX isn't set we let
the filesystem know we don't support DAX at mount time. The filesystem
will then silently fall back and remove the dax mount option, causing it to
work properly.
Signed-off-by: Ross Zwisler
Fixes: commit 545ed20e6df6 (&quo
no DAX
support returns false.
Signed-off-by: Dave Jiang
Signed-off-by: Ross Zwisler
---
drivers/dax/super.c | 16
fs/ext2/super.c | 3 +--
fs/ext4/super.c | 3 +--
fs/xfs/xfs_ioctl.c | 4 ++--
fs/xfs/xfs_super.c | 12 ++--
include/linux/dax.h | 6 +++---
6
ches have a
net code reduction of 50 lines.
Darrick J. Wong (1):
fs: allow per-device dax status checking for filesystems
Dave Jiang (1):
dax: change bdev_dax_supported() to support boolean returns
Ross Zwisler (5):
dm: fix test for DAX device support
dm: prevent DAX mounts if not support
This stub was added so that we could use dm-error with
DM_TYPE_DAX_BIO_BASED mode devices. That mode and the transition issues
associated with it no longer exist, so we can remove this dead code.
Signed-off-by: Ross Zwisler
---
drivers/md/dm-target.c | 7 ---
1 file changed, 7 deletions
This stub was added so that we could use dm-snap with DM_TYPE_DAX_BIO_BASED
mode devices. That mode and the transition issues associated with it no
longer exist, so we can remove this dead code.
Signed-off-by: Ross Zwisler
---
drivers/md/dm-snap.c | 8
1 file changed, 8 deletions
make sure the dax_direct_access() path works.
Signed-off-by: Ross Zwisler
Fixes: commit 545ed20e6df6 ("dm: add infrastructure for DAX support")
---
drivers/md/dm-table.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/md/dm-table.c b/drivers/md/dm-table.
stem will then know at mount time whether DAX is a
supported mount option or not.
Signed-off-by: Ross Zwisler
---
drivers/md/dm-ioctl.c | 16 ++--
drivers/md/dm-table.c | 25 ++---
drivers/md/dm.c | 2 --
include/linux/device-mapper
of XFS where we need to be able to
distinguish between datadev and rtdev.
This patch fixes the problem where we screw up the dax support checking
in xfs if the datadev and rtdev have different dax capabilities.
Signed-off-by: Darrick J. Wong
Signed-off-by: Ross Zwisler
---
drivers/d
On Thu, Oct 26, 2017 at 07:59:39AM +0300, Amir Goldstein wrote:
> On Wed, Oct 25, 2017 at 11:47 PM, Ross Zwisler
> wrote:
> > Add a test that exercises DAX's new MAP_SYNC flag.
> >
> > This test creates a file and writes to it via an mmap(), but never syncs
> >
On Thu, Nov 16, 2017 at 02:28:15PM -0700, Ross Zwisler wrote:
> On Thu, Oct 26, 2017 at 08:56:38AM +1100, Dave Chinner wrote:
> > Perhaps stat -c %b $SCRATCH_MNT/test ?
>
> Maybe, but doesn't the output of 'stat -c %b' depend on the block size the
> filesystem i
On Thu, Oct 26, 2017 at 08:56:38AM +1100, Dave Chinner wrote:
> On Wed, Oct 25, 2017 at 02:47:04PM -0600, Ross Zwisler wrote:
> > Add a test that exercises DAX's new MAP_SYNC flag.
> >
> > This test creates a file and writes to it via an mmap(), but never syncs
> >
at we write via the
mmap(), so we can't do any data integrity checking. We can only verify
that the metadata writes for the page faults happened.
Signed-off-by: Ross Zwisler
---
Changes since v2:
- Fixed _require_log_writes() so that DAX will be disallowed if the
version of the dm-log-wr
On Wed, Oct 25, 2017 at 03:19:22PM +0300, Amir Goldstein wrote:
> On Sun, Oct 22, 2017 at 9:56 AM, Amir Goldstein wrote:
> > On Sat, Oct 21, 2017 at 12:25 AM, Ross Zwisler
> > wrote:
> >> Add a test that exercises DAX's new MAP_SYNC flag.
> >>
> >>
On Tue, Oct 24, 2017 at 03:22:23PM -0400, Mike Snitzer wrote:
> On Fri, Oct 20 2017 at 1:24am -0400,
> Ross Zwisler wrote:
>
> > Now that we have the ability log filesystem writes using a flat buffer, add
> > support for DAX. Unfortunately we can't easily track data
On Wed, Oct 25, 2017 at 05:44:34AM +0800, kbuild test robot wrote:
> tree:
> https://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git
> for-next
> head: ae613bbb0144e84cb3c0ebfa9f4fd4d1507c2f0e
> commit: 6a697d036324c7fbe63fb49599027269006161e7 [8/9] dm log writes: add
> su
On Mon, Oct 23, 2017 at 01:34:09PM -0400, Josef Bacik wrote:
> On Thu, Oct 19, 2017 at 11:24:04PM -0600, Ross Zwisler wrote:
> > Now that we have the ability log filesystem writes using a flat buffer, add
> > support for DAX. Unfortunately we can't easily track data that has
at we write via the
mmap(), so we can't do any data integrity checking. We can only verify
that the metadata writes for the page faults happened.
Signed-off-by: Ross Zwisler
---
Changes since v1:
- Addressed review feedback from Amir. Thank you for the review!
---
.gitignore
test that can test
the new MAP_SYNC DAX flag. By logging the filesystem activity with
dm-log-writes we can show that the MAP_SYNC page faults are writing out
their metadata as they happen, instead of requiring an explicit
msync/fsync.
Signed-off-by: Ross Zwisler
---
Here's a link to Jan'
e write via the
mmap(), so we can't do any data integrity checking. We can only verify
that the metadata writes for the page faults happened.
Signed-off-by: Ross Zwisler
---
For this test to run successfully you'll need both Jan's MAP_SYNC series:
https://www.spinics.net/lists/l
nline_data() which allows us to write filesystem data
using a flat buffer as a source, and wire it up in log_one_block().
Signed-off-by: Ross Zwisler
---
drivers/md/dm-log-writes.c | 90 +++---
1 file changed, 86 insertions(+), 4 deletions(-)
diff --git a/
On Sun, Jun 5, 2016 at 1:32 PM, wrote:
> From: Mike Christie
>
> This patch drops the compat definition of req_op where it matches
> the rq_flag_bits definitions, and drops the related old and compat
> code that allowed users to set either the op or flags for the operation.
>
> We also then stor
On Sun, Jun 5, 2016 at 1:32 PM, wrote:
> From: Mike Christie
>
> The req operation REQ_OP is separated from the rq_flag_bits
> definition. This converts the block layer drivers to
> use req_op to get the op from the request struct.
>
> Signed-off-by: Mike Christie
> ---
> drivers/block/loop.c
65 matches
Mail list logo
