On Mon, Sep 25, 2023 at 3:21 PM Xiao Ni wrote:
>
> On Mon, Aug 28, 2023 at 10:04 AM Yu Kuai wrote:
> >
> > From: Yu Kuai
> >
> > Advantages for new apis:
> > - reconfig_mutex is not required;
> > - the weird logical that suspend array hold 'recon
On Mon, Aug 28, 2023 at 10:04 AM Yu Kuai wrote:
>
> From: Yu Kuai
>
> Advantages for new apis:
> - reconfig_mutex is not required;
> - the weird logical that suspend array hold 'reconfig_mutex' for
>mddev_check_recovery() to update superblock is not needed;
> - the specail handling, 'pers-
On Mon, Aug 28, 2023 at 10:04 AM Yu Kuai wrote:
>
> From: Yu Kuai
>
> 'pers->prepare_suspend' is introduced to prevent a deadlock for raid456,
> this change prepares to clean this up in later patches while refactoring
> mddev_suspend(). Specifically allow reshape to make progress while
> waiting
On Mon, Aug 28, 2023 at 10:04 AM Yu Kuai wrote:
>
> From: Yu Kuai
>
> Because reading 'suspend_lo' and 'suspend_hi' from md_handle_request()
> is not protected, use READ_ONCE/WRITE_ONCE to prevent reading abnormal
> value.
Hi Kuai
If we don't use READ_ONCE/WRITE_ONCE, What's the risk here? Coul
On Thu, Jun 15, 2023 at 5:05 PM Yu Kuai wrote:
>
> Hi,
>
> 在 2023/06/15 16:17, Xiao Ni 写道:
> >> Thanks for the example. I can understand the usage of it. It's the
> >> side effect that removes the mutex protection for idle_sync_thread.
> >>
> >&
On Thu, Jun 15, 2023 at 4:01 PM Xiao Ni wrote:
>
> On Thu, Jun 15, 2023 at 9:29 AM Yu Kuai wrote:
> >
> > Hi,
> >
> > 在 2023/06/14 17:08, Xiao Ni 写道:
> > > On Wed, Jun 14, 2023 at 4:29 PM Yu Kuai wrote:
> > >>
> > >> Hi,
> > &
On Thu, Jun 15, 2023 at 9:29 AM Yu Kuai wrote:
>
> Hi,
>
> 在 2023/06/14 17:08, Xiao Ni 写道:
> > On Wed, Jun 14, 2023 at 4:29 PM Yu Kuai wrote:
> >>
> >> Hi,
> >>
> >> 在 2023/06/14 15:57, Xiao Ni 写道:
> >>> On Wed, Jun 14, 2023 at 3:
On Wed, Jun 14, 2023 at 4:29 PM Yu Kuai wrote:
>
> Hi,
>
> 在 2023/06/14 15:57, Xiao Ni 写道:
> > On Wed, Jun 14, 2023 at 3:38 PM Yu Kuai wrote:
> >>
> >> Hi,
> >>
> >> 在 2023/06/14 15:12, Xiao Ni 写道:
> >>> On Wed, Jun 14, 2023 at
On Wed, Jun 14, 2023 at 3:38 PM Yu Kuai wrote:
>
> Hi,
>
> 在 2023/06/14 15:12, Xiao Ni 写道:
> > On Wed, Jun 14, 2023 at 10:04 AM Yu Kuai wrote:
> >>
> >> Hi,
> >>
> >> 在 2023/06/14 9:48, Yu Kuai 写道:
> >>
> >>
ddev->sync_thread))
+ goto unlock;
+
md_reap_sync_thread(mddev);
goto unlock;
}
+
/* Set RUNNING before clearing NEEDED to avoid
* any transients in the value of "sync_action".
+ wake_up(&resync_wait);
}
EXPORT_SYMBOL(md_reap_sync_thread);
Reviewd-by: Xiao Ni
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
On Wed, Jun 14, 2023 at 10:04 AM Yu Kuai wrote:
>
> Hi,
>
> 在 2023/06/14 9:48, Yu Kuai 写道:
>
>
> >>
> >> In the patch, sync_seq is added in md_reap_sync_thread. In
> >> idle_sync_thread, if sync_seq isn't equal
> >>
> >> mddev->sync_seq, it should mean there is someone that stops the sync
> >> thr
On Wed, Jun 14, 2023 at 2:05 PM Yu Kuai wrote:
>
> Hi,
>
> 在 2023/06/14 11:47, Xiao Ni 写道:
> > On Wed, Jun 14, 2023 at 9:48 AM Yu Kuai wrote:
> >>
> >> Hi,
> >>
> >> 在 2023/06/13 22:50, Xiao Ni 写道:
> >>>
> >>> 在 2023
On Wed, Jun 14, 2023 at 9:48 AM Yu Kuai wrote:
>
> Hi,
>
> 在 2023/06/13 22:50, Xiao Ni 写道:
> >
> > 在 2023/5/29 下午9:20, Yu Kuai 写道:
> >> From: Yu Kuai
> >>
> >> Our test found a following deadlock in raid10:
>
在 2023/5/29 下午9:20, Yu Kuai 写道:
From: Yu Kuai
Our test found a following deadlock in raid10:
1) Issue a normal write, and such write failed:
raid10_end_write_request
set_bit(R10BIO_WriteError, &r10_bio->state)
one_write_done
reschedule_retry
// later from md thread
rai
在 2023/5/29 下午9:20, Yu Kuai 写道:
From: Yu Kuai
Currently, for idle and frozen, action_store will hold 'reconfig_mutex'
and call md_reap_sync_thread() to stop sync thread, however, this will
cause deadlock (explained in the next patch). In order to fix the
problem, following patch will release '
在 2023/6/13 下午8:44, Yu Kuai 写道:
Hi,
在 2023/06/13 20:25, Xiao Ni 写道:
On Tue, Jun 13, 2023 at 8:00 PM Yu Kuai wrote:
Hi,
在 2023/06/13 16:02, Xiao Ni 写道:
在 2023/5/29 下午9:20, Yu Kuai 写道:
From: Yu Kuai
Prepare to handle 'idle' and 'frozen' differently to fix a de
On Tue, Jun 13, 2023 at 8:00 PM Yu Kuai wrote:
>
> Hi,
>
> 在 2023/06/13 16:02, Xiao Ni 写道:
> >
> > 在 2023/5/29 下午9:20, Yu Kuai 写道:
> >> From: Yu Kuai
> >>
> >> Prepare to handle 'idle' and 'frozen' differently t
在 2023/5/29 下午9:20, Yu Kuai 写道:
From: Yu Kuai
Prepare to handle 'idle' and 'frozen' differently to fix a deadlock, there
are no functional changes except that MD_RECOVERY_RUNNING is checked
again after 'reconfig_mutex' is held.
Can you explain more about why it needs to check MD_RECOVERY_RU
在 2023/5/29 下午9:20, Yu Kuai 写道:
From: Yu Kuai
This reverts commit 9dfbdafda3b34e262e43e786077bab8e476a89d1.
Because it will introduce a defect that sync_thread can be running while
MD_RECOVERY_RUNNING is cleared, which will cause some unexpected problems,
for example:
list_add corruption. pr
Hi Mikulas
Can we fix this by this:
--- a/drivers/md/md.c
+++ b/drivers/md/md.c
@@ -929,10 +929,10 @@ static void super_written(struct bio *bio)
bio_put(bio);
- rdev_dec_pending(rdev, mddev);
-
if (atomic_dec_and_test(&mddev->pending_writes))
wake_up(&mddev
On Tue, Jan 24, 2023 at 10:06 PM Mikulas Patocka wrote:
>
> There's a theoretical race condition in md.
>
> super_written calls:
> if (atomic_dec_and_test(&mddev->pending_writes))
> wake_up(&mddev->sb_wait);
>
> If the process is rescheduled just after atomic_dec_and_test a
On Fri, Nov 4, 2022 at 7:10 PM Zdenek Kabelac wrote:
>
> Dne 04. 11. 22 v 2:23 Guoqing Jiang napsal(a):
> >
> >
> > On 11/3/22 10:46 PM, Heming Zhao wrote:
> >> On 11/3/22 11:47 AM, Guoqing Jiang wrote:
> >>> Hi,
> >>>
> >>> On 11/3/22 12:27 AM, Mikulas Patocka wrote:
> Hi
>
> There
On Thu, Feb 17, 2022 at 9:10 PM Peter Rajnoha wrote:
>
> On Thu 17 Feb 2022 11:58, Martin Wilck wrote:
> > On Thu, 2022-02-17 at 09:09 +1100, NeilBrown wrote:
> > > On Thu, 17 Feb 2022, mwi...@suse.com wrote:
> > > > From: Martin Wilck
> > > >
> > > > device-mapper sets the flag DM_UDEV_DISABLE_O
24 matches
Mail list logo
