Re: [dm-devel] [PATCH v5 04/18] scsi: Move sd_pr_type to header to share

2023-03-26 Thread michael . christie
On 3/24/23 1:25 PM, Bart Van Assche wrote: > On 3/24/23 11:17, Mike Christie wrote: >> diff --git a/include/scsi/scsi_block_pr.h b/include/scsi/scsi_block_pr.h >> new file mode 100644 >> index ..44766d7a81d8 >> --- /dev/null >> +++ b/include/scsi/scsi_block_pr.h >> @@ -0,0 +1,36 @@ >>

Re: [dm-devel] [PATCH v3 10/19] nvme: Move NVMe and Block PR types to an array

2022-10-31 Thread michael . christie
On 10/27/22 12:06 PM, Mike Christie wrote: > On 10/27/22 10:18 AM, Keith Busch wrote: >> On Wed, Oct 26, 2022 at 06:19:36PM -0500, Mike Christie wrote: >>> For Reservation Report support we need to also convert from the NVMe spec >>> PR type back to the block PR definition. This moves us to an

Re: [dm-devel] [PATCH 2/3] dm: Start pr_reserve from the same starting path

2022-07-18 Thread michael . christie
On 7/18/22 12:39 PM, Mike Christie wrote: > On 7/18/22 12:55 AM, Christoph Hellwig wrote: >> On Thu, Jul 14, 2022 at 07:34:57PM -0500, Mike Christie wrote: >>> I also ran the libiscsi PGR tests. We pass all of those tests except the >>> Write Exclusive and Exclusive Access tests. I don't think

Re: [dm-devel] [PATCH 2/3] dm: Start pr_reserve from the same starting path

2022-07-15 Thread michael . christie
On 7/14/22 7:34 PM, Mike Christie wrote:> I also ran the libiscsi PGR tests. We pass all of those tests except the > Write Exclusive and Exclusive Access tests. I don't think those reservation > types make sense for multipath devices though. And as I write this I'm > thinking we should add a

Re: [dm-devel] [PATCH 09/11] block, nvme: Add error for reservation conflicts.

2022-06-06 Thread michael . christie
On 6/4/22 2:38 AM, Hannes Reinecke wrote: > On 6/3/22 21:45, Keith Busch wrote: >> On Fri, Jun 03, 2022 at 01:55:34AM -0500, Mike Christie wrote: >>> @@ -171,6 +171,7 @@ static const struct { >>>   /* zone device specific errors */ >>>   [BLK_STS_ZONE_OPEN_RESOURCE]    = { -ETOOMANYREFS,

Re: [dm-devel] Question about iscsi session block

2022-02-15 Thread michael . christie
On 2/15/22 7:28 PM, Zhengyuan Liu wrote: > On Wed, Feb 16, 2022 at 12:31 AM Mike Christie > wrote: >> >> On 2/15/22 9:49 AM, Zhengyuan Liu wrote: >>> Hi, all >>> >>> We have an online server which uses multipath + iscsi to attach storage >>> from Storage Server. There are two NICs on the server