Re: [PATCH v6 2/6] x86/mce: relocate set{clear}_mce_nospec() functions

2022-03-22 Thread Jane Chu
On 3/22/2022 3:41 PM, Borislav Petkov wrote: > On Sat, Mar 19, 2022 at 12:28:29AM -0600, Jane Chu wrote: >> Relocate the twin mce functions to arch/x86/mm/pat/set_memory.c >> file where they belong. >> >> Signed-off-by: Jane Chu >> --- >> arch/x86/include/asm/set_memory.h | 52 --

Re: [PATCH v6 2/6] x86/mce: relocate set{clear}_mce_nospec() functions

2022-03-22 Thread Jane Chu
On 3/22/2022 1:42 AM, Christoph Hellwig wrote: >> +EXPORT_SYMBOL(set_mce_nospec); > > No need for this export at all. Indeed, my bad, will remove it. > >> + >> +/* Restore full speculative operation to the pfn. */ >> +int clear_mce_nospec(unsigned long pfn) >> +{ >> +return set_memory_wb((u

Re: [PATCH v6 2/6] x86/mce: relocate set{clear}_mce_nospec() functions

2022-03-22 Thread Christoph Hellwig
> +EXPORT_SYMBOL(set_mce_nospec); No need for this export at all. > + > +/* Restore full speculative operation to the pfn. */ > +int clear_mce_nospec(unsigned long pfn) > +{ > + return set_memory_wb((unsigned long) pfn_to_kaddr(pfn), 1); > +} > +EXPORT_SYMBOL(clear_mce_nospec); And this shou

Re: [PATCH v6 2/6] x86/mce: relocate set{clear}_mce_nospec() functions

2022-03-19 Thread kernel test robot
Hi Jane, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on nvdimm/libnvdimm-for-next] [also build test WARNING on device-mapper-dm/for-next linus/master v5.17-rc8 next-20220318] [cannot apply to tip/x86/mm] [If your patch is applied to the wrong git tree, kindly

Re: [PATCH v6 2/6] x86/mce: relocate set{clear}_mce_nospec() functions

2022-03-19 Thread kernel test robot
Hi Jane, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on nvdimm/libnvdimm-for-next] [also build test WARNING on device-mapper-dm/for-next linus/master v5.17-rc8 next-20220318] [cannot apply to tip/x86/mm] [If your patch is applied to the wrong git tree, kindly

[PATCH v6 2/6] x86/mce: relocate set{clear}_mce_nospec() functions

2022-03-18 Thread Jane Chu
Relocate the twin mce functions to arch/x86/mm/pat/set_memory.c file where they belong. Signed-off-by: Jane Chu --- arch/x86/include/asm/set_memory.h | 52 --- arch/x86/mm/pat/set_memory.c | 48 include/linux/set_memory.h| 9