Re: [PATCH v7 2/7] fs: crypto: invoke crypto API for ESSIV handling

2019-07-03 Thread Ard Biesheuvel
On Wed, 3 Jul 2019 at 00:06, Ard Biesheuvel wrote: > > On Tue, 2 Jul 2019 at 23:55, Eric Biggers wrote: > > > > Hi Ard, > > > > On Tue, Jul 02, 2019 at 06:48:10PM +0200, Ard Biesheuvel wrote: > > > Instead of open coding the calculations for ESSIV handling, use a > > > ESSIV skcipher which does

Re: [dm-devel] [PATCH v7 2/7] fs: crypto: invoke crypto API for ESSIV handling

2019-07-02 Thread Ard Biesheuvel
On Tue, 2 Jul 2019 at 23:55, Eric Biggers wrote: > > Hi Ard, > > On Tue, Jul 02, 2019 at 06:48:10PM +0200, Ard Biesheuvel wrote: > > Instead of open coding the calculations for ESSIV handling, use a > > ESSIV skcipher which does all of this under the hood. > > > > Signed-off-by: Ard Biesheuvel >

Re: [dm-devel] [PATCH v7 2/7] fs: crypto: invoke crypto API for ESSIV handling

2019-07-02 Thread Eric Biggers
Hi Ard, On Tue, Jul 02, 2019 at 06:48:10PM +0200, Ard Biesheuvel wrote: > Instead of open coding the calculations for ESSIV handling, use a > ESSIV skcipher which does all of this under the hood. > > Signed-off-by: Ard Biesheuvel > --- > fs/crypto/Kconfig | 1 + > fs/crypto/crypto.c

[PATCH v7 2/7] fs: crypto: invoke crypto API for ESSIV handling

2019-07-02 Thread Ard Biesheuvel
Instead of open coding the calculations for ESSIV handling, use a ESSIV skcipher which does all of this under the hood. Signed-off-by: Ard Biesheuvel --- fs/crypto/Kconfig | 1 + fs/crypto/crypto.c | 5 -- fs/crypto/fscrypt_private.h | 9 -- fs/crypto/keyinfo.c |