Re: [PATCH v8 1/7] crypto: essiv - create wrapper template for ESSIV generation

2019-08-14 Thread Herbert Xu
On Sat, Aug 03, 2019 at 10:36:44AM +0300, Ard Biesheuvel wrote: > > To use your GCM analogy: gcm_base(ctr-ppc-spe, ghash-generic) is a > supported aead identifier, but there is nothing in the name that > identifies the skcipher as one that encapsulates AES. I would've thought that you would

Re: [PATCH v8 1/7] crypto: essiv - create wrapper template for ESSIV generation

2019-08-01 Thread Herbert Xu
On Fri, Jul 26, 2019 at 12:00:20PM +0300, Ard Biesheuvel wrote: > > For Y and Z, it is not straightforward either: since the crypto API > permits the use of driver names in addition to the plain CRA names, > we'd have to infer from the first parameter which cipher is being > used. We don't really

Re: [PATCH v8 1/7] crypto: essiv - create wrapper template for ESSIV generation

2019-07-26 Thread Ard Biesheuvel
On Fri, 26 Jul 2019 at 07:31, Herbert Xu wrote: > > Ard Biesheuvel wrote: > > > > + * The typical use of this template is to instantiate the skcipher > > + * 'essiv(cbc(aes),aes,sha256)', which is the only instantiation used by > > + * fscrypt, and the most relevant one for dm-crypt. However,

Re: [PATCH v8 1/7] crypto: essiv - create wrapper template for ESSIV generation

2019-07-25 Thread Herbert Xu
Ard Biesheuvel wrote: > > + * The typical use of this template is to instantiate the skcipher > + * 'essiv(cbc(aes),aes,sha256)', which is the only instantiation used by > + * fscrypt, and the most relevant one for dm-crypt. However, dm-crypt > + * also permits ESSIV to be used in combination

[PATCH v8 1/7] crypto: essiv - create wrapper template for ESSIV generation

2019-07-04 Thread Ard Biesheuvel
Implement a template that wraps a (skcipher,cipher,shash) or (aead,cipher,shash) tuple so that we can consolidate the ESSIV handling in fscrypt and dm-crypt and move it into the crypto API. This will result in better test coverage, and will allow future changes to make the bare cipher interface