Re: [dm-devel] [PATCH] kpartx: Add -P option for partition scanning

2022-03-03 Thread Ritika Srivastava
On 3/3/22, 2:57 AM, "Martin Wilck" wrote: > I agree. kpartx is a tool for creating linear dm mappings that behave > roughly like partitions. And it should stay that way. We (made the > mistake to) add convenience functionality to setup loop devices when > kpartx is called with a re

Re: [dm-devel] [PATCH] kpartx: Add -P option for partition scanning

2022-03-02 Thread Benjamin Marzinski
On Wed, Mar 02, 2022 at 12:07:11AM +, Ritika Srivastava wrote: > On 2/28/22, 2:44 PM, "Benjamin Marzinski" wrote: > > > So unless I'm missing something, we'd only really want this for removing > > a kpartx device, in the case where somehow you have /dev/loopXpY > > partitions witho

Re: [dm-devel] [PATCH] kpartx: Add -P option for partition scanning

2022-03-01 Thread Ritika Srivastava
On 2/28/22, 2:44 PM, "Benjamin Marzinski" wrote: > So unless I'm missing something, we'd only really want this for removing > a kpartx device, in the case where somehow you have /dev/loopXpY > partitions without the LO_FLAGS_PARTSCAN flag set on the disk. That That's correct. We only

Re: [dm-devel] [PATCH] kpartx: Add -P option for partition scanning

2022-02-28 Thread Benjamin Marzinski
On Tue, Feb 22, 2022 at 10:16:35PM +, Ritika Srivastava wrote: > Ben, > > Thank you for reviewing this. > > On 2/22/22, 11:32 AM, "Benjamin Marzinski" wrote: > >> And I'm trying to figure out why you want to create /dev/loop0p1 if you >> already have /dev/mapper/loop0p1? The ability

Re: [dm-devel] [PATCH] kpartx: Add -P option for partition scanning

2022-02-22 Thread Ritika Srivastava
Ben, Thank you for reviewing this. On 2/22/22, 11:32 AM, "Benjamin Marzinski" wrote: > And I'm trying to figure out why you want to create /dev/loop0p1 if you > already have /dev/mapper/loop0p1? The ability of kpartx to create > partitioned loop devices predates the existance "kpartx -

Re: [dm-devel] [PATCH] kpartx: Add -P option for partition scanning

2022-02-22 Thread Ritika Srivastava
On 2/22/22, 10:28 AM, "Benjamin Marzinski" wrote: On Fri, Feb 11, 2022 at 12:41:48PM -0800, Ritika Srivastava wrote: >> Add -P, partition scanning option to kpartx which would set >> LO_FLAGS_PARTSCAN flag during loop device creation. >> This option is same as losetup -P option.

Re: [dm-devel] [PATCH] kpartx: Add -P option for partition scanning

2022-02-22 Thread Benjamin Marzinski
On Tue, Feb 22, 2022 at 06:59:10PM +, Ritika Srivastava wrote: > On 2/22/22, 10:28 AM, "Benjamin Marzinski" wrote: > > On Fri, Feb 11, 2022 at 12:41:48PM -0800, Ritika Srivastava wrote: > >> Add -P, partition scanning option to kpartx which would set > >> LO_FLAGS_PARTSCAN flag dur

Re: [dm-devel] [PATCH] kpartx: Add -P option for partition scanning

2022-02-22 Thread Benjamin Marzinski
On Fri, Feb 11, 2022 at 12:41:48PM -0800, Ritika Srivastava wrote: > Add -P, partition scanning option to kpartx which would set > LO_FLAGS_PARTSCAN flag during loop device creation. > This option is same as losetup -P option. I'm confused here. What's the benefit of doing this? Doesn't this creat

Re: [dm-devel] [PATCH] kpartx: Add -P option for partition scanning

2022-02-22 Thread Ritika Srivastava
Hi, Gentle ping Please help review this. -- Thanks, Ritika On 2/11/22, 3:51 PM, Ritika Srivastava wrote: Add -P, partition scanning option to kpartx which would set LO_FLAGS_PARTSCAN flag during loop device creation. This option is same as losetup -P option. S

[dm-devel] [PATCH] kpartx: Add -P option for partition scanning

2022-02-11 Thread Ritika Srivastava
Add -P, partition scanning option to kpartx which would set LO_FLAGS_PARTSCAN flag during loop device creation. This option is same as losetup -P option. Signed-off-by: Ritika Srivastava --- kpartx/kpartx.c | 17 + kpartx/lopart.c | 5 - kpartx/lopart.h | 2 +- 3 files chan

[dm-devel] [PATCH] kpartx: Add -P option for partition scanning

2022-02-11 Thread Ritika Srivastava
Add -P, partition scanning option to kpartx which would set LO_FLAGS_PARTSCAN flag during loop device creation. This option is same as losetup -P option. Signed-off-by: Ritika Srivastava --- kpartx/kpartx.c | 17 + kpartx/lopart.c | 5 - kpartx/lopart.h | 2 +- 3 files chan