Re: [dm-devel] [PATCH] persistent-data: fix bug about btree of updating internal node's minima key in btree_split_beneath.

2017-12-19 Thread Joe Thornber
On Mon, Dec 18, 2017 at 05:34:09PM +, Joe Thornber wrote: > Patch below. This is completely untested. I'll test tomorrow and update. The patch appears to work. I'm using this test to reproduce the problem:

Re: [dm-devel] [PATCH] persistent-data: fix bug about btree of updating internal node's minima key in btree_split_beneath.

2017-12-18 Thread monty
Look forward to your test result. The scene I found with problem as follows: note: 1. key size: 8; 2. value size: 8; 3. max_entries=252; 4. one level btree's root is A. operations: 1. A's info: nr_entries=252 keys:127-378 2. insert 379 to btree

Re: [dm-devel] [PATCH] persistent-data: fix bug about btree of updating internal node's minima key in btree_split_beneath.

2017-12-18 Thread Joe Thornber
On Mon, Dec 18, 2017 at 05:13:08PM +, Joe Thornber wrote: > Hi Monty, > > On Mon, Dec 18, 2017 at 04:27:58PM -0500, monty wrote: > > Subject: [PATCH] persistent-data: fix bug about btree of updating internal > > node's minima > > key in btree_split_beneath. > > > > fix bug about

Re: [dm-devel] [PATCH] persistent-data: fix bug about btree of updating internal node's minima key in btree_split_beneath.

2017-12-18 Thread Joe Thornber
Hi Monty, On Mon, Dec 18, 2017 at 04:27:58PM -0500, monty wrote: > Subject: [PATCH] persistent-data: fix bug about btree of updating internal > node's minima > key in btree_split_beneath. > > fix bug about btree_split_beneath func, this bug may cause a key had > been inserted to btree, but

[dm-devel] [PATCH] persistent-data: fix bug about btree of updating internal node's minima key in btree_split_beneath.

2017-12-18 Thread monty
Signed-off-by: monty --- drivers/md/persistent-data/dm-btree.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/md/persistent-data/dm-btree.c b/drivers/md/persistent-data/dm-btree.c index f21ce6a..25ce5ec 100644 ---