Re: [dm-devel] [PATCH] thin_dump: added --device-id, --skip-mappings, and new output --format's

2016-03-20 Thread Ming-Hung Tsai
2016-03-18 6:45 GMT+08:00 Eric Wheeler : > > On Thu, 17 Mar 2016, Joe Thornber wrote: > >> If you're skipping the mappings does the new thin_ls provide enough >> information for you? > > Our primary need is the ability to specify --device-id in the o:L:d output >

Re: [dm-devel] [PATCH] thin_dump: added --device-id, --skip-mappings, and new output --format's

2016-03-19 Thread Joe Thornber
On Tue, Mar 15, 2016 at 10:59:15AM +, Thanos Makatos wrote: > On 15 March 2016 at 01:45, Eric Wheeler wrote: > > Hi Joe, > > > > Please review the patch below when you have a moment. I am interested in > > your feedback, and also interested in having this

Re: [dm-devel] [PATCH] thin_dump: added --device-id, --skip-mappings, and new output --format's

2016-03-19 Thread Ming-Hung Tsai
2016-03-18 6:45 GMT+08:00 Eric Wheeler : > > On Thu, 17 Mar 2016, Joe Thornber wrote: > >> If you're skipping the mappings does the new thin_ls provide enough >> information for you? > > Our primary need is the ability to specify --device-id in the o:L:d output >

Re: [dm-devel] [PATCH] thin_dump: added --device-id, --skip-mappings, and new output --format's

2016-03-19 Thread Eric Wheeler
On Wed, 16 Mar 2016, Ming-Hung Tsai wrote: > 2016-03-16 1:51 GMT+08:00 Eric Wheeler : > > On Tue, 15 Mar 2016, Thanos Makatos wrote: > > > >> On 15 March 2016 at 01:45, Eric Wheeler > >> wrote: > >> > Hi Joe, > >> > > >> > We use

Re: [dm-devel] [PATCH] thin_dump: added --device-id, --skip-mappings, and new output --format's

2016-03-19 Thread Eric Wheeler
On Thu, 17 Mar 2016, Joe Thornber wrote: > If you're skipping the mappings does the new thin_ls provide enough > information for you? Our primary need is the ability to specify --device-id in the o:L:d output format (old_format.cc) with mappings. Our nightly dumps now take 50 seconds instead

Re: [dm-devel] [PATCH] thin_dump: added --device-id, --skip-mappings, and new output --format's

2016-03-19 Thread Joe Thornber
If you're skipping the mappings does the new thin_ls provide enough information for you? - Joe On Tue, Mar 15, 2016 at 01:45:15AM +, Eric Wheeler wrote: > Hi Joe, > > Please review the patch below when you have a moment. I am interested in > your feedback, and also interested in having

Re: [dm-devel] [PATCH] thin_dump: added --device-id, --skip-mappings, and new output --format's

2016-03-15 Thread Eric Wheeler
On Tue, 15 Mar 2016, Thanos Makatos wrote: > On 15 March 2016 at 01:45, Eric Wheeler wrote: > > Hi Joe, > > > > Please review the patch below when you have a moment. I am interested in > > your feedback, and also interested in having this functionality merged > >

Re: [dm-devel] [PATCH] thin_dump: added --device-id, --skip-mappings, and new output --format's

2016-03-15 Thread Thanos Makatos
On 15 March 2016 at 01:45, Eric Wheeler wrote: > Hi Joe, > > Please review the patch below when you have a moment. I am interested in > your feedback, and also interested in having this functionality merged > upstream. This was written against