Re: [dm-devel] [PATCH -next v3 00/25] md: synchronize io with array reconfiguration

2023-10-06 Thread Yu Kuai
Hi, 在 2023/10/07 10:40, Song Liu 写道: Can you take a look about this new cover letter? I don't have time right now to look into all the details, but it looks great at first glance. We can still edit it a little bit when applying the patchset, but that may not be necessary. Yeah, it's not urge

Re: [dm-devel] [PATCH -next v3 00/25] md: synchronize io with array reconfiguration

2023-10-06 Thread Song Liu
On Fri, Oct 6, 2023 at 7:32 PM Yu Kuai wrote: > > Hi, > > 在 2023/10/05 11:55, Song Liu 写道: > > On Wed, Oct 4, 2023 at 8:42 PM Yu Kuai wrote: > >> > >> Hi, > >> > >> 在 2023/09/29 3:15, Song Liu 写道: > >>> Hi Kuai, > >>> > >>> Thanks for the patchset! > >>> > >>> A few high level questions/suggestio

Re: [dm-devel] [PATCH -next v3 00/25] md: synchronize io with array reconfiguration

2023-10-06 Thread Yu Kuai
Hi, 在 2023/10/05 11:55, Song Liu 写道: On Wed, Oct 4, 2023 at 8:42 PM Yu Kuai wrote: Hi, 在 2023/09/29 3:15, Song Liu 写道: Hi Kuai, Thanks for the patchset! A few high level questions/suggestions: Thanks a lot for these! 1. This is a big change that needs a lot of explanation. While you m

Re: [dm-devel] [PATCH -next v3 00/25] md: synchronize io with array reconfiguration

2023-10-04 Thread Song Liu
On Wed, Oct 4, 2023 at 8:42 PM Yu Kuai wrote: > > Hi, > > 在 2023/09/29 3:15, Song Liu 写道: > > Hi Kuai, > > > > Thanks for the patchset! > > > > A few high level questions/suggestions: > > Thanks a lot for these! > > > > 1. This is a big change that needs a lot of explanation. While you managed >

Re: [dm-devel] [PATCH -next v3 00/25] md: synchronize io with array reconfiguration

2023-10-04 Thread Yu Kuai
Hi, 在 2023/09/29 3:15, Song Liu 写道: Hi Kuai, Thanks for the patchset! A few high level questions/suggestions: Thanks a lot for these! 1. This is a big change that needs a lot of explanation. While you managed to keep each patch relatively small (great job btw), it is not very clear why we

Re: [dm-devel] [PATCH -next v3 00/25] md: synchronize io with array reconfiguration

2023-09-28 Thread Song Liu
Hi Kuai, Thanks for the patchset! A few high level questions/suggestions: 1. This is a big change that needs a lot of explanation. While you managed to keep each patch relatively small (great job btw), it is not very clear why we need these changes. Specifically, we are adding a new mutex, it is

[dm-devel] [PATCH -next v3 00/25] md: synchronize io with array reconfiguration

2023-09-27 Thread Yu Kuai
From: Yu Kuai Changes in v3: - rebase with latest md-next; - remove patch 2 from v2, and replace it with a new patch; - fix a null-ptr-derefrence in rdev_attr_store() that mddev is used before checking; - merge patch 20-22 from v1 into one patch; - mddev_lock() used to be called first and c