Re: [dm-devel] [PATCH 0/1] t10-pi bio split fix

2022-02-03 Thread Milan Broz
On 04/02/2022 04:44, Martin K. Petersen wrote: Dmitry, My only concern is dm_crypt target which operates on bip_iter directly with the code copy-pasted from bio_integrity_advance: static int dm_crypt_integrity_io_alloc(struct dm_crypt_io *io, struct bio *bio) { struct bio_integrity_pa

Re: [dm-devel] [PATCH 0/1] t10-pi bio split fix

2022-02-04 Thread Lyashkov, Alexey
Milan, I and Dmitriy tries to fix a problem with BIO split with integrity data attached. This is case, integrity generated/attached before bio_submit over raid device (md stack in my case) and bio is subject of bio_integrity_advance. But bio_integrity_advance incorrectly split an integrity data,

Re: [dm-devel] [PATCH 0/1] t10-pi bio split fix

2022-02-07 Thread Ivanov, Dmitry (HPC)
On 04/02/2022 08:43 +0100, Milan Broz wrote: > What's the problem here you are trying to fix? > Even if I read linux-block posts, I do not understand the context.. 1. Let me demonstrate this issue with the following example. Given a driver which maps a bio to underlying devices with 4096 logical