Re: [dm-devel] [PATCH 0/4] remove dangerous cleanup __attribute__ uses

2022-10-20 Thread Benjamin Marzinski
On Thu, Oct 20, 2022 at 04:03:46PM +, Martin Wilck wrote: > On Tue, 2022-10-11 at 16:52 -0500, Benjamin Marzinski wrote: > > the cleanup __attribute__ is only run when a variable goes out of > > scope > > normally. It is not run on pthread cancellation. This means that > > multipathd could

Re: [dm-devel] [PATCH 0/4] remove dangerous cleanup __attribute__ uses

2022-10-20 Thread Martin Wilck
On Tue, 2022-10-11 at 16:52 -0500, Benjamin Marzinski wrote: > the cleanup __attribute__ is only run when a variable goes out of > scope > normally. It is not run on pthread cancellation. This means that > multipathd could leak whatever resources were supposed to be cleaned > up > if the thread

[dm-devel] [PATCH 0/4] remove dangerous cleanup __attribute__ uses

2022-10-11 Thread Benjamin Marzinski
the cleanup __attribute__ is only run when a variable goes out of scope normally. It is not run on pthread cancellation. This means that multipathd could leak whatever resources were supposed to be cleaned up if the thread was cancelled in a function using variables with the cleanup __attribute__.