Re: [dm-devel] [PATCH 00/10] fixes for kpartx -d

2017-05-08 Thread Benjamin Marzinski
On Sat, May 06, 2017 at 12:05:49AM +0200, Martin Wilck wrote: > Working on a bug report about kpartx not properly removing > partitions for loop devices, I realized a number of glitches > and improperly handled corner cases in the kpartx code for > deleting partitions. Some mappings are not deleted

Re: [dm-devel] [PATCH 00/10] fixes for kpartx -d

2017-05-08 Thread Martin Wilck
On Mon, 2017-05-08 at 09:47 +0200, Martin Wilck wrote: > The full partition UUID for partitions used by my code looks like > this > (see patch 08/10): > > {UUID_PREFIX}${MAJOR}:${MINOR}-${NONDM_UUID_SUFFIX}" ... where UUID_PREFIX is what kpartx uses anyway, i.e. "part$N". Martin -- Dr. Martin

Re: [dm-devel] [PATCH 00/10] fixes for kpartx -d

2017-05-08 Thread Martin Wilck
On Mon, 2017-05-08 at 08:33 +0200, Hannes Reinecke wrote: > On 05/06/2017 12:30 AM, Martin Wilck wrote: > > On Fri, 2017-05-05 at 23:18 +0100, Alasdair G Kergon wrote: > > > On Sat, May 06, 2017 at 12:05:49AM +0200, Martin Wilck wrote: > > > >   3) kpartx should only delete "partitions", which are

Re: [dm-devel] [PATCH 00/10] fixes for kpartx -d

2017-05-07 Thread Hannes Reinecke
On 05/06/2017 12:30 AM, Martin Wilck wrote: > On Fri, 2017-05-05 at 23:18 +0100, Alasdair G Kergon wrote: >> On Sat, May 06, 2017 at 12:05:49AM +0200, Martin Wilck wrote: >>> 3) kpartx should only delete "partitions", which are single- >>> target >>> linear mappings into a block device. Othe

Re: [dm-devel] [PATCH 00/10] fixes for kpartx -d

2017-05-05 Thread Martin Wilck
On Sat, 2017-05-06 at 00:30 +0200, Martin Wilck wrote: > On Fri, 2017-05-05 at 23:18 +0100, Alasdair G Kergon wrote: > > On Sat, May 06, 2017 at 12:05:49AM +0200, Martin Wilck wrote: > > >   3) kpartx should only delete "partitions", which are single- > > > target > > >  linear mappings into a

Re: [dm-devel] [PATCH 00/10] fixes for kpartx -d

2017-05-05 Thread Martin Wilck
On Fri, 2017-05-05 at 23:18 +0100, Alasdair G Kergon wrote: > On Sat, May 06, 2017 at 12:05:49AM +0200, Martin Wilck wrote: > >   3) kpartx should only delete "partitions", which are single- > > target > >  linear mappings into a block device. Other maps should not be > > touched. > > The pref

Re: [dm-devel] [PATCH 00/10] fixes for kpartx -d

2017-05-05 Thread Alasdair G Kergon
On Sat, May 06, 2017 at 12:05:49AM +0200, Martin Wilck wrote: > 3) kpartx should only delete "partitions", which are single-target > linear mappings into a block device. Other maps should not be touched. The prefix on the dm device's uuid should guarantee this: all devices kpartx creates sh

[dm-devel] [PATCH 00/10] fixes for kpartx -d

2017-05-05 Thread Martin Wilck
Working on a bug report about kpartx not properly removing partitions for loop devices, I realized a number of glitches and improperly handled corner cases in the kpartx code for deleting partitions. Some mappings are not deleted although they should be, and others are deleted although that is clea