Re: [dm-devel] [PATCH 01/19] fs: remove mpage_alloc

2022-03-24 Thread Ryusuke Konishi
On Wed, Mar 23, 2022 at 3:42 PM Christoph Hellwig wrote: > > On Wed, Mar 23, 2022 at 06:38:22AM +0900, Ryusuke Konishi wrote: > > This looks because the mask of GFP_KERNEL is removed along with > > the removal of mpage_alloc(). > > > > > The default value of the gfp flag is set to

Re: [dm-devel] [PATCH 01/19] fs: remove mpage_alloc

2022-03-24 Thread Ryusuke Konishi
On Wed, Mar 23, 2022 at 6:19 AM Guenter Roeck wrote: > > On Mon, Jan 24, 2022 at 10:10:49AM +0100, Christoph Hellwig wrote: > > open code mpage_alloc in it's two callers and simplify the results > > because of the context: > > > > - __mpage_writepage always passes GFP_NOFS and can thus always

Re: [dm-devel] [PATCH 01/19] fs: remove mpage_alloc

2022-03-23 Thread Guenter Roeck
On Wed, Mar 23, 2022 at 07:42:48AM +0100, Christoph Hellwig wrote: > On Wed, Mar 23, 2022 at 06:38:22AM +0900, Ryusuke Konishi wrote: > > This looks because the mask of GFP_KERNEL is removed along with > > the removal of mpage_alloc(). > > > > > The default value of the gfp flag is set to

Re: [dm-devel] [PATCH 01/19] fs: remove mpage_alloc

2022-03-23 Thread Christoph Hellwig
On Wed, Mar 23, 2022 at 06:38:22AM +0900, Ryusuke Konishi wrote: > This looks because the mask of GFP_KERNEL is removed along with > the removal of mpage_alloc(). > > The default value of the gfp flag is set to GFP_HIGHUSER_MOVABLE by > inode_init_always(). > So, __GFP_HIGHMEM hits the gfp

Re: [dm-devel] [PATCH 01/19] fs: remove mpage_alloc

2022-03-22 Thread Guenter Roeck
On Mon, Jan 24, 2022 at 10:10:49AM +0100, Christoph Hellwig wrote: > open code mpage_alloc in it's two callers and simplify the results > because of the context: > > - __mpage_writepage always passes GFP_NOFS and can thus always sleep and > will never get a NULL return from bio_alloc at all.

[dm-devel] [PATCH 01/19] fs: remove mpage_alloc

2022-01-24 Thread Christoph Hellwig
open code mpage_alloc in it's two callers and simplify the results because of the context: - __mpage_writepage always passes GFP_NOFS and can thus always sleep and will never get a NULL return from bio_alloc at all. - do_mpage_readpage can only get a non-sleeping context for readahead

[dm-devel] [PATCH 01/19] fs: remove mpage_alloc

2022-01-17 Thread Christoph Hellwig
open code mpage_alloc in it's two callers and simplify the results because of the context: - __mpage_writepage always passes GFP_NOFS and can thus always sleep and will never get a NULL return from bio_alloc at all. - do_mpage_readpage can only get a non-sleeping context for readahead