Re: [dm-devel] [PATCH 04/31] cdrom: remove the unused cdrom_close_write release code

2023-06-07 Thread Christian Brauner
On Tue, Jun 06, 2023 at 09:39:23AM +0200, Christoph Hellwig wrote: > cdrom_close_write is empty, and the for_data flag it is keyed off is > never set. Remove all this clutter. > > Signed-off-by: Christoph Hellwig > --- Looks good to me, Acked-by: Christian Brauner -- dm-devel mailing list dm-

Re: [dm-devel] [PATCH 04/31] cdrom: remove the unused cdrom_close_write release code

2023-06-07 Thread Hannes Reinecke
On 6/6/23 09:39, Christoph Hellwig wrote: cdrom_close_write is empty, and the for_data flag it is keyed off is never set. Remove all this clutter. Signed-off-by: Christoph Hellwig --- drivers/cdrom/cdrom.c | 15 --- include/linux/cdrom.h | 1 - 2 files changed, 16 deletions(-)

Re: [dm-devel] [PATCH 04/31] cdrom: remove the unused cdrom_close_write release code

2023-06-06 Thread Phillip Potter
On Tue, Jun 06, 2023 at 09:39:23AM +0200, Christoph Hellwig wrote: > cdrom_close_write is empty, and the for_data flag it is keyed off is > never set. Remove all this clutter. > > Signed-off-by: Christoph Hellwig > --- > drivers/cdrom/cdrom.c | 15 --- > include/linux/cdrom.h | 1 -

[dm-devel] [PATCH 04/31] cdrom: remove the unused cdrom_close_write release code

2023-06-06 Thread Christoph Hellwig
cdrom_close_write is empty, and the for_data flag it is keyed off is never set. Remove all this clutter. Signed-off-by: Christoph Hellwig --- drivers/cdrom/cdrom.c | 15 --- include/linux/cdrom.h | 1 - 2 files changed, 16 deletions(-) diff --git a/drivers/cdrom/cdrom.c b/drivers/