Re: [dm-devel] [PATCH 04/45] fs: simplify freeze_bdev/thaw_bdev

2020-11-30 Thread Darrick J. Wong
On Sat, Nov 28, 2020 at 05:14:29PM +0100, Christoph Hellwig wrote: > Store the frozen superblock in struct block_device to avoid the awkward > interface that can return a sb only used a cookie, an ERR_PTR or NULL. > > Signed-off-by: Christoph Hellwig > Reviewed-by: Jan Kara > Acked-by: Chao Yu

[dm-devel] [PATCH 04/45] fs: simplify freeze_bdev/thaw_bdev

2020-11-28 Thread Christoph Hellwig
Store the frozen superblock in struct block_device to avoid the awkward interface that can return a sb only used a cookie, an ERR_PTR or NULL. Signed-off-by: Christoph Hellwig Reviewed-by: Jan Kara Acked-by: Chao Yu [f2fs] --- drivers/md/dm-core.h | 5 - drivers/md/dm.c

Re: [dm-devel] [PATCH 04/45] fs: simplify freeze_bdev/thaw_bdev

2020-11-25 Thread Christoph Hellwig
On Wed, Nov 25, 2020 at 01:29:53PM +0100, Jan Kara wrote: > > mutex_unlock(>bd_fsfreeze_mutex); > > - return sb; /* thaw_bdev releases s->s_umount */ > > + return error; /* thaw_bdev releases s->s_umount */ > > The comment about thaw_bdev() seems to be stale? At least I don't see

Re: [dm-devel] [PATCH 04/45] fs: simplify freeze_bdev/thaw_bdev

2020-11-25 Thread Jan Kara
On Tue 24-11-20 14:27:10, Christoph Hellwig wrote: > Store the frozen superblock in struct block_device to avoid the awkward > interface that can return a sb only used a cookie, an ERR_PTR or NULL. > > Signed-off-by: Christoph Hellwig Some comments below... > diff --git a/fs/block_dev.c

Re: [dm-devel] [PATCH 04/45] fs: simplify freeze_bdev/thaw_bdev

2020-11-24 Thread Chao Yu
On 2020/11/24 21:27, Christoph Hellwig wrote: Store the frozen superblock in struct block_device to avoid the awkward interface that can return a sb only used a cookie, an ERR_PTR or NULL. Signed-off-by: Christoph Hellwig --- drivers/md/dm-core.h | 5 - drivers/md/dm.c |

[dm-devel] [PATCH 04/45] fs: simplify freeze_bdev/thaw_bdev

2020-11-24 Thread Christoph Hellwig
Store the frozen superblock in struct block_device to avoid the awkward interface that can return a sb only used a cookie, an ERR_PTR or NULL. Signed-off-by: Christoph Hellwig --- drivers/md/dm-core.h | 5 - drivers/md/dm.c | 20 ++-- fs/block_dev.c