Re: [dm-devel] [PATCH 05/11] block: get rid of the trace rq insert wrapper

2020-07-07 Thread h...@lst.de
On Fri, Jul 03, 2020 at 11:29:25PM +, Chaitanya Kulkarni wrote: > Christoph, > > On 6/29/20 4:44 PM, Chaitanya Kulkarni wrote: > > Get rid of the wrapper for trace_block_rq_insert() and call the function > > directly. > > > > Signed-off-by: Chaitanya Kulkarni > > --- > > Can we re-consider

Re: [dm-devel] [PATCH 05/11] block: get rid of the trace rq insert wrapper

2020-07-03 Thread Chaitanya Kulkarni
Christoph, On 6/29/20 4:44 PM, Chaitanya Kulkarni wrote: > Get rid of the wrapper for trace_block_rq_insert() and call the function > directly. > > Signed-off-by: Chaitanya Kulkarni > --- Can we re-consider adding this patch ? here are couple of reasons:- 1. Increase in the size of the text

Re: [dm-devel] [PATCH 05/11] block: get rid of the trace rq insert wrapper

2020-06-30 Thread Chaitanya Kulkarni
On 6/29/20 10:11 PM, Christoph Hellwig wrote: > On Mon, Jun 29, 2020 at 04:43:08PM -0700, Chaitanya Kulkarni wrote: >> Get rid of the wrapper for trace_block_rq_insert() and call the function >> directly. > I'd mention blk_mq_sched_request_inserted instead of the tracepoint > in the subject and

[dm-devel] [PATCH 05/11] block: get rid of the trace rq insert wrapper

2020-06-30 Thread Chaitanya Kulkarni
Get rid of the wrapper for trace_block_rq_insert() and call the function directly. Signed-off-by: Chaitanya Kulkarni --- block/bfq-iosched.c | 4 +++- block/blk-mq-sched.c | 6 -- block/blk-mq-sched.h | 1 - block/kyber-iosched.c | 4 +++- block/mq-deadline.c | 4 +++- 5 files

Re: [dm-devel] [PATCH 05/11] block: get rid of the trace rq insert wrapper

2020-06-29 Thread Christoph Hellwig
On Mon, Jun 29, 2020 at 04:43:08PM -0700, Chaitanya Kulkarni wrote: > Get rid of the wrapper for trace_block_rq_insert() and call the function > directly. I'd mention blk_mq_sched_request_inserted instead of the tracepoint in the subject and commit message. Otherwise this looks fine. --