Re: [dm-devel] [PATCH 06/12] block: lift setting the readahead size into the block layer

2020-09-19 Thread Christoph Hellwig
On Thu, Sep 17, 2020 at 12:35:40PM +0200, Jan Kara wrote: > > diff --git a/block/blk-sysfs.c b/block/blk-sysfs.c > > index 81722cdcf0cb21..95eb35324e1a61 100644 > > --- a/block/blk-sysfs.c > > +++ b/block/blk-sysfs.c > > @@ -245,7 +245,6 @@ queue_max_sectors_store(struct request_queue *q, const >

Re: [dm-devel] [PATCH 06/12] block: lift setting the readahead size into the block layer

2020-09-17 Thread Jan Kara
On Thu 10-09-20 16:48:26, Christoph Hellwig wrote: > Drivers shouldn't really mess with the readahead size, as that is a VM > concept. Instead set it based on the optimal I/O size by lifting the > algorithm from the md driver when registering the disk. Also set > bdi->io_pages there as well by

[dm-devel] [PATCH 06/12] block: lift setting the readahead size into the block layer

2020-09-15 Thread Christoph Hellwig
Drivers shouldn't really mess with the readahead size, as that is a VM concept. Instead set it based on the optimal I/O size by lifting the algorithm from the md driver when registering the disk. Also set bdi->io_pages there as well by applying the same scheme based on max_sectors.

[dm-devel] [PATCH 06/12] block: lift setting the readahead size into the block layer

2020-09-10 Thread Christoph Hellwig
Drivers shouldn't really mess with the readahead size, as that is a VM concept. Instead set it based on the optimal I/O size by lifting the algorithm from the md driver when registering the disk. Also set bdi->io_pages there as well by applying the same scheme based on max_sectors.