Re: [dm-devel] [PATCH 07/21] libmultipath: use strbuf in parse_vpd_pg83()

2021-11-29 Thread Benjamin Marzinski
On Fri, Nov 19, 2021 at 12:13:24AM +0100, mwi...@suse.com wrote: > From: Martin Wilck > > By using the strbuf API, the code gets more readable, as we need > less output size checks. > > While at it, avoid a possible crash by passing a NULL pointer > to memchr(). > > Signed-off-by: Martin Wilck

Re: [dm-devel] [PATCH 07/21] libmultipath: use strbuf in parse_vpd_pg83()

2021-11-30 Thread Benjamin Marzinski
On Tue, Nov 30, 2021 at 12:26:47PM +0100, Martin Wilck wrote: > On Mon, 2021-11-29 at 19:18 -0600, Benjamin Marzinski wrote: > > On Fri, Nov 19, 2021 at 12:13:24AM +0100, mwi...@suse.com wrote: > > > -   out[0] = '1'; > > > -   len = 1; > > > -   while ((p = memc