Re: [dm-devel] [PATCH 1/4] libmultipath: fix sysfs dev_loss_tmo parsing

2020-07-02 Thread Benjamin Marzinski
On Thu, Jul 02, 2020 at 02:31:17PM +, Martin Wilck wrote: > On Wed, 2020-07-01 at 17:39 -0500, Benjamin Marzinski wrote: > > dev_loss_tmo is a u32 value. However the kernel sysfs code prints it > > as > > a signed integer. This means that if dev_loss_tmo is above INT_MAX, > > the > > sysfs valu

Re: [dm-devel] [PATCH 1/4] libmultipath: fix sysfs dev_loss_tmo parsing

2020-07-02 Thread Martin Wilck
On Wed, 2020-07-01 at 17:39 -0500, Benjamin Marzinski wrote: > dev_loss_tmo is a u32 value. However the kernel sysfs code prints it > as > a signed integer. This means that if dev_loss_tmo is above INT_MAX, > the > sysfs value will be a negative number. Parsing this was causing > sysfs_set_rport_tm

[dm-devel] [PATCH 1/4] libmultipath: fix sysfs dev_loss_tmo parsing

2020-07-01 Thread Benjamin Marzinski
dev_loss_tmo is a u32 value. However the kernel sysfs code prints it as a signed integer. This means that if dev_loss_tmo is above INT_MAX, the sysfs value will be a negative number. Parsing this was causing sysfs_set_rport_tmo() to fail. Signed-off-by: Benjamin Marzinski --- libmultipath/discov